Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-20] [Search v1] Improve performance of ReportListItem #42720

Closed
6 tasks
luacmartins opened this issue May 28, 2024 · 15 comments
Closed
6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented May 28, 2024

@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels May 28, 2024
@luacmartins luacmartins self-assigned this May 28, 2024
Copy link

melvin-bot bot commented May 28, 2024

Triggered auto assignment to @alexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 28, 2024
@luacmartins luacmartins moved this to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 28, 2024
@luacmartins luacmartins changed the title [Search v1] Improve performance of ReportListItem [POLISH][Search v1] Improve performance of ReportListItem May 28, 2024
@DylanDylann
Copy link
Contributor

DylanDylann commented May 29, 2024

@luacmartins Could I take over this issue as C+ contributor to conveniently follow updates there?

@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels May 29, 2024
@melvin-bot melvin-bot bot added the Overdue label May 31, 2024
@alexpensify alexpensify added the Reviewing Has a PR in review label May 31, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 31, 2024
@alexpensify
Copy link
Contributor

I believe that this one has a few PRs in the works, but there was one moved to production yesterday. For now, adding the Reviewing label.

@luacmartins luacmartins removed the Reviewing Has a PR in review label May 31, 2024
@luacmartins
Copy link
Contributor Author

We haven't started work on this one yet. @WojtekBoman can you comment here so I can assign this to you please?

@melvin-bot melvin-bot bot added the Overdue label Jun 3, 2024
@WojtekBoman
Copy link
Contributor

Hi! I'm going to work on that :)

@melvin-bot melvin-bot bot removed the Overdue label Jun 3, 2024
@luacmartins luacmartins changed the title [POLISH][Search v1] Improve performance of ReportListItem [Search v1] Improve performance of ReportListItem Jun 3, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jun 5, 2024
@alexpensify
Copy link
Contributor

@luacmartins - one of the PR has merged, are we waiting for more actions here? Thanks!

@luacmartins
Copy link
Contributor Author

luacmartins commented Jun 11, 2024

No, I think we're good for now just need to get this deployed.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 11, 2024
@melvin-bot melvin-bot bot changed the title [Search v1] Improve performance of ReportListItem [HOLD for payment 2024-06-18] [Search v1] Improve performance of ReportListItem Jun 11, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 11, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jun 11, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 13, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-18] [Search v1] Improve performance of ReportListItem [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Search v1] Improve performance of ReportListItem Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jun 13, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@DylanDylann
Copy link
Contributor

DylanDylann commented Jun 13, 2024

No need payment here. The PR is merged without my review

@luacmartins
Copy link
Contributor Author

We're good to close this one then!

@github-project-automation github-project-automation bot moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collect Jun 13, 2024
@alexpensify alexpensify changed the title [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Search v1] Improve performance of ReportListItem [HOLD for payment 2024-06-20] [Search v1] Improve performance of ReportListItem Jun 20, 2024
@alexpensify
Copy link
Contributor

Keeping closed and there is no Upwork job. No action on this payment date per this note:

#42720 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants