[HOLD for payment 2024-06-28] [$250] VBA - "Complete Process in Browser" link is not redirecting on Desktop app

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.78-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+emilio@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Access new.staging.expensify.com
2. Sign into a valid account
3. Go to Account Settings > WS > Workflow > Connect Bank account
4. Click on "Note: To connect with Chase, Wells Fargo, Capital One or Bank of America, please click here to complete this process in a browser."

Expected Result:

User expects the link to open in Safari Browser as other links do on Desktop app

Actual Result:

Link does not respond, no action happens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6497049_1717134846557.Link_does_not_work_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c6c74409f7507254
• Upwork Job ID: 1798085747644309504
• Last Price Increase: 2024-07-02
• Automatic offers:
• bernhardoj | Contributor | 102700241

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The complete process in browser text link does nothing when pressed.

What is the root cause of that problem?

The text link uses TextLink component

App/src/pages/ReimbursementAccount/BankAccountStep.tsx

Line 132 in d91979f

<TextLink href={bankAccountRoute}>{translate(plaidDesktopMessage)}</TextLink>

which calls Link.openLink.

App/src/components/TextLink.tsx

Lines 40 to 44 in d91979f

	if (onPress) {
	onPress(event);
	} else {
	Link.openLink(href, environmentURL);
	}

If the url is a new expensify url and has the same origin (host), it will use Navigation.navigate to navigate within the app, so it won't open a browser. And because we already at a bank account page, we are navigated to nowhere.

App/src/libs/actions/Link.ts

Lines 105 to 112 in d91979f

	if (internalNewExpensifyPath && hasSameOrigin) {
	if (Session.isAnonymousUser() && !Session.canAnonymousUserAccessRoute(internalNewExpensifyPath)) {
	Session.signOutAndRedirectToSignIn();
	return;
	}
	Navigation.navigate(internalNewExpensifyPath as Route);
	return;
	}

What changes do you think we should make in order to solve the problem?

We can have a new props for TextLink and new param for Link.openLink to force it to open the link on a browser (to use openExternalLink).

OR

To keep it clean, just pass an onPress to TextLink and handle it ourself.

onPress={() => Link.openExternalLink(bankAccountRoute)}

[melvin-bot]

@abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c6c74409f7507254

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Ollyws]

I can't reproduce this, it's is opening the browser fine for me...

[bernhardoj]

@Ollyws you need to manually change the URL here to https://dev.new.expensify.com:{port} (or without port works too I guess) in dev

App/src/CONFIG.ts

Line 14 in 47d5f5f

const newExpensifyURL = Url.addTrailingForwardSlash(get(Config, 'NEW_EXPENSIFY_URL', 'https://new.expensify.com/'));

The reason it happens is explained in my proposal (hopefully it's clear)

[Ollyws]

Ahh yeah I see, thanks.
@bernhardoj's proposal LGTM.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abekkala]

@MonilBhavsar do you agree with @Ollyws selected proposal above?

[melvin-bot]

@Ollyws, @abekkala, @MonilBhavsar Eep! 4 days overdue now. Issues have feelings too...

[MonilBhavsar]

Looks good, let's just pass onPress function

[melvin-bot]

Upwork job price has been updated to $125

[MonilBhavsar]

Adjusting the price, since this is minor one liner change cc @abekkala

[bernhardoj]

PR is ready

cc: @Ollyws

@MonilBhavsar @abekkala Btw, may I request to keep the price at 250? I think it's not good that the price is reduced because the solution turns out to be simple 😢.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix "Complete Process in Browser" link does not redirect to browser #43541

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment through NewDot Manual Requests
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

PAYMENT SUMMARY FOR JUNE 28

• Fix: @bernhardoj [$125, if no regresssions] Offer Link
• PR Review: @Ollyws [$125, if no regressions] Payment via NewDot
  Please complete checklist.

[bernhardoj]

@abekkala any thoughts on my comment here?

[abekkala]

@bernhardoj Oh, I'll let @MonilBhavsar weigh in here on the complexity and the appropriate payment price

[Ollyws]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR:

This wasn't working since before we added the connect bank account link on the workspace workflow page, so I don't think we can pin it on any PR as it was simply uncovered when we added that feature.

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• Determine if we should create a regression test for this bug.

Yes.

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Desktop only

1. Go to Settings > WS > Workflow > Connect Bank account
2. Click on "Note: To connect with Chase, Wells Fargo, Capital One or Bank of America, please click here to complete this process in a browser."
3. Verify it opens a bank account page in a new browser

Do we agree 👍 or 👎

[abekkala]

I've also asked @MonilBhavsar in slack irt price

[melvin-bot]

@Ollyws, @abekkala, @MonilBhavsar, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abekkala]

@bernhardoj updated offer has been sent

[abekkala]

PAYMENT SUMMARY

Fix: @bernhardoj [$250]Offer Link
PR Review: @Ollyws [$250] Payment via NewDot

[bernhardoj]

Thanks, accepted!

[melvin-bot]

Upwork job price has been updated to $250

[abekkala]

@bernhardoj payment sent and contract ended - thank you! 🎉

[Ollyws]

Requested payment in ND.

[JmillsExpensify]

$250 approved for @Ollyws