[HOLD for payment 2024-07-10] [$250] Accounting - Tapping back from workspace settings page takes user back to Organizations page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.78-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace
3. Enable accounting in more features
4. Connect to Xero with two organizations
5. Open accounting page
6. Open Xero organization page
7. Select another organization
8. Tap on back icon at the top left from accounting page
9. Tap on back icon at the top left from Workspace settings page

Expected Result:

App should navigate user to workspaces list page after tapping back from workspace settings page

Actual Result:

App navigates user back to Xero organization selection page from Workspace settings page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6497310_1717150765484.Screen_Recording_20240531_131132_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d365096f3f3bce65
• Upwork Job ID: 1800594530685488123
• Last Price Increase: 2024-06-11
• Automatic offers:
• tienifr | Contributor | 102732992

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App navigates user back to Xero organization selection page from Workspace settings page

What is the root cause of that problem?

• In here, we call Navigation.goBack(ROUTES.WORKSPACE_ACCOUNTING.getRoute(policyID)), that leads to there are two FullScreenNavigator are added to route stacks.

What changes do you think we should make in order to solve the problem?

• Just need to call Navigation.goBack()

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[anmurali]

Hmm I cannot even get past step 4

Screen.Recording.2024-06-04.at.8.11.09.PM.mov

[tienifr]

@anmurali You need to connect 2 xero organizations:

Screen.Recording.2024-06-05.at.10.54.23.mov

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[anmurali]

Gotcha. Going to slap a help wanted label on this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d365096f3f3bce65

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[rushatgabhane]

is this issue only on organization page? @tienifr

[rushatgabhane]

let's fix it for all pages. 🎀👀🎀
#42924 (comment)

[melvin-bot]

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[shubham1206agra]

@rushatgabhane Thanks for taking over.

[Julesssss]

Hey @tienifr is there a WIP PR?

[tienifr]

PR will be opened in the next 30 minutes because I need to do some tests.

[tienifr]

@rushatgabhane PR #43820 is ready

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: App navigates user back to Xero organization selection page from Workspace settings page #43820

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: [Wave Collect] [Xero] Fix UX inconsistencies for Organization page #41417

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/41417/files#r1669152823

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. - No. Pretty edge case

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

@anmurali could you please attach a payment summary, thanks!

[melvin-bot]

@Julesssss, @anmurali, @rushatgabhane, @tienifr Eep! 4 days overdue now. Issues have feelings too...

[anmurali]

Payment summary

• C+ @rushatgabhane $250 approved for New Dot
• C @tienifr $250 approved via Upwork

[tienifr]

Sorry, I actually started to receive payment via NewDot since 2024-04-06, I've refunded on Upwork and requested again on NewDot

[JmillsExpensify]

$250 approved to @rushatgabhane

[JmillsExpensify]

$250 approved for @tienifr