[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Accounting-Renaming Customers/Projects tag doesn't work and has weird behavior while offline

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.78-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Pre-requisite:

• Account must have a workspace connected with a QBO

1. Navigate to staging.new.expensify.com
2. Go to settings > Workspace and select the workspace you have QBO setup with
3. Go to tags
4. Go to Customers/Projects tag
5. Open any tag and rename it
6. Go offline
7. Go to Customers/Projects tag again and rename a tag
8. Go to Classes tag

Expected Result:

On step 5 after renaming the tag the renamed tag must appear in the tag list, and on step 8 the renamed tag on step 7 should not appear on Classes tag

Actual Result:

On step 5 after renaming the tag it is not being reflected on the tag list. And on step 8 while the user is offline and tries to rename the tag in Customers/Projects the renamed tag is visible on Classes tag list.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6498326_1717229886791.bandicam_2024-06-01_11-05-59-116.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f7371d4279355423
• Upwork Job ID: 1797044032564117504
• Last Price Increase: 2024-06-01

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f7371d4279355423

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[goldenbear101]

Since the issue described with Expensify involves the renaming of tags in the Customers/Projects section not working as expected, particularly when you are offline. I'll get a detailed breakdown of the problem and potential steps to investigate and fix it. Please do keep contact.

[puneetlath]

Not a blocker as discussed here: https://expensify.slack.com/archives/C036QM0SLJK/p1717423475598289

[trjExpensify]

I wanted to test this against the latest changes here: #42543 but I can't run an adhoc build on that anymore because it's merged awaiting a staging deploy.

[carlosmiceli]

Ah, was about to start triaging what to do because I found that the PR that caused this was this one: #42315

@puneetlath Now this would be a regular bug then, correct?

[trjExpensify]

Yeah, this isn't a deploy blocker - but let's fix it if you know what the issue is and the changes in this PR hasn't solved it already! CC: @hayata-suenaga

[carlosmiceli]

Not sure what the issue is, just looked at the PRs and this one is almost for sure the one that's causing it. @hayata-suenaga wanna tackle it since you probably have more context on what could be breaking it?

[carlosmiceli]

@trjExpensify I added the External label over the weekend but should we keep it now?

[hayata-suenaga]

The PR is open

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make renaming of tags works #43005

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make renaming of tags works #43005

If no regressions arise, payment will be issued on 2024-06-20. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
• [@hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hayata-suenaga] Determine if we should create a regression test for this bug.
• [@hayata-suenaga] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[hayata-suenaga]

[@hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:

This is a new feature. We just didn't account for multi tag before.

[@hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

[@hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

No need for discussion

[@hayata-suenaga] Determine if we should create a regression test for this bug.

N/A

[@hayata-suenaga] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

N/A

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[sakluger]

@s77rt do you need to be paid here for the PR review, or are you being paid somewhere else?

[s77rt]

@sakluger I'm due payment here

[sakluger]

Summarizing payment on this issue:

Contributor+: @s77rt $250, please request via Newdot

[JmillsExpensify]

$250 approved for @s77rt