Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Detailed Portion] Add GL/Payroll/Tax Codes to NewDot #43028

Closed
4 tasks
dylanexpensify opened this issue Jun 4, 2024 · 15 comments
Closed
4 tasks

[Detailed Portion] Add GL/Payroll/Tax Codes to NewDot #43028

dylanexpensify opened this issue Jun 4, 2024 · 15 comments
Assignees
Labels
Reviewing Has a PR in review Task Weekly KSv2

Comments

@dylanexpensify
Copy link
Contributor

DESIGN DOC: Here

Deadline: August 1st, 2024

Assignee: @rushatgabhane

Price: $500

Coming from this internal GH, we need a C+ to:

  • Build new pages for adding GL Code and Payroll code to Categories/GL code to Tags/Tax code to Taxes
  • Build the menu items for Categories, Tags and Taxes
  • Complete the onyx pieces (for offline first) for showing & modifying all the new data, etc.
  • Fill these sections out in the above Design Doc
@dylanexpensify
Copy link
Contributor Author

@rushatgabhane @Gonals is going to be our internal engineer on this!

@dylanexpensify
Copy link
Contributor Author

Rushat killed it, waiting for implementation

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 26, 2024
@dylanexpensify
Copy link
Contributor Author

@rushatgabhane mind giving us a breakdown of where we're at?

@rushatgabhane
Copy link
Member

Policy category - Add GL Code

PR approved - #43149
Backend merged

Policy category - Add Payroll Code

Awaiting C+ review by @hoangzinh - #43151
Backend merged

Tags - Add GL Code

Awaiting C+ review and backend is not deployed yet. - #43155

Taxes - Add tax code

Awaiting backend PR and deployment so I'm holding on that - #43156

@dylanexpensify
Copy link
Contributor Author

Ongoing! Mind giving an update here, @rushatgabhane ?

@rushatgabhane
Copy link
Member

@dylanexpensify same as above.

Only thing is, the frontend is ready for Tax Code page - #43156

@dylanexpensify
Copy link
Contributor Author

Nice, thank you!

@hoangzinh
Copy link
Contributor

hoangzinh commented Jul 17, 2024

@dylanexpensify can you assign me (and @shubham1206agra) to this issue for payment later? We helped to review PRs in this list #43028 (comment). Thank you.

I just found out that we already have a issue here #44256

@rushatgabhane
Copy link
Member

Update: All PRs except Tax code on production.

Tax code - #43156

@dylanexpensify
Copy link
Contributor Author

NICE! Looks like Tax code is on prod as of 3 days ago 🎉 What's left for us to close this out and get you paid @rushatgabhane?

@rushatgabhane
Copy link
Member

@dylanexpensify no all set!

@rushatgabhane
Copy link
Member

@dylanexpensify i guess we're paying per issue? #44255 (comment)

So $250 x 4 tasks. Does this sound right?

@dylanexpensify
Copy link
Contributor Author

@rushatgabhane ah yeah, we can do by issue! Have they all had the payment summaries added?

@rushatgabhane
Copy link
Member

rushatgabhane commented Aug 5, 2024

@dylanexpensify yes they have. Thank you : )

We can close this issue now

@dylanexpensify
Copy link
Contributor Author

nice! Great work here man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewing Has a PR in review Task Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

4 participants