-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Track Expense - Hmm..not here page on selecting category with no existing workspace #43073
Comments
Triggered auto assignment to @blimpich ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #vip-vsb |
Looking into this. |
Reproduced it locally. I think this PR is really suspicious given the timing and the area of the codebase. Reverting that PR locally doesn't fix it though, so that doesn't seem like its the root cause. Not 100% sure if this is backend or frontend, seems like frontend because I can't find any wonky network requests or logs that are giving me any leads. Though maybe it has to do with bad handling of onyx updates in the backend. Not sure. Reached out in #expensify-opensource (link) |
I think this might be backend related, since I went back about a week and a half in App history and its still an issue. Stuck on how to debug this. Can't seem to figure out where it is going wrong. |
Huh, well when I actually try to reproduce this on staging it doesn't reproduce, so maybe someone put out a fix that is related to this. |
Weird, yup, pulled everything and now its working locally on main. |
In the meantime I think we can demote as this is no longer reproducing for me on staging or locally. Should probably figure out what the exact cause was, but seems to be fixed. |
Tester can reproduce the bug with new gmail account too. RPReplay_Final1717548936.MP4RPReplay_Final1717549357.MP4 |
ProposalPlease re-state the problem that we are trying to solve in this issue.Hmm..not here page on selecting category with no existing workspace What is the root cause of that problem?When navigating to the confirmation page, the reportID parameter is undefined, causing this bug App/src/pages/iou/request/step/IOURequestStepCategory.tsx Lines 147 to 149 in 3c04b02
The report.reportID is undefined because we're utilizing the wrong report field. In this scenario, we should be using reportDraft instead of realReport.
The realReport screenshot lacks crucial information. What changes do you think we should make in order to solve the problem?
we should update to use draftReport if realReport.reportID is null
After implementing this change, the application crashes due to another bug in the getDefaultMileageRate function. In this function, we need to incorporate optional chaining.
After making those adjustments, everything seems to be functioning well, but there's an issue with the "to" field on the confirmation page, which displays as "undefined workspace." This problem is likely caused by the same bug we encountered earlier in here We should also apply the same fix to resolve the issue with the "to" field on the confirmation page. My suggestion: we should consider creating a utility function to address this bug in other parts of the codebase as well. |
@cretadn22 thank you for your proposal! Question: wouldn't the root cause of this problem be that the reportID is undefined when it should be defined? |
@blimpich No, reportID is valuable when it is defined. But it is defined in reportDraft and we utilize reportReal. More detail in my proposal |
This to me seems like the issue, the backend isn't finding the report when we open the list of categories: thank you @ZhenjaHorbach for pointing out this error to me here. |
Plus |
Yeah we can see here that we really shouldn't be calling openReport since (A) why would we need to when we're just opening the category list and (B) we don't call openReport when we do the same flow but with a workspace. Screen.Recording.2024-06-05.at.12.20.07.PM.mov |
Job added to Upwork: https://www.upwork.com/jobs/~01a18541e1775fab5a |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha ( |
Opening this up to contributors since this discussion makes me believe this is a frontend issue, and I can't find a PR that, when reverted, totally fixes the problem. |
Triggered auto assignment to @CortneyOfstad ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Hmm..not here page on selecting category with no existing workspace What is the root cause of that problem?When there is no existing workspace, we create a draft policy and draft report to categorize the track expense. Let see the And then in What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)NA |
@getusha any feedback on the proposal above? |
Reviewing proposals. |
I am testing the proposals to see if it works and doesn't break anything. I'll have an update before EOD today. |
@mananjadhav any update on the testing? |
@mananjadhav, @CortneyOfstad, @blimpich Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@mananjadhav @CortneyOfstad @blimpich this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
I was out sick past 3-4 days. I'll post an update today/tomorrow. |
Thanks @mananjadhav and hope you're feeling better! |
Apologies for the delay here. I've been trying to reproduce this on staging and the latest main. But I haven't been able to reproduce the bug. Earlier when it was reported I was able to, but not recently. @kbecciv @CortneyOfstad @blimpich Are you able to consistently reproduce this? Here's the video from Web web-not-found-on-categorize.moviPhone Safari mweb-safari-not-found-on-categorize.mp4and I've tried this on Native, Mobile Web, Mac Safari. Tried it with 3 different new accounts. @CortneyOfstad @blimpich I do see |
I can no longer reproduce this either, seems to have been fixed elsewhere. Closing. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4-79-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4594444&group_by=cases:section_id&group_order=asc&group_id=309130
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
As per step TC 6 - After selecting a category, the "To" field should be filled with a "new" workspace
Actual Result:
Hmm..not here page on selecting category with no existing workspace
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6502071_1717534334395.RPReplay_Final1717534228.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mananjadhavThe text was updated successfully, but these errors were encountered: