Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not auto focusing to the required Input inside Workspace page #4308

Closed
1 of 5 tasks
aman-atg opened this issue Jul 29, 2021 · 12 comments
Closed
1 of 5 tasks

Not auto focusing to the required Input inside Workspace page #4308

aman-atg opened this issue Jul 29, 2021 · 12 comments
Assignees
Labels
External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@aman-atg
Copy link
Contributor

aman-atg commented Jul 29, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to the workspace
  2. Click on the invite button
  3. Email or Phone Input will not be focused

Expected Result:

It should be focused

expensifyUX_fix.mp4

Actual Result:

expensifyUX.mp4

Workaround:

Visual/UX

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

@aman-atg aman-atg added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Jul 29, 2021
@MelvinBot
Copy link

Triggered auto assignment to @alexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jul 29, 2021
@aman-atg
Copy link
Contributor Author

Proposal

  • We can create a ref element for Phone or Email Input and then add focus using the below code after line 89 (With some other required changes on other places)
            <ScreenWrapper onTransitionEnd={() => {
                if (this.emailOrPhoneInputRef) {
                    this.emailOrPhoneInputRef.focus();
                }
            }}
            >

@aman-atg aman-atg changed the title Not auto focusing inside Workspace page Not auto focusing to the required Input inside Workspace page Jul 29, 2021
@parasharrajat
Copy link
Member

The workspace feature is still in beta. There would be more pages coming to Workspaces. If you like to fix this, it's good if you can check other pages and fix them all.

@aman-atg
Copy link
Contributor Author

@parasharrajat let me know if it's happening on any other page.
Currently I can see this behaviour only on this page

@MelvinBot
Copy link

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@alexpensify alexpensify removed the Daily KSv2 label Jul 29, 2021
@stitesExpensify
Copy link
Contributor

@aman-atg your proposal sounds good to me. @alexpensify can we get an upwork job spun up for this?

@alexpensify alexpensify added the External Added to denote the issue can be worked on by a contributor label Aug 2, 2021
@MelvinBot
Copy link

Triggered auto assignment to @marklouisdeshaun (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot MelvinBot added Daily KSv2 and removed Weekly KSv2 labels Aug 2, 2021
@marklouisdeshaun
Copy link
Contributor

Job posted to Upwork

@MelvinBot MelvinBot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 3, 2021
@MelvinBot
Copy link

Triggered auto assignment to @marcaaron (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@marklouisdeshaun marklouisdeshaun removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 3, 2021
@aman-atg aman-atg mentioned this issue Aug 3, 2021
5 tasks
@marklouisdeshaun marklouisdeshaun added Weekly KSv2 and removed Daily KSv2 labels Aug 5, 2021
@MelvinBot MelvinBot removed the Overdue label Aug 5, 2021
@marcaaron
Copy link
Contributor

Sorry for the delay here. I have left an initial review @aman-atg. Let me know when updates are made, thanks.

@marcaaron marcaaron added the Reviewing Has a PR in review label Aug 16, 2021
@mallenexpensify
Copy link
Contributor

Paid in Upwork because it's been over 7 days since merge yet before our 7 days after production update for payment. Added bonus for reporting the issue

@mallenexpensify
Copy link
Contributor

Forgot to close....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants