Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add autofocus #4402

Merged
merged 4 commits into from
Aug 17, 2021
Merged

add autofocus #4402

merged 4 commits into from
Aug 17, 2021

Conversation

aman-atg
Copy link
Contributor

@aman-atg aman-atg commented Aug 3, 2021 •
edited
Loading

Details

Comment

Fixed Issues

$ #4308

Tests || QA Steps

  1. Go to the workspace
  2. Choose people tab
  3. Click on the invite button
  4. Input will be focused

Tested On

  • Web
  • Mobile Web
  • Android
  • Can't test on these two
  • Desktop
  • iOS

Screenshots

Web

prWeb.mp4

Mobile Web

mWeb.mp4

Desktop

iOS

Android

M.mp4

@aman-atg aman-atg requested a review from a team as a code owner August 3, 2021 23:12
@MelvinBot MelvinBot requested review from marcaaron and removed request for a team August 3, 2021 23:12
@aman-atg aman-atg marked this pull request as draft August 3, 2021 23:12
@aman-atg aman-atg marked this pull request as ready for review August 4, 2021 20:35
@aman-atg
Copy link
Contributor Author

aman-atg commented Aug 9, 2021

@marcaaron this PR is ready for review.

@marcaaron
Copy link
Contributor

Just a heads up it may take me several days to get to this review. Thanks for your patience.

In the meantime, can we please add Test + QA Steps to the PR description?

@aman-atg
Copy link
Contributor Author

aman-atg commented Aug 9, 2021

Sorry, I can't test on other two devices.
Added the QA steps.

marcaaron
marcaaron reviewed Aug 16, 2021
View reviewed changes
Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up @aman-atg this PR has conflicts that need to be fixed. I will review promptly once they are fixed. Thanks.

src/pages/workspace/WorkspaceInvitePage.js Outdated Show resolved Hide resolved
@marcaaron marcaaron merged commit e4f4ed7 into Expensify:main Aug 17, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 17, 2021
Closed
@OSBotify OSBotify mentioned this pull request Aug 25, 2021
Closed
@aman-atg aman-atg deleted the aman-atg-autoFocusWorkspacePage branch August 30, 2021 13:05
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 1, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcaaron marcaaron marcaaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aman-atg @marcaaron @OSBotify @botify