[HOLD for payment 2024-07-26] [$250] Workspace - "Delay submissions" turns off if the "Submission frequency" is set to "Manually"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.80-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in with a new expensifail account
2. Create a workspace
3. Turn "Workflows" on
4. Navigate to Workflows
5. Turn "Delay submissions" on
6. Set "Submission frequency" to "Manually"

Expected Result:

"Delay submissions" should remain on

Actual Result:

"Delay submissions" turns off if the "Submission frequency" is set to "Manually"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6501893_1717524990298.bandicam_2024-06-04_19-14-44-441.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015bf509d8291c1690
• Upwork Job ID: 1800519449372778818
• Last Price Increase: 2024-06-25

Issue Owner

Current Issue Owner: @dukenv0307

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Workspace - "Delay submissions" turns of if the "Submission frequency" is set to "Manually"

What is the root cause of that problem?

• We do not add the correct optimistic data when set submission frequency to "Manually"

What changes do you think we should make in order to solve the problem?

• We need to add the below optimistic data when calling setWorkspaceAutoReportingFrequency:

[
    {
        "key": "policyID_${policyID}",
        "onyxMethod": "merge",
        "value": {
            "harvesting": {
                "enabled": false
            },
            "autoReporting": true,
            "autoReportingFrequency": "immediate"
            "pendingFields": {autoReporting: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE},

        }
    }
]

if the frequency is manual.

• Also, we need to reset the above optimistic data if API is failed.

What alternative solutions did you explore? (Optional)

• Maybe the above optimistic data will be changed if there was BE error in this case and we fixed it, but in general, we need to check what data BE returns in case of manually, then we set the optimistic data based on it.

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - "Delay submissions" turns of if the "Submission frequency" is set to "Manually"

What is the root cause of that problem?

The root cause of the problem is that when a user sets it to manual, the policy?.harvesting?.enabled becomes false.

The policy?.harvesting?.enabled is false because it checks whether the scheduled submission is enabled which won't be in this situation.

App/src/types/onyx/Policy.ts

Lines 777 to 781 in f3bb5a5

	/** Scheduled submit data */
	harvesting?: {
	/** Whether the scheduled submit is enabled */
	enabled: boolean;
	};

Hence, the condition that makes the isActive in the WorkspaceWorkflowsPage becomes false when the auto-reporting frequency is manual.

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 132 in f3bb5a5

isActive: (policy?.harvesting?.enabled && policy.autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT && !hasDelayedSubmissionError) ?? false,

What changes do you think we should make in order to solve the problem?

Therefore, we must consider the autoReportingFrequency if it is CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL.

Just like we did with the CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT.

So, let's change the isActive logic to something simpler than the one below.

isActive: (((policy?.harvesting?.enabled && policy.autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT ) ?? (policy?.harvesting?.enabled && policy.autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL) ) && !hasDelayedSubmissionError) ?? false,

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015bf509d8291c1690

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

@sonialiap, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sonialiap]

@abdulrahuman5196 what do you think of the above proposal?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

Hi, I am back now since I was OOO for couple of days as posted in slack. Will work on review today.

[abdulrahuman5196]

checking now

[abdulrahuman5196]

Hi all, I dont see the Delay submissions option in the workflow? Do I need to be part of some beta or any specific type of workspace?

[melvin-bot]

@sonialiap @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[dominictb]

@abdulrahuman5196 You need to set canUseAllBetas: true.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@sonialiap, @abdulrahuman5196 Huh... This is 4 days overdue. Who can take care of this?

[abdulrahuman5196]

Hi @sonialiap Sorry for the delay, I have limited availability at the moment. So unassigning myself. Kindly reassign another C+ for review.

[roryabraham]

PR is C+ approved, just waiting on review from @Beamanator, @mountiny, and/or @madmax330

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix auto reporting toggle #45540

If no regressions arise, payment will be issued on 2024-07-26. 🎊

For reference, here are some details about the assignees on this issue:

• @dukenv0307 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dukenv0307] Determine if we should create a regression test for this bug.
• [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Tony-MK]

Hey, @roryabraham, I am curious to know if I am eligible for compensation for providing a solution that was used in the recently merged PR based on your previous comment.

Thank you

[sonialiap]

@roryabraham what do you think? #43196 (comment)

[sonialiap]

Payment summary:

• @dukenv0307 $250 - offer sent in upwork - please complete the checklist - paid ✔️

https://www.upwork.com/ab/applicants/1816797650551015987/job-details

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @dukenv0307 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@sonialiap)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1800519449372778818/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[dukenv0307]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression tests:

1. Create a workspace
2. Go to workspace settings, click more features, and enable workflows
3. Go to workflows and toggle delay submissions
4. Switch the reporting frequency to Daily. Verify that it works and shows Daily
5. Switch the reporting frequency to Manually. Verify that it works and shows Manually.

Do we 👍 or 👎

[roryabraham]

Hey, @roryabraham, I am curious to know if I am eligible for compensation for providing a solution that was used in the recently merged

Sorry, but no I don't think so. I figured out the solution by looking at back-end code, and the proposal you posted wasn't a complete and correct solution. I merely meant to acknowledge that out of all the proposals yours was the closest to being correct.

[sonialiap]

@dukenv0307 please accept the offer in upwork 💰

[melvin-bot]

@sonialiap, @roryabraham, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@sonialiap, @roryabraham, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[dukenv0307]

@sonialiap Sorry I don't see any offer, could you check again and send an offer to my profile here https://www.upwork.com/freelancers/~01f5cbe690701118a2

Thank you!

[sonialiap]

@dukenv0307 it seems like I sent the offer to that profile, I just sent a message on the offer. Let me know if you don't see it then I'll resend :D

[sonialiap]

Oh I misnamed the offer with another issue number 🤦 I called it 44830, updated in upwork to 43196

[dukenv0307]

@sonialiap No worry, I accepted it

[sonialiap]

Paid ✔️