[HOLD for payment 2024-06-28] [$250] Hold expenses - "iou.genericHoldExpenseFailureMessage" error when holding a paid expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4605660
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. [User A] Submit expense to User B
3. [User A] Go to transaction thread
4. [User A] Go to 3-dot menu > Hold
5. [User A] Leave the Hold RHP open
6. [User B] Pay the expense
7. [User A] After the expense is paid on their end, enter a reason and save it

Expected Result:

User A will receive an error that the expense cannot be held/edited

Actual Result:

User A receives the error "iou.genericHoldExpenseFailureMessage"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6504952_1717762800154.bandicam_2024-06-07_20-15-53-640.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015aa1fc4dd1f5a60d
• Upwork Job ID: 1800577247384003062
• Last Price Increase: 2024-06-11
• Automatic offers:
• bernhardoj | Contributor | 102706048

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error message key is shown instead of the text when hold message error is shown.

What is the root cause of that problem?

In the failure data of hold request, we set the error key to iou.genericHoldExpenseFailureMessage.

App/src/libs/actions/IOU.ts

Line 6791 in b94ccf3

errors: ErrorUtils.getMicroSecondOnyxError('iou.genericHoldExpenseFailureMessage'),

However, this error message key doesn't exist on the translation file, so the error key is shown instead.

If we open the translation file,

App/src/languages/en.ts

Line 738 in b94ccf3

genericHoldExpenseFailureMessage: 'Unexpected error while holding the expense. Please try again later.',

The genericHoldExpenseFailureMessage is located inside the iou.error object.

What changes do you think we should make in order to solve the problem?

Update the error key to iou.error.genericHoldExpenseFailureMessage

[alexpensify]

This one slipped my radar; I will test it tomorrow.

[alexpensify]

I didn't get a generic error but I was able to save the Hold action.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015aa1fc4dd1f5a60d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[alexpensify]

@parasharrajat can you please review if this proposal will fix the issue and flag when an expense can't be put on Hold? Thanks!

[parasharrajat]

@bernhardoj's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @parasharrajat

[alexpensify]

Update the PR is going through the review process.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix wrong hold/unhold expense error key #43629

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: fix: hold Expense option is displayed on expenses on a closed report #42574
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42574/files#r1649711464
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@parasharrajat] Determine if we should create a regression test for this bug. yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. [User A] Submit multiple expenses to User B
2. [User A] Go to one of the transaction thread
3. [User A] Press the 3-dot menu and choose Hold
4. [User B] Pay the expense
5. [User A] After the expense is paid on their end, enter a hold reason and save it
6. [User A] Verify the unexpected error message is shown

Do you agree 👍 or 👎 ?

[Julesssss]

Test steps are fine, but I don't think we need a full regression test for this simple text issue tbh.

[alexpensify]

Automation worked here, I'll work on the payment process tomorrow.

[alexpensify]

Payouts due: 2024-06-28

• Contributor: $250 @bernhardoj
• Contributor+: $250 @parasharrajat

Upwork job is here.

Status: @parasharrajat please submit a request in Chat. @bernhardoj has been paid in Upwork. I now need to create the regression test.

[parasharrajat]

Payment requested as per #43279 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat