[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [Search v1] Implement dynamic column logic server side

[luacmartins]

Implement this section of the design doc

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Current assignee @kevinksullivan is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

@luacmartins, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kevinksullivan]

I don't believe I need to be on this @luacmartins , but lmk if I am misunderstanding!

[JmillsExpensify]

Feel free to add me for payment if needed.

[luacmartins]

This is done and deployed.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add dynamic columns #43869

If no regressions arise, payment will be issued on 2024-07-02. 🎊

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[ikevin127]

@luacmartins When you get a chance, can you please assign a BZ team member for payment here ? Thank you!

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Christinadobrzyn]

Prepping for payouts due:

• Contributor+: $250 @ikevin127 - (Paid in Upwork - https://www.upwork.com/nx/wm/offer/102949975)

Even though this is internal, do we want a regression test for this?

[ikevin127]

@Christinadobrzyn Yes, I'm currently using Upwork for payments.

Not sure if regression test is needed here but here it is anyway:

Regression Test Proposal

Pre-requisite:

• An account with a money request and no policy (workspace).

1. Open the new Search page.
2. Verify that you can see the money request and the Category, Tag and Tax columns are not shown.
3. Create a new policy.
4. Verify that Categories feature is enabled.
5. Open the new Search page.
6. Verify that the Category column is shown.
7. Enable Tags in the policy.
8. Verify that both Category and Tag columns are now shown in the new Search page.
9. Enable Taxes in the policy.
10. Verify that Category, Tag and Tax columns are now shown in the new Search page.

Do we agree 👍 or 👎.

[luacmartins]

No need for regression tests, we'll add those as part of the project wrap up

[Christinadobrzyn]

Thanks @ikevin127 - can you please accept this Upwork offer? #43494 (comment)

[ikevin127]

@Christinadobrzyn Accepted, thank you!

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[Christinadobrzyn]

Awesome paid out @ikevin127 through Upwork based on this payment summary #43494 (comment)

I think we're good to close this!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add dynamic columns #43869

If no regressions arise, payment will be issued on 2024-07-10. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins] Determine if we should create a regression test for this bug.
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: