[HOLD][$250] Send invoices - Date notification not copied when invoice date is changed

[lanitochka17]

Held on #43797

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): abebemiherat@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to FAB > Send invoice
2. Add amount, select user and workspace
3. Add merchant and send the invoice
4. Go to invoice details and change the date
5. Notice the notification appears. Attempt to copy it, but it doesn't work

Expected Result:

The date notification should be copied when the invoice date is changed

Actual Result:

After sending the invoice, changing the date triggers a notification. However, attempting to copy the notification fails

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6510653_1718188876505.Screen_Recording_2024-06-12_at_3.39.34_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0111e39bcf78303fbe
• Upwork Job ID: 1803213787847433243
• Last Price Increase: 2024-06-25
• Automatic offers:
• c3024 | Contributor | 102904588

Issue Owner

Current Issue Owner: @getusha

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

Testing now.

[strepanier03]

Confirmed reproducible on mac Chrome.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0111e39bcf78303fbe

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Attempting to copy the notification fails

What is the root cause of that problem?

When creating an invoice, in

App/src/libs/actions/IOU.ts

Line 3560 in 340f221

...(invoiceChatReport?.reportID ? {receiverInvoiceRoomID: invoiceChatReport.reportID} : {receiverEmail: receiver.login ?? ''}),

, the params createdIOUReportActionID and reportActionID (IOU action id) are not sent to back-end to use as real report action ids.

So the back-end is creating new IOU action id and send back to front-end. This makes the Invoice has 2 IOUs, so the transactionThreadReportID here is undefined.

Because of that, the originalReportID here is incorrect, it will be the iou report id while it must be the transactionThreadReportID

Next, the reportAction here will be empty (we try to get the modified expense report action from the IOU report which is not found, because originalReportID is wrong above)

So the copying doesn't work because reportAction is empty.

What changes do you think we should make in order to solve the problem?

When creating an invoice, in

App/src/libs/actions/IOU.ts

Line 3560 in 340f221

...(invoiceChatReport?.reportID ? {receiverInvoiceRoomID: invoiceChatReport.reportID} : {receiverEmail: receiver.login ?? ''}),

, the params createdIOUReportActionID and reportActionID (IOU action id) should be sent to back-end.

Those can be returned from the getSendInvoiceInformation

App/src/libs/actions/IOU.ts

Line 1852 in 340f221

transactionThreadReportID: optimisticTransactionThread.reportID,

createdIOUReportActionID: optimisticCreatedActionForIOUReport.reportActionID,
reportActionID: iouAction.reportActionID,

The back-end should be updated to make sure to support those params, and use them as the real action ids. If not mistaken, at the moment it's supporting createdIOUReportActionID but not reportActionID

What alternative solutions did you explore? (Optional)

In

App/src/libs/ReportUtils.ts

Line 6042 in 340f221

const transactionThreadReportID = ReportActionsUtils.getOneTransactionThreadReportID(reportID, reportActions ?? ([] as ReportAction[]));

, use the reportActions after applying getContinuousReportActionChain so that it will get the correct chain of report actions. This is same method as of ReportScreen

[melvin-bot]

@strepanier03, @getusha Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[getusha]

@strepanier03 Reassigning this due to low bandwidth @c3024 will takeover

[melvin-bot]

@strepanier03 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[c3024]

Need a little more time to finalize @MelvinBot

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[c3024]

Not overdue @MelvinBot

[melvin-bot]

@strepanier03 @cristipaval @c3024 this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[tsa321]

@c3024 @cristipaval If we want to handle the similar errors in Front End based on this message, we could remove the optimistic created report actions (and optimistic IOU report action) after the API request completed. Similar to my proposal in other issue.

[rayane-djouah]

Hey @c3024, Could you please take a look at this issue?, looks like these two bugs will be fixed by the same changes proposed here and here, wdyt?

[c3024]

@rayane-djouah yes, you are right. Both issues will be fixed by the same changes.

[c3024]

@tsa321 Removing the optimistic report actions in success data does not look a correct pattern to me. Is there anywhere in the repo that we do this?

[cristipaval]

Ok, so we are holding on to this issue for #43797. Correct?

[c3024]

Oh, it looks like that issue was already assigned. I thought that issue was held and this was moving. 😆

Yes, this issue can be held. PR for #43797 should fix this.

[cristipaval]

Still held

[cristipaval]

We're actively working on the issue that this one is held on

[cristipaval]

The PR fixing the issue that this one is held on has been merged. Waiting for it to get deployed.

[cristipaval]

This issue can be retested in staging.

[strepanier03]

Testing now.

[strepanier03]

This is no longer reproducible. When following the testing steps on staging it's working as expected.

[strepanier03]

I think we can close this out now since it's no longer needed. Please reopen if you disagree.