[HOLD for payment 2024-07-17] [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page #43585

lanitochka17 · 2024-06-12T15:44:47Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
On Inbox page, click Inbox icon
Refresh the page
Click Inbox

Expected Result:

The entire page will not blink

Actual Result:

The entire page blinks
This issue is not reproduced on Search and Account settings page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6510872_1718200620155.20240612_215345.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f33295394aa2f176
Upwork Job ID: 1801707280294774711
Last Price Increase: 2024-06-21
Automatic offers:

alitoshmatov | Reviewer | 102890680
truph01 | Contributor | 102890682

Issue Owner

Current Issue Owner: @puneetlath

melvin-bot · 2024-06-12T15:44:57Z

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot · 2024-06-14T20:04:26Z

Job added to Upwork: https://www.upwork.com/jobs/~01f33295394aa2f176

melvin-bot · 2024-06-14T20:04:31Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

truph01 · 2024-06-15T01:04:12Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The entire page blinks
This issue is not reproduced on Search and Account settings page

What is the root cause of that problem?

When click on "Inbox" button, we call:

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx

Lines 73 to 76 in 75c104b

    
           const navigateToChats = useCallback(() => { 
        
               const route = activeWorkspaceID ? (`/w/${activeWorkspaceID}/home` as Route) : ROUTES.HOME; 
        
               Navigation.navigate(route); 
        
           }, [activeWorkspaceID]);

In navigate function, this logic is called:

App/src/libs/Navigation/linkTo/index.ts

Lines 142 to 146 in 75c104b

    
           const actionForBottomTabNavigator = getActionForBottomTabNavigator(action, rootState, policyID, shouldNavigate); 
        
           if (!actionForBottomTabNavigator) { 
        
               return; 
        
           }

In expected, actionForBottomTabNavigator in above should be undefined, so the function will do nothing if user has already been in the /home page, but in this case, actionForBottomTabNavigator in not undefined.
So let's take a look at the getActionForBottomTabNavigator to find the RCA.

In getActionForBottomTabNavigator, we already have logic to do nothing if the current bottom tab is the same as the one we want to navigate to:

App/src/libs/Navigation/linkTo/getActionForBottomTabNavigator.ts

Lines 31 to 39 in 75c104b

    
           // Check if the current bottom tab is the same as the one we want to navigate to. If it is, we don't need to do anything. 
        
           const bottomTabCurrentTab = getTopmostBottomTabRoute(state); 
        
           const bottomTabParams = bottomTabCurrentTab?.params as Record<string, string | undefined>; 
        
           // Verify if the policyID is different than the one we are currently on. If it is, we need to navigate to the new policyID. 
        
           const isNewPolicy = bottomTabParams?.policyID !== payloadParams?.policyID; 
        
           if (bottomTabCurrentTab?.name === screen && !shouldNavigate && !isNewPolicy) { 
        
               return; 
        
           }

In this case, the expected is that isNewPolicy: false but actually, it is true because isNewPolicy = bottomTabParams?.policyID !== payloadParams?.policyID with bottomTabParams?.policyID: undefined and payloadParams?.policyID: '' (we can console.log in this line to see these values).

What changes do you think we should make in order to solve the problem?

Base on the above, we need to cover the case bottomTabParams?.policyID: undefined and payloadParams?.policyID: ''. We can update this:

App/src/libs/Navigation/linkTo/getActionForBottomTabNavigator.ts

Line 36 in 75c104b

const isNewPolicy = bottomTabParams?.policyID !== payloadParams?.policyID;

to:

    const isNewPolicy = (!!bottomTabParams?.policyID || !!payloadParams?.policyID) &&  bottomTabParams?.policyID !== payloadParams?.policyID;

What alternative solutions did you explore? (Optional)

We can also disable or early return this function:

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx

Line 73 in 75c104b

const navigateToChats = useCallback(() => {

if currentTabName === SCREENS.HOME. Do the same with other button tabs.

alitoshmatov · 2024-06-18T11:43:42Z

@truph01 Thank you for your proposal, your RCA is correct and your solution does solve the problem. But this issue is also happening for search page, when you go to search page, refresh and then click on search page expenses list is refreshing and blinking. Ideally we should solve that too

truph01 · 2024-06-18T12:00:08Z

@alitoshmatov

this issue is also happening for search page

It can be fixed with my alternative solution.

alitoshmatov · 2024-06-18T12:06:01Z

@truph01 I didn't understand what you mean by that, I mean it is not search page has separate navigate function which is not related to home pages navigation function

truph01 · 2024-06-18T12:12:14Z

@alitoshmatov

Currently, we have a logic to handle when user click on "Inbox"

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx

Line 82 in 75c104b

onPress={navigateToChats}

Also, the logic when user click on "Search":

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx

Lines 103 to 105 in 75c104b

    
           onPress={() => { 
        
               interceptAnonymousUser(() => Navigation.navigate(ROUTES.SEARCH.getRoute(CONST.TAB_SEARCH.ALL))); 
        
           }}

So, my alternative solution is that, we will early return these onPress functions if currentTabName === SCREENS.HOME in case of "Inbox" button and currentTabName === SCREENS.SEARCH.BOTTOM_TAB || currentTabName === SCREENS.SEARCH.CENTRAL_PANE in case of "Search" button.

alitoshmatov · 2024-06-19T10:08:47Z

@truph01 This solution does not work, navigation to home tab is completely not working, clicking on search tab is not going to the first menu item. This looks like a workaround for me

Screen.Recording.2024-06-19.at.3.08.07.PM.mov

truph01 · 2024-06-19T10:10:34Z

@alitoshmatov You mean my main solution or alternative solution?

alitoshmatov · 2024-06-19T10:28:21Z

Your main solution solves the issue only for home tab

My latest response was for solution you provided here

truph01 · 2024-06-19T10:29:02Z

I implement this solution and it still works on my side:

Screen.Recording.2024-06-19.at.17.25.36.mov

truph01 · 2024-06-19T10:40:38Z

@alitoshmatov Here is the detail code changes:

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx

Lines 73 to 76 in 75c104b

    
           const navigateToChats = useCallback(() => { 
        
               const route = activeWorkspaceID ? (`/w/${activeWorkspaceID}/home` as Route) : ROUTES.HOME; 
        
               Navigation.navigate(route); 
        
           }, [activeWorkspaceID]);

    const navigateToChats = useCallback(() => {
        if (currentTabName === SCREENS.HOME) {
            return;
        }
        const route = activeWorkspaceID ? (`/w/${activeWorkspaceID}/home` as Route) : ROUTES.HOME;
        Navigation.navigate(route);
    }, [activeWorkspaceID, currentTabName]);

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx

Lines 103 to 105 in 75c104b

    
           onPress={() => { 
        
               interceptAnonymousUser(() => Navigation.navigate(ROUTES.SEARCH.getRoute(CONST.TAB_SEARCH.ALL))); 
        
           }}

                    onPress={() => {
                        if (currentTabName === SCREENS.SEARCH.BOTTOM_TAB) {
                            return;
                        }
                        interceptAnonymousUser(() => Navigation.navigate(ROUTES.SEARCH.getRoute(CONST.TAB_SEARCH.ALL)));
                    }}

in the above if (currentTabName === SCREENS.SEARCH.BOTTOM_TAB) { condition, we can consider adding || currentTabName === SCREENS.SEARCH.CENTRAL_PANE as well

alitoshmatov · 2024-06-19T11:05:38Z

@truph01 search page is still blinking when pressed right after refreshing it. Adding currentTabName === SCREENS.SEARCH.CENTRAL_PANE additionally does prevent blinking but it also causes menu item not going back to the first one when search tab is pressed.

truph01 · 2024-06-19T11:11:37Z

Adding currentTabName === SCREENS.SEARCH.CENTRAL_PANE additionally does prevent blinking

I mean we use if (currentTabName === SCREENS.SEARCH.BOTTOM_TAB || currentTabName === SCREENS.SEARCH.CENTRAL_PANE) {. With this, the blink issue does not appear. Here is the result:

Screen.Recording.2024-06-19.at.18.12.01.mov

menu item not going back to the first one when search tab is pressed.

I think it is based on our expected. If we do not want to go back to the first one, we use if (currentTabName === SCREENS.SEARCH.BOTTOM_TAB || currentTabName === SCREENS.SEARCH.CENTRAL_PANE) {. If want, we use if (currentTabName === SCREENS.SEARCH.BOTTOM_TAB) {

truph01 · 2024-06-19T11:36:03Z

@puneetlath When users are already on search page, the "Search" icon in bottom tab is highlighted and the focused option in the left-hand screen is something like "Shared" "Draft", or "Finished". Then user clicks on the "Search" icon in the bottom tab. Should the focused option in left-hand screen reset to the first option, "Expenses"?

puneetlath · 2024-06-20T13:38:45Z

Hmm, good question. @luacmartins what do you think?

luacmartins · 2024-06-20T19:47:26Z

I don't think we should reset the view in that case, they are already in the Search page so we should just return early instead of navigating again.

melvin-bot · 2024-06-21T16:00:14Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot · 2024-06-26T19:06:50Z

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-06-26T19:06:54Z

📣 @truph01 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

truph01 · 2024-06-27T12:10:41Z

@alitoshmatov PR is ready

melvin-bot · 2024-07-10T10:48:39Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-07-10T10:48:43Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: The entire page blinks when clicking Inbox #44528

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

@alitoshmatov requires payment automatic offer (Reviewer)
@truph01 requires payment automatic offer (Contributor)

melvin-bot · 2024-07-10T10:48:44Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
[@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@alitoshmatov] Determine if we should create a regression test for this bug.
[@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2024-07-15T20:12:11Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: The entire page blinks when clicking Inbox #44528

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

@alitoshmatov requires payment automatic offer (Reviewer)
@truph01 requires payment automatic offer (Contributor)

melvin-bot · 2024-07-15T20:12:12Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
[@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@alitoshmatov] Determine if we should create a regression test for this bug.
[@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

puneetlath · 2024-07-16T20:10:16Z

@alitoshmatov friendly reminder about the checklist so we can pay tomorrow.

puneetlath · 2024-07-17T14:58:16Z

@truph01 has been paid. Still waiting on the checklist for @alitoshmatov.

alitoshmatov · 2024-07-17T16:01:05Z

The PR that introduced the bug has been identified. Link to the PR: Fix chat navigation #42684
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42684/files#r1681312172
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
Determine if we should create a regression test for this bug. I don't think regression test is needed since it is pretty noticeable bug

puneetlath · 2024-07-17T16:02:42Z

All paid. Thanks everyone!

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 12, 2024

melvin-bot bot assigned puneetlath Jun 12, 2024

melvin-bot bot added the Overdue label Jun 14, 2024

puneetlath added the External Added to denote the issue can be worked on by a contributor label Jun 14, 2024

melvin-bot bot changed the title ~~Inbox - The entire page blinks when clicking Inbox on Inbox page~~ [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page Jun 14, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 14, 2024

melvin-bot bot assigned alitoshmatov Jun 14, 2024

melvin-bot bot removed the Overdue label Jun 14, 2024

melvin-bot bot added the Overdue label Jun 21, 2024

puneetlath added this to [#whatsnext] #vip-vsb Jun 24, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 26, 2024

truph01 mentioned this issue Jun 27, 2024

Fix: The entire page blinks when clicking Inbox #44528

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jun 27, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2024

melvin-bot bot changed the title ~~[$250] Inbox - The entire page blinks when clicking Inbox on Inbox page~~ [HOLD for payment 2024-07-17] [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page Jul 10, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2024

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024

melvin-bot bot changed the title ~~[HOLD for payment 2024-07-17] [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page~~ [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page Jul 15, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 16, 2024

puneetlath changed the title ~~[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page~~ [HOLD for payment 2024-07-17] [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page Jul 16, 2024

alitoshmatov mentioned this issue Jul 17, 2024

Fix chat navigation #42684

Merged

49 tasks

puneetlath closed this as completed Jul 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-07-17] [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page #43585

[HOLD for payment 2024-07-17] [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page #43585

lanitochka17 commented Jun 12, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 12, 2024

melvin-bot bot commented Jun 14, 2024

melvin-bot bot commented Jun 14, 2024

truph01 commented Jun 15, 2024

alitoshmatov commented Jun 18, 2024

truph01 commented Jun 18, 2024

alitoshmatov commented Jun 18, 2024

truph01 commented Jun 18, 2024

alitoshmatov commented Jun 19, 2024

truph01 commented Jun 19, 2024

alitoshmatov commented Jun 19, 2024

truph01 commented Jun 19, 2024

truph01 commented Jun 19, 2024

alitoshmatov commented Jun 19, 2024

truph01 commented Jun 19, 2024 •

edited

Loading

truph01 commented Jun 19, 2024

puneetlath commented Jun 20, 2024

luacmartins commented Jun 20, 2024

melvin-bot bot commented Jun 21, 2024

melvin-bot bot commented Jun 26, 2024

melvin-bot bot commented Jun 26, 2024

truph01 commented Jun 27, 2024

melvin-bot bot commented Jul 10, 2024

melvin-bot bot commented Jul 10, 2024

melvin-bot bot commented Jul 10, 2024

melvin-bot bot commented Jul 15, 2024

melvin-bot bot commented Jul 15, 2024

puneetlath commented Jul 16, 2024

puneetlath commented Jul 17, 2024

alitoshmatov commented Jul 17, 2024

puneetlath commented Jul 17, 2024

[HOLD for payment 2024-07-17] [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page #43585

[HOLD for payment 2024-07-17] [$250] Inbox - The entire page blinks when clicking Inbox on Inbox page #43585

Comments

lanitochka17 commented Jun 12, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Jun 12, 2024

melvin-bot bot commented Jun 14, 2024

melvin-bot bot commented Jun 14, 2024

truph01 commented Jun 15, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

alitoshmatov commented Jun 18, 2024

truph01 commented Jun 18, 2024

alitoshmatov commented Jun 18, 2024

truph01 commented Jun 18, 2024

alitoshmatov commented Jun 19, 2024

truph01 commented Jun 19, 2024

alitoshmatov commented Jun 19, 2024

truph01 commented Jun 19, 2024

truph01 commented Jun 19, 2024

alitoshmatov commented Jun 19, 2024

truph01 commented Jun 19, 2024 • edited Loading

truph01 commented Jun 19, 2024

puneetlath commented Jun 20, 2024

luacmartins commented Jun 20, 2024

melvin-bot bot commented Jun 21, 2024

melvin-bot bot commented Jun 26, 2024

melvin-bot bot commented Jun 26, 2024

truph01 commented Jun 27, 2024

melvin-bot bot commented Jul 10, 2024

melvin-bot bot commented Jul 10, 2024

melvin-bot bot commented Jul 10, 2024

melvin-bot bot commented Jul 15, 2024

melvin-bot bot commented Jul 15, 2024

puneetlath commented Jul 16, 2024

puneetlath commented Jul 17, 2024

alitoshmatov commented Jul 17, 2024

puneetlath commented Jul 17, 2024

lanitochka17 commented Jun 12, 2024 •

edited by melvin-bot bot

Loading

truph01 commented Jun 19, 2024 •

edited

Loading