Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-02][Free trial] Implement and show Pre-Trial banner in the App during Pre-Trial #43670

Closed
MitchExpensify opened this issue Jun 13, 2024 · 14 comments
Assignees
Labels
Daily KSv2 NewFeature Something to build that is a new item.

Comments

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Jun 13, 2024

This covers this section of the doc:

cc @fabioh8010 @pac-guerreiro as you'll be picking this up

Issue OwnerCurrent Issue Owner: @mallenexpensify
@MitchExpensify MitchExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MitchExpensify MitchExpensify added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Current assignee @mallenexpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

@fabioh8010
Copy link
Contributor

Hi, I'm Fábio - expert agency contributor - and I would like to work on this issue.

@rojiphil
Copy link
Contributor

@MitchExpensify @mallenexpensify I can pick this up for review when PR is up

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jun 19, 2024
@luacmartins luacmartins self-assigned this Jun 19, 2024
@trjExpensify trjExpensify changed the title [Free trial] HOLD on #43668 - Implement and show Pre-Trial banner in the App during Pre-Trial [Free trial] Implement and show Pre-Trial banner in the App during Pre-Trial Jun 21, 2024
@luacmartins luacmartins changed the title [Free trial] Implement and show Pre-Trial banner in the App during Pre-Trial [HOLD for payment 2024-07-02][Free trial] Implement and show Pre-Trial banner in the App during Pre-Trial Jun 27, 2024
@luacmartins
Copy link
Contributor

PR was deployed to prod 2 days ago. Updated the title to include the payment due date.

@sakluger
Copy link
Contributor

@mallenexpensify I have a payment issue (GH) for the same PR. Should I handle payment there or will you be handling it here?

@mallenexpensify
Copy link
Contributor

I wonder if that was created because this one doesn't have External? ¯_(ツ)_/¯
I think you can close yours and I'll take care of here. Coincidentally, @rojiphil and I are talking about compensation for the free trial issues, we'll use this as an example.

@sakluger
Copy link
Contributor

sakluger commented Jul 1, 2024

Cool, thanks @mallenexpensify! I'll close mine.

Copy link

melvin-bot bot commented Jul 2, 2024

Payment Summary

Upwork Job

  • ROLE: @rojiphil paid $(AMOUNT) via Upwork (LINK)
  • Contributor: @fabioh8010 is from an agency-contributor and not due payment

BugZero Checklist (@mallenexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@mallenexpensify mallenexpensify removed the Reviewing Has a PR in review label Jul 3, 2024
@mallenexpensify
Copy link
Contributor

@rojiphil can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~018397fa4a91e2bc9b

@mallenexpensify mallenexpensify added Daily KSv2 and removed Weekly KSv2 labels Jul 3, 2024
@rojiphil
Copy link
Contributor

rojiphil commented Jul 3, 2024

can you please accept the job and reply here once you have?

@mallenexpensify Accepted. Thanks.

@melvin-bot melvin-bot bot added the Overdue label Jul 5, 2024
@mallenexpensify
Copy link
Contributor

Contributor+: @rojiphil paid $250 via Upwork.

I'm assuming that the test cases for this new feature will all be added as part of the project process.

@melvin-bot melvin-bot bot removed the Overdue label Jul 5, 2024
@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

8 participants