Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for Payment 2024-07-02] Payment issue for E/App PR#43982 #44110

Closed
melvin-bot bot opened this issue Jun 20, 2024 · 6 comments
Closed

[HOLD for Payment 2024-07-02] Payment issue for E/App PR#43982 #44110

melvin-bot bot opened this issue Jun 20, 2024 · 6 comments
Assignees
@rojiphil @sakluger
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2024

Issue created to compensate the Contributor+ member for their work on #43982
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @rojiphil.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Jun 20, 2024
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Jun 20, 2024
@melvin-bot melvin-bot bot mentioned this issue Jun 20, 2024
Merged
50 tasks
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jun 20, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 20, 2024
@sakluger
Copy link
Contributor

This is still not deployed. Switching back to weekly.

@sakluger sakluger added Weekly KSv2 and removed Daily KSv2 labels Jun 21, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 27, 2024
@sakluger sakluger changed the title Payment issue for E/App PR#43982 [HOLD for Payment 2024-07-02] Payment issue for E/App PR#43982 Jun 28, 2024
@sakluger sakluger mentioned this issue Jun 28, 2024
Closed
@sakluger
Copy link
Contributor

I checked on the original GH issue whether payment will happen here or there.

@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jul 1, 2024

@rojiphil, @sakluger Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@sakluger
Copy link
Contributor

sakluger commented Jul 1, 2024

Waiting to find out where we will handle payment.

@melvin-bot melvin-bot bot removed the Overdue label Jul 1, 2024
@sakluger
Copy link
Contributor

sakluger commented Jul 1, 2024

Closing as duplicate. Payment will happen in the original issue.

@sakluger sakluger closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rojiphil rojiphil

@sakluger sakluger

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rojiphil @sakluger