Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-17] [$750] [Free trial] Restrict actions throughout the App of "past due" billing owner #43674

Closed
MitchExpensify opened this issue Jun 13, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Jun 13, 2024

This covers this section of the design doc:

cc @fabioh8010 @pac-guerreiro as you'll be picking this up

Issue OwnerCurrent Issue Owner: @twisterdotcom
@MitchExpensify MitchExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 13, 2024
@MitchExpensify MitchExpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MitchExpensify MitchExpensify added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Current assignee @twisterdotcom is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 13, 2024
@fabioh8010
Copy link
Contributor

Hi, I'm Fábio - expert agency contributor - and I would like to work on this issue.

@twisterdotcom
Copy link
Contributor

@MitchExpensify right now we have @rojiphil and @hoangzinh - is one of them the Contributor, or are they both C+ and we can assign @fabioh8010?

@rojiphil
Copy link
Contributor

Me and @hoangzinh are both C+ assigned to this project. But one of us has to take this up.
Callstack is implementing this project as mentioned here. So we can assign @fabioh8010

@rojiphil
Copy link
Contributor

@fabioh8010 Don't we have to wait until #43672 is done to work on this? Or are we taking this up for implementation now?

@fabioh8010
Copy link
Contributor

Actually this one would be HOLD on #43668 and #43673, since the first one is merged and Restricted Action is close to be merged I will start my work on top of it, so I think this GH issue title was wrong.

@rojiphil
Copy link
Contributor

Actually this one would be HOLD on #43668 and #43673, since the first one is merged and #43855 I will start my work on top of it

Cool. That make sense.
@MitchExpensify I can take this up as C+ here.

@trjExpensify trjExpensify changed the title [Free trial] HOLD on #43668 & #43672 - Restrict actions throughout the App of "past due" billing owner [Free trial] HOLD on #43672 - Restrict actions throughout the App of "past due" billing owner Jun 21, 2024
@trjExpensify
Copy link
Contributor

Updating the title to reflect the hold on #43673

@trjExpensify trjExpensify changed the title [Free trial] HOLD on #43672 - Restrict actions throughout the App of "past due" billing owner [Free trial] HOLD on #43673 - Restrict actions throughout the App of "past due" billing owner Jun 21, 2024
@trjExpensify trjExpensify changed the title [Free trial] HOLD on #43673 - Restrict actions throughout the App of "past due" billing owner [Free trial] Restrict actions throughout the App of "past due" billing owner Jun 26, 2024
@trjExpensify
Copy link
Contributor

The PR for #43673 has been deployed, removed the hold.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Jun 26, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [Free trial] Restrict actions throughout the App of "past due" billing owner [HOLD for payment 2024-07-17] [Free trial] Restrict actions throughout the App of "past due" billing owner Jul 10, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

  • @rojiphil requires payment (Needs manual offer from BZ)
  • @fabioh8010 does not require payment (Contractor)

Copy link

melvin-bot bot commented Jul 10, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rojiphil] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] [Free trial] Restrict actions throughout the App of "past due" billing owner [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Free trial] Restrict actions throughout the App of "past due" billing owner Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rojiphil] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 16, 2024
@twisterdotcom twisterdotcom changed the title [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Free trial] Restrict actions throughout the App of "past due" billing owner [HOLD for payment 2024-07-17] [Free trial] Restrict actions throughout the App of "past due" billing owner Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Payment Summary

BugZero Checklist (@twisterdotcom)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@rojiphil
Copy link
Contributor

@twisterdotcom I think the work in this issue deserves an increase in compensation:

Reasonings:

  1. The PR took more time than the usual one or two rounds of testing as the scope involved too many tests (as described here)
  2. Though not directly related to this issue, we addressed a related navigation issue on navigating back/away from the restricted actions view as mentioned here
  3. Identified and supported an additional case here which was not identified yet in the design document

$750 is reasonable here. What do you think?

@twisterdotcom twisterdotcom changed the title [HOLD for payment 2024-07-17] [Free trial] Restrict actions throughout the App of "past due" billing owner [HOLD for payment 2024-07-17] [$750] [Free trial] Restrict actions throughout the App of "past due" billing owner Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@twisterdotcom
Copy link
Contributor

I'm happy with that, sure.

@twisterdotcom
Copy link
Contributor

Payment Summary:

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

6 participants