[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] [Report Fields] [External] Add Report fields to the More features page and add support for disabling the feature

[mountiny]

[Main tracking issue].(https://github.com/Expensify/Expensify/issues/365155)

Design doc link.

Implement the following section of the design doc: https://docs.google.com/document/d/10b7pTVvgpB6_O8sRTKaCzZEVM3Ba6hxnIwyyQSSXCLY/edit#bookmark=id.tx48k1sjd9mh

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01317dc8ca55728b5c
• Upwork Job ID: 1801290533705828644
• Last Price Increase: 2024-06-13
• Automatic offers:
• shubham1206agra | Reviewer | 102737559

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01317dc8ca55728b5c

[melvin-bot]

Current assignees @rushatgabhane and @shubham1206agra are eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[waterim]

Hello, Im Artem from Callstack and would like to help with this issue

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[rezkiy37]

I've opened the PR for review.

[rushatgabhane]

PR reviewed

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Integrate Report fields to the More features page #43896

If no regressions arise, payment will be issued on 2024-07-02. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @waterim does not require payment (Contractor)
• @rezkiy37 does not require payment (Contractor)
• @shubham1206agra requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @shubham1206agra] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[rushatgabhane]

@mountiny should i add regression steps? Or is it handled in some other process for new features?

[sonialiap]

@rushatgabhane not sure what's up with the automation but if you could add the regression steps, that would be super!

[mountiny]

@rushatgabhane I think we are going to handle adding the regression steps in later phase all in one go

[sonialiap]

EDIT - canceling payments until end of project #43678 (comment)

Payment summary
@rushatgabhane reviewer $250 - please request in ND
@shubham1206agra reviewer $250 - offer in Upwork, please accept

[shubham1206agra]

@sonialiap I am not sure if this will paid at last or an issue at a time.
cc @mountiny to confirm.

[rushatgabhane]

@shubham1206agra it's one issue at a time because it's just PR review

[rushatgabhane]

@shubham1206agra there was one only reviewer for this issue (me) :)

@sonialiap @shubham1206agra doesn't require payment for this issue

[shubham1206agra]

@rushatgabhane I think it's better we handle payments at the end of the project, tbh.
cc @mountiny

[shubham1206agra]

@shubham1206agra there was one only reviewer for this issue (me) :)

Umm. You have made the checklist. We both are reviewing all the PRs.

[rushatgabhane]

@shubham1206agra no we had talked about this when assigned. one review per person. where we both take turns (robin-robin)

[rushatgabhane]

anyway, please correct me if im wrong

[shubham1206agra]

@sonialiap I just confirmed with @mountiny. The payment will be done at last in one go. You can go ahead and close this issue.

[shubham1206agra]

@shubham1206agra no we had talked about this when assigned. one review per person. where we both take turns (robin-robin)

@rushatgabhane Actually that was for 2 issues only, as I was not available at that time.

[rushatgabhane]

ohhh im so sorry, i didn't know!

[JmillsExpensify]

$250 approved for @rushatgabhane

[shubham1206agra]

$250 approved for @rushatgabhane

@JmillsExpensify See #43678 (comment)

[rushatgabhane]

sorry for the confusion here

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Integrate Report fields to the More features page #43896

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @waterim does not require payment (Contractor)
• @rezkiy37 does not require payment (Contractor)
• @shubham1206agra requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @shubham1206agra] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[sonialiap]

Postponing payments until end of project #43678 (comment)
Payment summary edited #43678 (comment)

@mountiny fyi, Rushat has already been paid for this review