[HOLD for payment 2024-07-10] [PAID] [Fullstory] [$250] Update Fullstory version to work with React-Native-Web annotations

[danieldoglas]

Fullstory has released a new version with annotations for react-native-web. Let's update it.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014868e2119053451c
• Upwork Job ID: 1802690523185613082
• Last Price Increase: 2024-06-17
• Automatic offers:
• c3024 | Reviewer | 102800397

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @JmillsExpensify / @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[danieldoglas]

Placeholder issue so we can assign a C+ to be paid once they test it

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014868e2119053451c

[melvin-bot]

Current assignee @c3024 is eligible for the External assigner, not assigning anyone new.

[danieldoglas]

No help wanted since PR is ready

[strepanier03]

PR is deployed to staging.

Do I hold payment for 7 days still @danieldoglas?

[srikarparsi]

Hey! This PR caused this deploy blocker so we had to revert it here. I think we might need to redo the Fullstory version update if we need it.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Current assignee @danieldoglas is eligible for the DeployBlockerCash assigner, not assigning anyone new.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Revert "Fullstory plugin update. Annotation plugin fix."" #44006

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @c3024 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat / @c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat / @c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat / @c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat / @c3024] Determine if we should create a regression test for this bug.
• [@parasharrajat / @c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Simple upgrade.
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@parasharrajat] Determine if we should create a regression test for this bug. NA
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Adding check for staging for loading thirdPartyScripts #44079

If no regressions arise, payment will be issued on 2024-07-02. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @c3024 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat / @c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat / @c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat / @c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat / @c3024] Determine if we should create a regression test for this bug.
• [@parasharrajat / @c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

I worked on reverting the main PR. There have been a couple of back-and-forths on this issue. @c3024 Could you finish the checklist?

[c3024]

The PR that introduced the bug has been identified. Link to the PR:

This is not a bug fix PR. This PR enables third party scripts for staging as well.

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

NA

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

NA

Determine if we should create a regression test for this bug.

No

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

NA

[melvin-bot]

@danieldoglas, @strepanier03, @parasharrajat, @c3024 Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

Payment Summary

• $250 - @parasharrajat via Manual Request
• @c3024 Paid via Upwork automatic offer

@JmillsExpensify - Payment request incoming.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Adding check for staging for loading thirdPartyScripts #44079

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @c3024 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat / @c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat / @c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat / @c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat / @c3024] Determine if we should create a regression test for this bug.
• [@parasharrajat / @c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify / @strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

Payment requested as per #43827 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat