[HOLD for payment 2024-07-24] [$125] iOS - Distance - Top left corner of the distance receipt is sharp instead of rounded

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.84-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4638881
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to workspace chat
3. Submit a distance expense
4. Go to transaction thread
5. Tap on the distance receipt

Expected Result:

The receipt corner on all ends should be rounded

Actual Result:

The top left corner of the distance receipt is sharp and not rounded

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e67d7fccfba02aee
• Upwork Job ID: 1803175323249438423
• Last Price Increase: 2024-07-09
• Automatic offers:
• Krishna2323 | Contributor | 103076547

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Distance - Top left corner of the distance receipt is sharp instead of rounded

What is the root cause of that problem?

Seems like issue in react native. The documentation suggests using overflow: hidden incase of border radius not working.

What changes do you think we should make in order to solve the problem?

Add overflow: hidden to eReceiptPanel style object.

App/src/styles/index.ts

Lines 3970 to 3977 in a67e55d

	eReceiptPanel: {
	...spacing.p5,
	...spacing.pb8,
	...spacing.m5,
	backgroundColor: colors.green800,
	borderRadius: 20,
	width: 335,
	},

What alternative solutions did you explore? (Optional)

[Krishna2323]

Proposal Updated

• Added result screenshot and code reference.

[dylanexpensify]

reproing today!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e67d7fccfba02aee

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[dylanexpensify]

Made external

[melvin-bot]

Upwork job price has been updated to $125

[dylanexpensify]

updated price given the ease of this

[parasharrajat]

@Krishna2323's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dylanexpensify]

@roryabraham to review and confirm!

[parasharrajat]

Bump @roryabraham

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@parasharrajat, @roryabraham, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[parasharrajat]

This is a small issue, let's keep this moving. @dylanexpensify @roryabraham

[melvin-bot]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[parasharrajat]

@Beamanator This should be quick to review here is C+ review #43848 (comment)

[Beamanator]

Agreed, looks straightforward

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[parasharrajat]

@Krishna2323 Would you be able to create the PR today? Hoping to get this done today.

[Krishna2323]

@parasharrajat, sorry for delay🙏🏻, build was failing for natives on my PC from last two days. PR is now ready for review ^. For some reason receipt isn't loading on web/mWeb. Recordings for desktop and android/ios native is added.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: iOS - Distance - Top left corner of the distance receipt is sharp instead of rounded. #45383

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

Payment coming up!

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Looks like a native issue. Not caused by any PR.
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@parasharrajat] Determine if we should create a regression test for this bug. No
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Go to workspace chat
2. Submit a distance expense
3. Go to the transaction thread
4. Tap on the distance receipt
5. Verify the receipt has rounded corners on both sides

Do you agree 👍 or 👎 ?

[dylanexpensify]

Payment summary:

• Contributor: @Krishna2323 $125
• Contributor+: @parasharrajat $125

Please apply/request!

[dylanexpensify]

Done!

[parasharrajat]

Payment requested as per #43848 (comment)

[JmillsExpensify]

$125 approved for @parasharrajat