[HOLD for payment 2024-07-10] [$250] Search - Total amount for the report in Shared is -0.00 when it has only scanning expenses

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.85-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4609426
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Submit two scan expenses to the workspace chat.
4. While the scanning is ongoing, go to Search.
5. Go to Shared.

Expected Result:

The total amount for the report in Shared will be 0.00.

Actual Result:

The total amount for the report in Shared is -0.00.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

20240619_171945.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0122d04513e0a42253
• Upwork Job ID: 1803626666039149098
• Last Price Increase: 2024-06-20
• Automatic offers:
• c3024 | Reviewer | 102824702
• nkdengineer | Contributor | 102824703

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0122d04513e0a42253

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[mallenexpensify]

@c3024 likely add Help Wanted, any thoughts before I do?

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The total amount for the report in Shared is -0.00.

What is the root cause of that problem?

In

App/src/components/SelectionList/Search/ReportListItem.tsx

Line 42 in 29e4c54

text={CurrencyUtils.convertToDisplayString((reportItem?.type === CONST.REPORT.TYPE.EXPENSE ? -1 : 1) * (reportItem?.total ?? 0), reportItem?.currency)}

, we always multiply with -1 if it's an expense, even when the value is 0.

-1 * 0 will be -0, so it's displayed as -0 in front-end.

What changes do you think we should make in order to solve the problem?

Only multiply if total is not 0

let total = reportItem?.total ?? 0;

if (total) {
    total *= (reportItem?.type === CONST.REPORT.TYPE.EXPENSE ? -1 : 1);
}

After that total can be used in

App/src/components/SelectionList/Search/ReportListItem.tsx

Line 42 in 29e4c54

text={CurrencyUtils.convertToDisplayString((reportItem?.type === CONST.REPORT.TYPE.EXPENSE ? -1 : 1) * (reportItem?.total ?? 0), reportItem?.currency)}

text={CurrencyUtils.convertToDisplayString(total, reportItem?.currency)}

This can be made an utility to ensure consistency in this logic.

What alternative solutions did you explore? (Optional)

If value is -0, convert it to 0 inside convertToDisplayString or convertToFrontendAmountAsInteger

Example:

const amount = amountInCents === 0 ? 0 : amountInCents;

[nkdengineer]

Proposal updated to add alternative solution

[Kalydosos]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The total amount for the report in Shared is -0.00.

What is the root cause of that problem?

In

App/src/components/SelectionList/Search/ReportListItem.tsx

Line 42 in 29e4c54

text={CurrencyUtils.convertToDisplayString((reportItem?.type === CONST.REPORT.TYPE.EXPENSE ? -1 : 1) * (reportItem?.total ?? 0), reportItem?.currency)}

indeed as nkdengineer stated you always multiply with -1 if it's an expense, even when the value is 0.

-1 * 0 will be -0, so it's displayed as -0 in front-end.

What changes do you think we should make in order to solve the problem?

add 0 to the overall amount, the issue is hardcoded in javascript itself !!!

the line 42 will then be

text={CurrencyUtils.convertToDisplayString((reportItem?.type === CONST.REPORT.TYPE.EXPENSE ? -1 : 1) * (reportItem?.total ?? 0) + 0, reportItem?.currency)}

What alternative solutions did you explore? (Optional)

Even better avoid such mutiplication by writing line 42 as

text={(reportItem?.type === CONST.REPORT.TYPE.EXPENSE ? "-" : "") + CurrencyUtils.convertToDisplayString((reportItem?.total ?? 0), reportItem?.currency)}

[melvin-bot]

📣 @iloveyourglasses! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Kalydosos]

Contributor details
Your Expensify account email: rnel2@hotmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0182b95dfd9db2cbea

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[c3024]

@nkdengineer 's proposal here looks good to me. I found this use case at only one place so the primary solution looks fine to me.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@c3024 this PR is ready for review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Total amount for the report in Shared is -0.00 #44227

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment automatic offer (Reviewer)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

Contributor: @nkdengineer paid $250 via Upwork
Contributor+: @c3024 paid $250 via Upwork

@c3024 , please fill out the BZ checklist above. Thx

[c3024]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR: Fix report total and alignment #42932
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: nkdengineer@642baa4#r144114057
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No discussion was started because this is too specific a case and the bug could not have been identified earlier.
• [@c3024] Determine if we should create a regression test for this bug. Yes
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test proposal

1. Submit two scan expenses in a workspace chat.
2. While the scanning is ongoing, press on Search on Bottom Tab Bar.
3. Press on Shared.
4. Verify that the Total amount for this report (workspace chat of step 1) in Shared is displayed as 0.00.

[melvin-bot]

@arosiclair, @mallenexpensify, @c3024, @nkdengineer Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@arosiclair, @mallenexpensify, @c3024, @nkdengineer Still overdue 6 days?! Let's take care of this!

[arosiclair]

@mallenexpensify is this done?

[mallenexpensify]

is this done?

it is now!

• https://github.com/Expensify/Expensify/issues/414087