[HOLD for payment 2024-09-26] [Search v2.1] Update View payment history redirect to "Expensify, Inc" merchant filter.

[trjExpensify]

When we have merchant filtering, we want to update the redirect of the View payment history > menu item on the subscription page to navigate to Search with a filtered list of results for merchant: Expensify, Inc.

This issue is on hold until we complete that part of the Search v2 rollout, which is currently in detailed planning.

Issue Owner

Current Issue Owner: @luacmartins

[trjExpensify]

Still holding on Search v2 introducing search querying for this. @luacmartins, do you have a more specific issue I can point to for this hold?

Basically, we want to be able to filter the search page when they click this button to see all their billing receipts.

[luacmartins]

This would be the issue #45026

[trjExpensify]

Thanks! Title updated.

[trjExpensify]

@luacmartins seems like this issue might be able to come off hold now, what do you think?

[luacmartins]

Yes, draft PR here

[melvin-bot]

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[trjExpensify]

Niceeee!

[luacmartins]

Just a heads up, the PR is still in draft because we discovered an issue with the parser grammar that was splitting Expensify, Inc. into Expensify and Inc.. We need to make some changes to the grammar, but that has bigger implications, so I'm discussing it with SWM.

[trjExpensify]

Nice, thanks for the update. Just realised you're not assigned here either, so I'm adding yah to the issue.

[luacmartins]

Still on hold for #47789

[luacmartins]

@trjExpensify we're getting close to merging #47789, but I noticed that purchases don't have an associated entry in the transactions table so they won't show up in the Search page. That also seems to be the case in OldDot. Are we supposed to change this behavior?

[trjExpensify]

but I noticed that purchases don't have an associated entry in the transactions table so they won't show up in the Search page.

Hm, but when we bill someone we put the billing receipt in their Expensify account which creates an expense doesn't it?

[luacmartins]

Hmm maybe it was the way I created the expense locally then 🤔 I just ran a script to run billing for a user, maybe there are more steps to it

[trjExpensify]

Yeah maybe, I'm not sure.

[luacmartins]

PR in staging

[trjExpensify]

On prod, updated the title to reflect the payment date.

[rayane-djouah]

Checklist

• Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Regression Test Proposal

• Pre-requisites: an account with a workspace subscription and past billing activity

1. Navigate to Profile > Subscription
2. Press on View payment history
3. Verify that you're navigated to the Search page with the following search: type:expense status:all merchant:"Expensify, Inc."

Do we agree 👍 or 👎

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @rayane-djouah paid $250 via Upwork

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[trjExpensify]

Offer sent!

[rayane-djouah]

@trjExpensify Offer accepted, thank you!

[trjExpensify]

Done, paid. Closing!