[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Thread - App crashes after rejoining thread and opening thread header

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Send a message and also send a reply in thread
4. In thread, click 3-dot menu > Leave
5. Go to the thread again
6. Click Join
7. Immediately click on the chat header after rejoining the thread
8. Wait for the crash

Expected Result:

App will not crash

Actual Result:

App crashes after rejoining thread and opening thread header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6521356_1719047084692.crash_2.mp4

logs (2).txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@iwiznia FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes

What is the root cause of that problem?

This issue occurred because sortedAllReportActions is undefined, and we are checking the condition sortedAllReportActions.length. Since sortedAllReportActions is undefined, there are pending merge operations for the key during the first connection, as shown in the image below:

To fix this issue, we need to validate if sortedAllReportActions is undefined before checking its length. We should use a default value in destructuring to ensure sortedAllReportActions is always defined and avoid extra undefined checks. Get sortedAllReportActions at.

// src/pages/ReportDetailsPage.tsx#L83
- const [sortedAllReportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID ?? ''}`, {
+ const [sortedAllReportActions = []] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID ?? ''}`, {
        canEvict: false,
        selector: (allReportActions: OnyxEntry<OnyxTypes.ReportActions>) => ReportActionsUtils.getSortedReportActionsForDisplay(allReportActions, true),
    });

Note:
This PR handled the case where useOnyx returns undefined.

POC

Screen.Recording.2024-06-22.at.23.40.27.mov

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

[mountiny]

Asked @fabioh8010 to look into this as he has been working on the useOnyx changes

[iwiznia]

@fabioh8010 any update here?

Also, why didn't ts catch this earlier? Isn't this type of error exactly the ones TS should be catching before they are merged?

[mountiny]

Here is the thread btw

[fabioh8010]

@iwiznia @mountiny My investigations so far:

• I was able to reproduce on Staging, and on main only if I enable Staging server.
• Yes TS is catching and actually showing that sortedAllReportActions is ReportAction[] because we defined a selector and we are always returning an an array inside it. From TS perspective everything is correct.
• Yet sortedAllReportActions is still being undefined in this particular situation that shouldn't be possible, I'm still investigating why it's happening (now it will be easier because I was able to reproduce on main)

[fabioh8010]

Update: The problem is inside useOnyx.. looking for a fix.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mountiny]

PR merged and being CPed, assigned @situchan for future payment

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump Onyx to 2.0.53 #44279

If no regressions arise, payment will be issued on 2024-07-02. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

Payment summary:

@situchan due $250 for PR review to be paid via manual request

[situchan]

@bfitzexpensify I am still using upwork

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump Onyx to 2.0.53 #44279

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[situchan]

@bfitzexpensify I am still using upwork

kind bump ^

[bfitzexpensify]

Apologies @situchan!

Offer sent via Upwork.