Deploy Checklist: New Expensify 2024-06-21

[github-actions]

Release Version: 9.0.1-19
Compare Changes: production...staging

This release contains changes from the following pull requests:

• feature: Stop using reportAction.originalMessage or reportAction.messge #40168
• perf: Filter options in Request Money and Send Money #40235
• Feat/ Dupe detection review page #41093
• DOCS: Create Add-Expensify-Card-to-Apple-or-Google-Pay.md #42272
• [Snyk] Fix for 1 vulnerabilities #42352
• fix: re-calc the marker when msgs are deleted #42742
• [Details Revamp] Update ReportDetailsPage for Rooms, Groups, Money Reports and Policy Expenses #43251
• fix: Dismissing the error for corrupted PDF scan request does not delete the expense #43346
• Fix: "Receipt" label does not appear above receipt placeholder for p2p expense #43405
• integrate payment card section with API #43473
• Change modal border radius to 16px #43627
• Fix: Your location button button is displayed on distance request thumbnail #43630
• Remove export ReportUtil.getReport function #43632
• fix workspace empty state #43669
• Feat: Update font #43733
• [NoQA] Implementing NetSuite type in policy connection #43774
• [NoQA] e2e: uncomment typing test #43835
• Add dynamic columns #43869
• Moving Manually Subit article to the Hidden category so it's not public any longer #43882
• fix: Two unread markers when marking message unread in invoice thread #43883
• fix: Billable - Billable toggle should have a locked icon in split details view. #43889
• feat: script for downloading sourcemaps + symbolicating them #43894
• Integrate Report fields to the More features page #43896
• Add offline indicator #43936
• Fix loading skeleton displays behaviors when opening report #43970
• Fix: Vendor toggle style #43973
• Fix: Send button does not response #43976
• [Free trial] Implement and show Pre-Trial banner in the App during Pre-Trial #43982
• [fix]: [DEV] Console Warning when opening FAB menu #43984
• Use correct hover background for MenuItem New PR #43987
• fix: Change navigating condition #43992
• fix: do not show domain chats in focus mode #43993
• [Search v1] Report screen in RHP is removed from navigation history after navigating to the chat in CentralPane #44001
• [No QA] Remove unused policy code #44027
• Update Connect-a-Business-Bank-Account.md #44033
• Update en.ts #44039
• Maddylewis patch 1 #44044
• [No QA] Lock cocoapods version more tightly #44053
• Add handling of the NetSuite beta in NewDot #44064
• [NoQA] chore: bump onyx to version 2.0.52 #44065
• Adding check for staging for loading thirdPartyScripts #44079
• [FT] Update copy for Onboarding Welcome modal #44099
• [Composer] Add logs in Composer-related logic to track bug with disappearing text #44106
• Disable autocomplete when selecting block #44113
• Fix: Billable toggle is not auto-enabled #44134
• Fix displaying room mentions as IDs #44140
• Fix room mentions in editing comments #44160
• Update Connect-a-Business-Bank-Account.md #44171
• Manually CP PR #44123 to staging 🍒  #44172
• Update CONTRIBUTING.md #44173
• [CP Staging] Remove hover background for non interactive elements #44219
• [CP Staging] Check for system chat report for inability to rename it #44238
• [CP Staging] Scan - "Unhold" option appears in report details page of scanning expense #44243
• [CP Staging] Revert "fix: re-calc the marker when msgs are deleted" #44247
• [CP Staging] Hide join button in track expense report #44249
• [CP Staging] Revert "[Composer] Add logs in Composer-related logic to track bug with disappearing text" #44251
• [CP Staging] Don't show leave button for own policy expense chat #44252
• fix: prevent displaying email twice in search when it exists #44253
• Bump Onyx to 2.0.53 #44279
• [CP Staging] Not found page for review of missing transaction #44296
• fixes the "Room chat LHN preview displays "removed 0 user" after editing room description " #44300
• Revert "Fix loading skeleton displays behaviors when opening report" #44335
• [CP Staging] Remove checks for IOU #44357
• [CP Staging] fix: Search - Transaction RHP dismisses when holding/unholding expense from report details page. #44359
• [CP Staging] Fix existing expense is removed when dismissing receipt error #44364
• [CP Staging] Fix regression when html doesn't exist #44365
• [CP Staging] Fix back navigation after delete expense request in search transcation pane RHP #44372
• [CP Staging] Fix Android builds failing often on CI #44389

Deploy Blockers:

• [HOLD for payment 2024-07-10] [PAID] Android & iOS - Distance - Icon in the center button is off-centered #44074
• [HOLD for payment 2024-08-02] [$125] Web - Workspace - Screen blinks when opening member profile #44192
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Expensify personal - Expensify chat has the option to rename #44193
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Room - Room chat LHN preview displays "removed 0 user" after editing room description #44194
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Scan - "Unhold" option appears in report details page of scanning expense #44195
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Thread - App crashes after rejoining thread and opening thread header #44196
• [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Review duplicate - "Resolved duplicate" system message cannot be copied and thread grays out #44197
• [$250] [HOLD #43494][Search v1] Category field does not stay put when clicking on To title after enabling it #44198
• [HOLD for payment 2024-07-25] [$250] Expense - Tapping back button after deleting expense leads to not here page #44199
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Expense - Same results appear twice when search email on submit expense modal #44200
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Pay someone - App crashes after paying someone and opening chat header in transaction thread #44201
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Track expense - "Join" button appears in report details page when tracking expense in self DM #44202
• [$250] Expense - Page blinks when opening Hold RHP from report details page #44203
• [$250] Chat - New green line remains above last message when user switch chat #44204
• [$250] Task – Hidden assignee appears in LHN when assign task without assignee to yourself #44205
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Expense - Expense report shows a blank message instead of "detached a receipt from expense" #44207
• [$250] Search - Not here page opens when returning from Hold page when accessing from header #44208
• [HOLD for payment 2024-07-10] [$250] Android - Workspaces - "Workspaces" title is shown in two lines #44210
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Web - Book travel - There is hover effect on "Save money on ..." and "Get realtime updates.." #44211
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Search - RHP loads infinitely when deleting expense from report details page #44212
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Android - Review duplicate - App crashes when tapping "Keep all" on modified chat link #44213
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Expense - Expense preview in the main chat is blank when deleting expense offline #44214
• [HOLD for payment 2024-07-10] [$250] Split - 1:1 DMs are not instantly created when splitting expense (compared to prod) #44216
• [HOLD for payment 2024-08-19] [$250] Concierge - Error page when new account navigate to Concierge via Link #44235
• [$250] Android –Login –Your space chat appears with delay in LHN if login with new account via link #44236
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$125] Workspace - Workspace chat reappears in LHN after leaving the chat and relogin #44237
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Scan - Existing expense is removed when dismissing receipt error #44246
• [$125] Accounting - Empty space below Connections list #44261
• Android - Add payment card - Button "add payment card" doesn't present #44265
• Add payment card - Unable to add payment card to account #44267
• Chat - messages sent while the conversation is loading in offline are not shown #44280
• [Payment due 7-25] Review duplicate - "resolved the duplicate" system message disappears after restarting app #44294
• [HOLD for payment 2024-07-24] [$250] Expense - Inconsistency in dismissing report details RHP when deleting expense with comments #44336
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Search - Transaction RHP dismisses when holding/unholding expense from report details page #44337
• [HOLD for payment 2024-07-10] Expense - "started settling up.." thread header shows infinite skeleton #44338
• [HOLD for payment 2024-07-10] [BUG] Staging web fails to load, shows 'TypeError: Cannot use 'in' operator to search for 'whisperedTo' in []' error #44392

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.1-0 🚀

[carlosmiceli]

Demoted #44205

[mountiny]

demoted #44192

[mountiny]

demoted #44216

[mountiny]

demoted #44210

[mountiny]

demoted #44198

[mountiny]

demoted #44235

[Julesssss]

#44204 fixed by #44247

[Beamanator]

Checking off #44195 as it was fixed by #44243

[kavimuru]

Regression is 14% left

Unchecked PRs:
#43669 failing with #44254
#44001 failing with #43407

#40235 Desktop and iOS validation pending
#41093 - mweb and iOS validation pending
#42742 - iOS validation pending
#43251 - all the platforms validation pending
#43346 - iOS validation pending
#43473 - Desktop validation pending
#43869 iOS validation pending
#43970 validation pending in all the platforms
#43993 validation pending in all the platforms
#44113 validation pending in iOS

[srikarparsi]

Checking off #44200. Fixed and CPed to staging.

[francoisl]

Demoting #44214

[mountiny]

Checking #44252 off as it worked in staging

[yuwenmemon]

Checked off #43669 based on https://expensify.slack.com/archives/C01GTK53T8Q/p1719252885905929

[rlinoz]

Demoting #44294

[yuwenmemon]

Reverting #43970 so checking it off and the associated blocker

[mountiny]

demoted #44261

[kavimuru]

Regression is less than 1% pending
unchecked PRs:
#40235 failing with #44200
#43346 failing in Desktop with #43645
#43473 failing with #44267
#43669 failing with #44254
#44001 failing with #43407

[yuwenmemon]

Checking off #44194

[mountiny]

demoted #44336

[mountiny]

demoted #44208

[mountiny]

demoted #44199

[kavimuru]

Regression is completed in the TR.
unchecked PRs:
#43346 failing in Desktop with #43645
#43473 failing with #44267
#44001 failing with #43407
Working on the last 3 Cps now
Open blocker:
#44212

[luacmartins]

Checked off #44212. Fixed in staging

[yuwenmemon]