[HOLD for payment 2024-08-19] [$250] Concierge - Error page when new account navigate to Concierge via Link

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4661673&group_by=cases:section_id&group_order=asc&group_id=229066
Email or phone of affected tester (no customers): gocemate+a388@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Log out of NewDot
2. Navigate to https://staging.new.expensify.com/concierge
3. Sign-up with a new account
4. Finish the onboarding flow

Expected Result:

User should navigate to the concierge chat

Actual Result:

Error page appear when new user navigates to concierge link after finishing the onboarding flow

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6521970_1719132299755.Recording__3310.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017c459a6423831994
• Upwork Job ID: 1805205450283630802
• Last Price Increase: 2024-07-22
• Automatic offers:
• ahmedGaber93 | Reviewer | 103318767
• NJ-2020 | Contributor | 103318769

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@isabelastisser I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

Production

bandicam.2024-06-23.20-16-40-063.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017c459a6423831994

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[mountiny]

demoting since this is an edge case and the user is not blocked from using the app, looking for proposals to fix this though

[pankajsoftyoi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The user should stay in concierge chat after finishing the onboarding steps.

What is the root cause of that problem?

• Redirection issue is due to a check on the account ID. A/B testing code was used in the condition to redirect to the error page.

What changes do you think we should make in order to solve the problem?

App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

Lines 74 to 78 in fd4987f

	if (AccountUtils.isAccountIDOddNumber(accountID ?? 0)) {
	Report.navigateToSystemChat();
	} else {
	Report.navigateToConciergeChat();
	}

We need to remove A/B testing code and redirect it to the concierge chat always.
if we remove above condition and just replace it with Report.navigateToConciergeChat(); then it will resolve redirection issue.

What alternative solutions did you explore? (Optional)

N/A

Screen.Recording.2024-06-25.at.6.00.54.PM.1.mp4

[melvin-bot]

📣 @pankajsoftyoi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[pankajsoftyoi]

Contributor details
Your Expensify account email: pankaj.bhalala@softyoi.com
Upwork Profile Link: https://www.upwork.com/freelancers/~012986a83dc460e833

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

Current assignee @madmax330 is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @ahmedGaber93 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @NJ-2020 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[NJ-2020]

@ahmedGaber93 PR is ready for review

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[ahmedGaber93]

We have a different issue, and on dev only. PR now in review.

[isabelastisser]

@ahmedGaber93

We have a different issue, and on dev only. PR now in review.

Does this mean that this issue can be closed?

[ahmedGaber93]

@isabelastisser No, keep it open. we are still working on it to match the expected behavior

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix concierge page infinite loading #46483

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @ahmedGaber93 requires payment automatic offer (Reviewer)
• @NJ-2020 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
• [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ahmedGaber93] Determine if we should create a regression test for this bug.
• [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[isabelastisser]

Payment summary:

$250 to @ahmedGaber93 for C+ review. Paid in Upwork.
@250 to @NJ-2020 for proposal. Paid in Upwork.

[isabelastisser]

@ahmedGaber93, I DM'd you for visibility to complete the BZ list. Thanks!

[ahmedGaber93]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR: Enable React concurrent mode #42592
• [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Enable React concurrent mode #42592 (comment)
• [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@ahmedGaber93] Determine if we should create a regression test for this bug. N
• [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

this a DEV only issue, so I think no need to create a regression test.

[isabelastisser]

Thanks, @ahmedGaber93! All set!