Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - Workspace template still shows as old model instead of updated template #44254

Closed
1 of 6 tasks
lanitochka17 opened this issue Jun 24, 2024 · 4 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 24, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): emilio.utest+99@gmail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #43669

Action Performed:

PreCondition: User has no Workspaces created prior

  1. Access staging.new.expensify.com
  2. Sign into a valid account
  3. Go to Profile > Workspace > Observe the template

Expected Result:

User expects to see the new Workspace template with the "E" icon

Actual Result:

User still sees the old WS template that shows the "Padlock" and "Alien Spaceship"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6522326_1719167760361.WS_update_not_reflected.mp4

according_to_the_PR_

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 24, 2024
Copy link

melvin-bot bot commented Jun 24, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@devguest07
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong animation on empty workspaces

What is the root cause of that problem?

Wrong animation file

https://github.com/Expensify/App/blob/main/src/components/LottieAnimations/index.tsx#L38

What changes do you think we should make in order to solve the problem?

Replace the animation file with the correct one from the design team.

What alternative solutions did you explore?

@shawnborton
Copy link
Contributor

This isn't a bug, we can close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants