[HOLD for payment 2024-08-02] [$125] Web - Workspace - Screen blinks when opening member profile

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings > Workspaces
3. Go to any workspace
4. Go to Members
5. Click on any member

Expected Result:

The screen will not blink when opening member profile

Actual Result:

The screen blinks when opening member profile

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6521352_1719047081090.blink_blink.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013a107b5b6f0f348e
• Upwork Job ID: 1805160170118380262
• Last Price Increase: 2024-06-24

Issue Owner

Current Issue Owner: @jayeshmangwani

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@mountiny FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013a107b5b6f0f348e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[mountiny]

this is minor, I dont think it has to be a blocker

[melvin-bot]

Upwork job price has been updated to $125

[jnowakow]

Hello, I'm from SoftwareMansion, an expert agency, and I can work on this.
It seems that the problem is cause by Member.clearWorkspaceOwnerChangeFlow(policyID); being called right before opening modal. Probably this causes page to re-render

[jnowakow]

I commented it out and it help on one workspace but when I navigate to other report I still can observe the problem. I'm looking for other cause

[mountiny]

Thanks Jan, can you please write the proposal once you find the root cause?

[jnowakow]

@mountiny it seems that the root cause is that the WorkspaceMembersPage is being unmounted and re-rendered when RHP is opened. First render of SelectionList seems to be heavy operation because when you navigate there for the first time there's also slight lag before list is rendered (it's better visible when watching frame by frame 😅 ):

first-navigation.mov

I'm still looking for possible solution so I'm not able to write detailed proposal. I'll try to figure out why in this case whole page is re-rendered and how to prevent it.

[mountiny]

Thanks!

[jnowakow]

Okey, with huge help of @adamgrzybowski I manage to find out the root cause. The screens are unmounted and re-rendered because query params are added when RHP is opened. On the members screens the accountID is pushed to query params:

It's because getMatchingRootRouteForRHPRoute "thinks" that if RHP is aware of accountID then screens in the FullScreenNavigator also should know about it.

The best solution is to have strictly defined what screens accepts what params and don't pass anything more. It can be achieved either by parsing routes and pull params names from them or by defining constants with mapping between screen and params

[jayeshmangwani]

Not Overdue, PR is in Draft

[adamgrzybowski]

Hi! I reviewed the PR and it look good 🟢

[melvin-bot]

This issue has not been updated in over 15 days. @jayeshmangwani, @mountiny, @jnowakow eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jayeshmangwani]

• [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: I'm not exactly able to find the lines of code that caused this issue, but I think the issue is coming from the Ideal nav PR.
• [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@jayeshmangwani] Determine if we should create a regression test for this bug. Yes
• [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open App in Web/Desktop
2. Go to Account settings -> Workspaces
3. Go to any workspace -> Members
4. Click on any member
5. Verify that members list doesn't blink

Do we agree 👍 or 👎

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @jayeshmangwani owed $125 via NewDot
• Contributor: @jnowakow is from an agency-contributor and not due payment

BugZero Checklist (@JmillsExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1805160170118380262/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[JmillsExpensify]

Payment summary of $125 is correct. @jayeshmangwani can you submit an expense via NewDot?

[jayeshmangwani]

Requested as per #44192 (comment)

[mallenexpensify]

Contributor+: @jayeshmangwani due $125 via NewDot

test case GH

• https://github.com/Expensify/Expensify/issues/418331

[JmillsExpensify]

$125 approved for @jayeshmangwani