[$250] Chat - New green line remains above last message when user switch chat

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

issue found when validating #42742
Version Number: 9.0.1-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. User A have open chat with User B
2. User C send a message to User A
3. User A opens the chat with User C
4. Verify there is a New green line above the received message
5. User A navigates to chat with User B
6. User A navigates back to the chat with User C

Expected Result:

New green line should not be present since user have read the message and switch the chat

Actual Result:

New green line remains above last message when user switch chat
New green line disappears only when refresh page

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6521408_1719051510405.Recording__3288.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @garrettmknight

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c2a88ee67b261c60
• Upwork Job ID: 1811345021260741348
• Last Price Increase: 2024-07-11
• Automatic offers:
• ishpaul777 | Contributor | 103076271

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[m-natarajan]

@Julesssss FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[ishpaul777]

Maybe this one is the offending PR #42742

[Julesssss]

I was OOO at this time on Friday.

We have a brand new checklist with 20 blockers so I won't yet revert, but I'll need to see some progress on the fix in the meantime. This PR was the likely cause.

[Julesssss]

The new message line remains until the user comments or signs out.

I'm going to revert the PR now as this is serious enough to block deploy, and seems like the assigned contributors won't be online until tomorrow.

[ishpaul777]

Maybe Github automation closed with PR merge @Julesssss Can we please reopen ?

[garrettmknight]

Moving this to daily to handle it tomo - @Julesssss who's getting paid here? This issue is kind of a mess.

[Julesssss]

My bad, this shouldn't have had the ready for payment title...

I resolved this issue by reverting the original PR. So this issue should be closed, and further changes should be discussed here.

[ishpaul777]

Hey @Julesssss, i was c+ on the revert PR, can we please reopen for payment

[Julesssss]

Oh I see, sorry. One sec.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c2a88ee67b261c60

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Julesssss]

So @garrettmknight, we just need a single C+ review payment for @ishpaul777. The 7 day hold has already passed. Thanks!

[garrettmknight]

@ishpaul777 offer is out to you. Let me know when you've accepted and I'll pay.

[garrettmknight]

Still waiting on offer acceptance

[ishpaul777]

I have accepted offer, Thanks!

[garrettmknight]

All paid up, closing.