[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$125] Workspace - Workspace chat reappears in LHN after leaving the chat and relogin

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User is invited to a workspace.

1. Go to staging.new.expensify.com
2. Go to workspace chat as workspace member.
3. Click on the chat header.
4. Click Leave.
5. Go to Troubleshoot > Clear cache and restart > Reset and refresh (or relogin).

Expected Result:

Users cannot leave workspace chat. That is the chat where they are in the employee role

Actual Result:

The workspace chat reappears in LHN after leaving the chat and relogin.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6522629_1719216943415.20240624_161246.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c734d656ba4811ea
• Upwork Job ID: 1805206172124171293
• Last Price Increase: 2024-06-24
• Automatic offers:
• ishpaul777 | Reviewer | 102854287
• bernhardoj | Contributor | 102854288

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@JmillsExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[mountiny]

@izarutskaya in this case, is it the user leaving their own workspace chat? I dont think that should be possible

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c734d656ba4811ea

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[melvin-bot]

Upwork job price has been updated to $125

[mountiny]

Marking as external. The expected behaviour is that the Leave button should not be available when its your workspace chat

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User can leave from their own workspace chat.

What is the root cause of that problem?

In #43251, we add the leave button for the workspace chat too if it's not the workspace admin.

App/src/pages/ReportDetailsPage.tsx

Line 220 in d7db203

const shouldShowLeaveButton = !isThread && (isGroupChat || (isChatRoom && ReportUtils.canLeaveChat(report, policy)) || (isPolicyExpenseChat && !isPolicyAdmin));

I believe this is because we are now able to invite users to the workspace chat, so it makes sense for the invited user to be able to leave, but not for the workspace chat owner.

What changes do you think we should

Prevent the leave button from showing if it's an own workspace chat.

const shouldShowLeaveButton = !isThread && (... || (isPolicyExpenseChat && !report.isOwnPolicyExpenseChat && !isPolicyAdmin));

[lanitochka17]

Hello. Issue still happens another way. Fail or new issue?
The steps are the same except that the user is now invited to workspace chat instead of workspace

-423736081570707755520240625_002948.1.MP4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Don't show leave button for own policy expense chat #44252

If no regressions arise, payment will be issued on 2024-07-02. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @ishpaul777 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ishpaul777]

I was able to reproduce #44237 (comment), it looks like when a member leave workspace chat API throws error

cc @mountiny

[mountiny]

@ishpaul777 you should not get the leave button in the report details, so then you should not be able to leave the chat. How come its still visible for the workspace chat you own?

[ishpaul777]

Its not a workspace chat user own but a chat user is invited to.

[mountiny]

Oh I see, i think that would be a new issue. @izarutskaya Can you please log this with the specific steps, ie its user that is invited and they are not able to leave the chat afterwards

I think we are calling wrong api command, it should call LeaveRoom or something like that

[lanitochka17]

@mountiny I will leave a link when it is ready

[lanitochka17]

@mountiny A new issue is ready #44492

[mountiny]

Cool thanks, I think that is ready for payment then

$125 to @bernhardoj and to @ishpaul777

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Don't show leave button for own policy expense chat #44252

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @ishpaul777 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[JmillsExpensify]

Issuing payments based on Vit's payment summary above. Do we need a regression test for this though?

[JmillsExpensify]

Also @bernhardoj will you be requesting via NewDot?

[bernhardoj]

@JmillsExpensify yes, requested in ND.

[JmillsExpensify]

$125 approved for @bernhardoj

[JmillsExpensify]

Closing this one out! Contributors have been approved for payment via ND and Upwork.