Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Room - Unable to leave invited workspace chat specifically from report details page #44492

Closed
6 tasks done
lanitochka17 opened this issue Jun 26, 2024 · 51 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A

Action Performed:

Precondition:

  • User is invited to the workspace chat (not workspace)
  1. Go to staging.new.expensify.com
  2. Go to the invited workspace chat
  3. Click chat header > Leave
  4. Leave the room
  5. Go to Troubleshoot > Clear cache and restart > Reset and refresh (or relogin)
  6. Note that the workspace chat shows up again
  7. Go to the invited workspace chat
  8. This time, click 3-dot menu > Leave
  9. Leave the room
  10. Go to Troubleshoot > Clear cache and restart > Reset and refresh (or relogin)

Expected Result:

User should be able to leave workspace chat via both report details page (Step 4) and 3-dot menu (Step 9)

Actual Result:

User is unable to leave workspace chat from report details page (Step 4) as the workspace chat reappears after leaving and restarting app (or relogin)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6525463_1719420955092.20240627_004916.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0104feb060b6fcc52e
  • Upwork Job ID: 1812674634063741063
  • Last Price Increase: 2024-07-15
  • Automatic offers:
    • suneox | Reviewer | 103146753
Issue OwnerCurrent Issue Owner: @RachCHopkins
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 26, 2024
Copy link

melvin-bot bot commented Jun 26, 2024

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@RachCHopkins
Copy link
Contributor

I can't replicate this. @lanitochka17 can you tell me, in between inviting the user to the chat, and them attempting to leave, did they comment or take any action in the chat? (I just want to make sure that I'm replicating it right)

Here's what I did on MacOS Chrome:

  1. Create brand new user account (let's call it User C)
  2. Log in as User A.
  3. Go to workspace chat, workspace users are User A and User B.
  4. Mention User C in chat to invite them and send a message
  5. Log out from User A
  6. Log in as User C
  7. Go to workspace chat and view message
  8. Leave
  9. Page refreshes to "page not found" and workspace chat instantly vanishes from Chat list.

@RachCHopkins RachCHopkins added the Needs Reproduction Reproducible steps needed label Jun 27, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
@RachCHopkins
Copy link
Contributor

@lanitochka17 can you offer some more insight here please?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 1, 2024
@RachCHopkins
Copy link
Contributor

Oops, still learning the process. Posted in QA channel.

@melvin-bot melvin-bot bot removed the Overdue label Jul 4, 2024
@kavimuru
Copy link

kavimuru commented Jul 5, 2024

@RachCHopkins Tester is still able to reproduce the bug.

Precondition:

  • User A creates a workspace.
  • User A invites User B to the workspace chat from report details page.
  • The following steps will be done by User B.
  1. Go to staging.new.expensify.com
  2. Go to the invited workspace chat
  3. Click chat header > Leave
  4. Leave the room
  5. Go to Troubleshoot > Clear cache and restart > Reset and refresh (or relogin)
  6. Note that the workspace chat shows up again
  7. Go to the invited workspace chat
  8. This time, click 3-dot menu > Leave
  9. Leave the room
  10. Go to Troubleshoot > Clear cache and restart > Reset and refresh (or relogin)
20240705_190847.mp4

@melvin-bot melvin-bot bot added the Overdue label Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

@RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@RachCHopkins
Copy link
Contributor

I'm looking for someone other than the original reporter of this to replicate it. I cannot.

@melvin-bot melvin-bot bot removed the Overdue label Jul 9, 2024
@kavimuru
Copy link

kavimuru commented Jul 9, 2024

@RachCHopkins Now the step 8 is blocked. There is no 3-dot in the header now. #44025

Screenrecorder-2024-07-09-16-19-14-449.mp4
bandicam.2024-07-09.16-49-38-378.mp4

@RachCHopkins
Copy link
Contributor

@kavimuru does this mean another person was able to replicate the issue?

Copy link

melvin-bot bot commented Jul 10, 2024

@RachCHopkins this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@kavimuru
Copy link

@RachCHopkins As per this PR #44025 , no more 3dot menu. But tester reproduced leaving the room as in step 4 and able to reproduce the issue.

leave.ws.mp4

@melvin-bot melvin-bot bot added the Overdue label Jul 12, 2024
@RachCHopkins RachCHopkins removed the Needs Reproduction Reproducible steps needed label Jul 15, 2024
@RachCHopkins RachCHopkins added the External Added to denote the issue can be worked on by a contributor label Jul 15, 2024
@melvin-bot melvin-bot bot changed the title Room - Unable to leave invited workspace chat specifically from report details page [$250] Room - Unable to leave invited workspace chat specifically from report details page Jul 15, 2024
@tienifr
Copy link
Contributor

tienifr commented Jul 25, 2024

This issue was fixed somewhere else. I'm investigating if we could find any related bug having the same root cause.

@suneox
Copy link
Contributor

suneox commented Jul 30, 2024

@tienifr The issue still reproduces on the latest staging with an assigned task.

RPReplay_Final1722310160.MP4

@tienifr
Copy link
Contributor

tienifr commented Jul 30, 2024

@suneox I wonder why Leave option appears in a task report. Could you please share detailed reproduction steps?

@suneox
Copy link
Contributor

suneox commented Jul 31, 2024

@suneox I wonder why Leave option appears in a task report. Could you please share detailed reproduction steps?

@tienifr Step to reproduce:

  1. User A create a new WS
  2. User A start room chat
  3. User A invite user B to WS room chat
  4. User A assign task for user B
  5. User B leave WS room chat has invited from User A

@suneox
Copy link
Contributor

suneox commented Aug 5, 2024

@pecanoro @tienifr I just double-checked on version v9.0.16-4 and this issue can’t be reproduced.

Copy link

melvin-bot bot commented Aug 8, 2024

@pecanoro, @suneox, @RachCHopkins, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Aug 8, 2024
@tienifr
Copy link
Contributor

tienifr commented Aug 9, 2024

@pecanoro @RachCHopkins This issue was fixed by another PR that was merged right after my assignment here. Please proceed payment. Thanks.

Copy link

melvin-bot bot commented Aug 12, 2024

@pecanoro, @suneox, @RachCHopkins, @tienifr 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@tienifr
Copy link
Contributor

tienifr commented Aug 14, 2024

@RachCHopkins Could you kindly check #44492 (comment)?

@suneox
Copy link
Contributor

suneox commented Aug 14, 2024

Hi @pecanoro We need the QC team to double-check if the issue is reproducible. If it isn’t, the payment should be made at 50% according to the latest policy update, since we didn’t work on the PR

Copy link

melvin-bot bot commented Aug 14, 2024

@pecanoro, @suneox, @RachCHopkins, @tienifr Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Aug 16, 2024

@pecanoro, @suneox, @RachCHopkins, @tienifr 10 days overdue. Is anyone even seeing these? Hello?

@pecanoro
Copy link
Contributor

@RachCHopkins Can you double check if this reproducible or it got fixed as mentioned here?

@RachCHopkins
Copy link
Contributor

Sorry @pecanoro I've been slammed - I could not reproduce it in the first place. Do we have anyone else who could replicate it who can retest?

@melvin-bot melvin-bot bot removed the Overdue label Aug 20, 2024
@RachCHopkins
Copy link
Contributor

Maybe @kavimuru could retest this for us?

@pecanoro
Copy link
Contributor

@RachCHopkins That also works! Could you post in the #qa channel in Slack so they know they need to retest it?

@kavimuru
Copy link

Not able to reproduce.

bandicam.2024-08-21.22-19-37-955.mp4

@RachCHopkins
Copy link
Contributor

I think we can call this fixed - @pecanoro I'm new to this, what is the next step in this case?

@pecanoro
Copy link
Contributor

@RachCHopkins We need to pay @suneox and @tienifr half of the bounty since they were assigned before it was fixed somewhere else.

@melvin-bot melvin-bot bot added the Overdue label Aug 26, 2024
@pecanoro
Copy link
Contributor

@RachCHopkins Friendly reminder so we can finally close the issue!

@RachCHopkins
Copy link
Contributor

RachCHopkins commented Aug 26, 2024

Payment Summary:

Contributor: @tienifr to be paid $125 via NewDot manual request
Contributor+: @suneox to be paid $125 via Upwork
Upwork job here

@melvin-bot melvin-bot bot removed the Overdue label Aug 26, 2024
@RachCHopkins
Copy link
Contributor

@suneox I was able to do a partial payment rather than a new contract, but I did get an error. Can you please confirm for me that you were actually paid for this?

image

@suneox
Copy link
Contributor

suneox commented Aug 27, 2024

@suneox I was able to do a partial payment rather than a new contract, but I did get an error. Can you please confirm for me that you were actually paid for this?

@RachCHopkins I've received the payment

@RachCHopkins
Copy link
Contributor

My bad, looks like we pay @tienifr via NewDot Manual Request. You're good to submit that! I'll update my comment above.

@RachCHopkins
Copy link
Contributor

Contributor+ has been paid, the contract has been completed, and the Upwork post has been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
No open projects
Status: No status
Development

No branches or pull requests

7 participants