Feat: Update font

[truph01]

Details

Fixed Issues

$ #43512
PROPOSAL: #43512 (comment)

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-21.at.11.42.16.mov

Android: mWeb Chrome

Screen.Recording.2024-06-21.at.11.39.49.mov

iOS: Native

Screen.Recording.2024-06-21.at.11.47.44.mov

iOS: mWeb Safari

Screen.Recording.2024-06-21.at.11.35.32.mov

MacOS: Chrome / Safari

• Large screen:

output.mp4

• Small screen:

Screen.Recording.2024-06-14.at.05.52.05.mov

MacOS: Desktop

Screen.Recording.2024-06-21.at.11.46.56.mov

[melvin-bot]

@shawnborton @c3024 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[shawnborton]

On desktop, the To & From should not be in bold.

[shawnborton]

Can you check the spacing here:

We just want everything there to have an 8px gap

[truph01]

@shawnborton

• Reply your comment:
  Yes. The gap between avatar and name is 8px:
  

• Reply your comment:
  I updated PR. Here is the result:
  

[shawnborton]

Yes. The gap between avatar and name is 8px:

Ah sorry, that comment was from the mobile view of the Search page.

[shawnborton]

Can you make it so that these To/From columns on desktop vertically center everything? Right now it looks like it's aligned to the top and it feels a bit off:

[shawnborton]

We may need to make the date column slightly wider as a result of this. We currently have a date PR in review that also adds the ability to see the year in dates for expenses from prior years, so perhaps as soon as that is merged, we can adjust the column widths there.

[shawnborton]

This isn't your fault but it's something I think we should fix: the small text in mobile view under the merchant has some weird alignment going on, I think in part because we are giving it a min-height of 20px:

Can we make it so that we just use the standard line-height of the text, which should be 14px since it's micro-sized font:

And then we just vertically center everything? Basically removing the min-height in my first screenshot of this comment should fix that.

[luacmartins]

@truph01 please let me know once you're addressed Shawn's comments

[truph01]

@luacmartins Sure. I am working on it. It is related to style fix, so I need to test on all platforms.

[luacmartins]

Sounds good, thanks for the update!

[truph01]

@shawnborton

Can you make it so that these To/From columns on desktop vertically center everything? Right now it looks like it's aligned to the top and it feels a bit off:

• Currently, I do not have any solution for it. The parent's height is 21, and the child's height is 16, so the alignItem: 'center' or 'alignSelf: 'center' do not work.

We may need to make the date column slightly wider as a result of this. We currently have a date PR in review that also adds the ability to see the year in dates for expenses from prior years, so perhaps as soon as that is merged, we can adjust the column widths there.

• We already have a logic to handle it. If we display the year, the date column is grow up. This is that change: https://github.com/Expensify/App/pull/43413/files#diff-097e3d461183958f84757dc8be87e3f24b862654235a9b3f59f75ae74a738e1

The small text in mobile view under the merchant has some weird alignment going on

• I fixed it by removing the min line height attribute:

[shawnborton]

If we put them back to bold, we get something like this:

Which I think I like better, as it has some harmony with the button or badge on the right side which uses bold weight as well.

[shawnborton]

Another small thing I am noticing: it looks like the expense cards are only 100px tall:

Whereas in Figma, we have them at 108:

I think that's because this top header wrapper here only has a margin-bottom of 8px:

Whereas it should actually have a margin bottom of 16px:

Can you make that change as well please? Thanks!

[truph01]

Whereas it should actually have a margin bottom of 16px:

• @shawnborton I fixed it. This is result:

Also wanted to bump @Expensify/design to check this out - I'm wondering if the lack of bold letters for the To/From actually looks way worse on mobile?

• What is the final decision on this?

[shawnborton]

I think we should do bold names, so let's implement that quickly and then test again. Thanks!

[truph01]

I think we should do bold names, so let's implement that quickly and then test again. Thanks!

• Here is the result, the font-weight is 700:

[shawnborton]

Looks great, but going to build one last time too. Thanks for all of the changes!

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/43733/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/43733/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/43733/NewExpensify.dmg	https://43733.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[shawnborton]

Looking good to me! Let's get this into final review.

[c3024]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

updateFontAndroid-compressed.mp4

Android: mWeb Chrome

updateFontAndroidmWeb-compressed.mp4

iOS: Native

updateFontiOS-compressed.mp4

iOS: mWeb Safari

updateFontiOSmWeb-compressed.mp4

MacOS: Chrome / Safari

updateFontChrome1.mp4

updateFontChrome2.mp4

MacOS: Desktop

updateFontDesktop.mp4

[luacmartins]

LGTM

[luacmartins]

@c3024 @shawnborton all yours

[c3024]

LGTM too!

[dannymcclain]

Sorry meant to weigh in on this before, but I'm into the bold for names on mobile!

[luacmartins]

Chatted 1:1 with @shawnborton and we're good to merge!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[shawnborton]

Sorry for the late feedback, but @truph01 I found a case where the date column isn't wide enough and causes truncation:

Can you follow up with a quick fix for that?

[truph01]

@shawnborton Sure. I wonder which value should we use?

App/src/styles/utils/index.ts

Line 1562 in 2026f62

columnWidth = getWidthStyle(shouldExtendDateColumn ? variables.w84 : variables.w52);

[shawnborton]

I think just bumping to 88 might do the trick, but let's check a variety of dates to make sure. Thanks @truph01 !

[luacmartins]

It seems like we need at least 92px. The date May 30, 2030 or May 30, 2000 gets truncated otherwise.

[luacmartins]

PR here

[OSBotify]

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.1-19 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅