[HOLD for payment 2024-08-14] [Search v1] Use different fallback receipt icon when displaying a Search row that has no receipt and isn't editable

[shawnborton]

For all rows on the Search page, we use a receipt thumbnail empty state with a reciept icon that has a "+" in it, insinuating that you can add a receipt. However, in cases where the expense is no longer editable and the expense does not have a receipt, we should use an icon that is less confusing to the user and indicates that no receipt is present:

The correct we need to use is here: receipt-slash.svg.zip

cc @Expensify/design @luacmartins

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015da17aa3988f430a
• Upwork Job ID: 1805308817829198566
• Last Price Increase: 2024-06-24
• Automatic offers:
• s77rt | Reviewer | 102861602
• neonbhai | Contributor | 102861603

Issue Owner

Current Issue Owner: @mallenexpensify

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Use different fallback receipt icon when displaying a Search row that has no receipt and isn't editable

What is the root cause of that problem?

This is a Feature Request.

What changes do you think we should make in order to solve the problem?

We will add the svg to the codebase and export it from our Expensicons.ts file.

When assigning a Fallback icon (shown when no receipt is present) here:

App/src/components/SelectionList/Search/TransactionListItemRow.tsx

Line 88 in 64dec34

fallbackIcon={Expensicons.ReceiptPlus}

We will use a check for ReportUtils.isSettled(transactionItem.reportID) to display the new slashed receipt svg.

Additionally

We will add any other check that would detemine if the receipt should be shown

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015da17aa3988f430a

[melvin-bot]

Triggered auto assignment to @mallenexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@neonbhai Your proposal makes sense to me. Let's get this done!

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[s77rt]

@neonbhai

We will add any other check that would detemine if the receipt should be shown

We can follow the logic from canEditMoneyRequest which considers a money request editable if it's not approved and not settled i.e. it's:

• OPEN
• SUBMITTED
• CLOSED

The CLOSED being editable may be a mistake cc @luacmartins for confirmation (are reports with STATUS_NUM=CLOSED editable?)

[luacmartins]

It seems like some values can be edited on a closed expense report, e.g. merchant, description, category. Other fields can't be edited on closed expense reports, e.g. date, amount, receipt

[s77rt]

@luacmartins Thanks for checking that! Can you please assign @neonbhai if the proposal looks good to you

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[neonbhai]

Raising PR soon!

[melvin-bot]

@s77rt, @luacmartins, @mallenexpensify, @neonbhai Huh... This is 4 days overdue. Who can take care of this?

[s77rt]

PR is in draft status

[melvin-bot]

This issue has not been updated in over 15 days. @s77rt, @luacmartins, @mallenexpensify, @neonbhai eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[neonbhai]

PR has been merged and deployed to staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Use different fallback receipt icon when displaying a Search row that has no receipt and isn't editable #44742

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment automatic offer (Reviewer)
• @neonbhai requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[s77rt]

Regression Test Proposal

1. Go to Search
2. In the receipt column, verify that:
   • If the report has a receipt, the receipt preview is shown
   • If the report has no receipt and is open/submitted then the "Receipt Plus" icon is shown
   • If the report has no receipt and is settled then the "Receipt Slash" icon is shown

[mallenexpensify]

TestRail GH https://github.com/Expensify/Expensify/issues/419895, thanks @s77rt

[mallenexpensify]

Contributor: @neonbhai paid $250 via Upwork
Contributor+: @s77rt owed $250 via NewDot (automation above stating payment via Upwork in incorrect)

Thx!

[JmillsExpensify]

$250 approved for @s77rt