[HOLD for payment 2024-07-10] Repeated "[ExpensiMark] Missing account name" errors

[srikarparsi]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1719084949691449

Action Performed:

Break down in numbered steps

1. Add a keystroke under some accounts

Expected Result:

Describe what you think should've happened

Shouldn't see repeated error logs

Actual Result:

Describe what actually happened

See repeated [ExpensiMark] Missing account name errors in the console

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[srikarparsi]

I believe this is related to this PR. @blazejkustra if you have time to take a look at this that would be much appreciated :)

[blazejkustra]

Hey, I'm looking into it now!

[blazejkustra]

PR is up with a quick explanation @srikarparsi @mountiny

This is a fix that is good enough to merge ASAP, but similar regressions will happen again in the future if we don't think holistically about this problem. I'm going to follow up with a proposal how to fix this issue going forward

[blazejkustra]

Proposal (Long Run)

Please re-state the problem that we are trying to solve in this issue.

ExpensiMark methods (parseHtmlToText, parseHtmlToMarkdown) should always be used with onyx context. Otherwise ExpensiMark is going to spam server with a lot of "[ExpensiMark] Missing account name" errors.

What is the root cause of that problem?

We introduced OnyxAwareParser a while ago, but we can't expect everybody to know it's mandatory to use it. Instead contributors often import ExpensiMark, initialize it and use it's methods, which causes problems.

What changes do you think we should make in order to solve the problem?

• Create a Parser lib, where ExpensiMark will be imported, Onyx context added and exported to the E/App for use
• Forbid importing ExpensiMark globally (can be easily done with ESLint)

With this, such regressions won't happen in the future and we'll have only one instance of ExpensiMark

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix regression when html doesn't exist #44365

If no regressions arise, payment will be issued on 2024-07-02. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@srikarparsi] The PR that introduced the bug has been identified. Link to the PR:
• [@srikarparsi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@srikarparsi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@srikarparsi] Determine if we should create a regression test for this bug.
• [@srikarparsi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[srikarparsi]

Moving this back to a daily to implement this change. Also removing the HOLD for payment since this PRs payment is being taken care of in another issue. Is that right @mountiny @blazejkustra

[mountiny]

@srikarparsi I think @blazejkustra will create a new issue for that so we can keep it separate

[srikarparsi]

Cool sounds good, I will close this issue then.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix regression when html doesn't exist #44365

If no regressions arise, payment will be issued on 2024-07-10. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@srikarparsi] The PR that introduced the bug has been identified. Link to the PR:
• [@srikarparsi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@srikarparsi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@srikarparsi] Determine if we should create a regression test for this bug.
• [@srikarparsi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: