Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[held #45203] [$250] Search - System message thread opens when opening from Search when system message has reply #44590

Closed
6 tasks done
lanitochka17 opened this issue Jun 28, 2024 · 46 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0-3.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #43742

Action Performed:

  1. Go to staging.new.expensify.com/
  2. Go to FAB > Pay someone
  3. Enter amount, select a user and pay them
  4. Go to transaction thrad
  5. Right click on the paid system message > Reply in thread
  6. Send a reply in thread
  7. Go to Search
  8. Open the expense sent previously

Expected Result:

Transaction thread will open

Actual Result:

System message thread opens when opening from Search when there is reply in system message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6526871_1719533132122.20240628_080147.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019c1a520581844a96
  • Upwork Job ID: 1810271704827245079
  • Last Price Increase: 2024-09-02
Issue OwnerCurrent Issue Owner: @
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 28, 2024
Copy link

melvin-bot bot commented Jun 28, 2024

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Jun 28, 2024
@mountiny
Copy link
Contributor

This is not a blocker, but it's kind of an expected result of the one-transaction view design. In essence, an IOU action thread is a transaction thread, so replying to the report action in the thread is leaving a comment on the transaction thread.

I think this is not a bug @lanitochka17

@NikkiWines @trjExpensify to confirm, I am not sure what else we could do about this, but it's an edge case for Send Payment flow

@trjExpensify
Copy link
Contributor

Thread for discussion breadcrumbs: https://expensify.slack.com/archives/C01GTK53T8Q/p1719535523859119

@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
Copy link

melvin-bot bot commented Jul 1, 2024

@hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jul 3, 2024

@hayata-suenaga Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Jul 5, 2024

@hayata-suenaga Still overdue 6 days?! Let's take care of this!

@hayata-suenaga hayata-suenaga added the External Added to denote the issue can be worked on by a contributor label Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~019c1a520581844a96

@melvin-bot melvin-bot bot changed the title Search - System message thread opens when opening from Search when system message has reply [$250] Search - System message thread opens when opening from Search when system message has reply Jul 8, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@melvin-bot melvin-bot bot removed the Overdue label Jul 8, 2024
@hayata-suenaga
Copy link
Contributor

forgot to add the external label 😓

Copy link

melvin-bot bot commented Jul 11, 2024

@getusha, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jul 11, 2024
@joekaufmanexpensify
Copy link
Contributor

Got it, sounds good! We will go ahead with re-adding the system message when paying a single action send money transaction in #45203

Copy link

melvin-bot bot commented Jul 25, 2024

@getusha, @hayata-suenaga 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@getusha
Copy link
Contributor

getusha commented Jul 25, 2024

Not overdue, i think this should be held for #45203 @joekaufmanexpensify

@melvin-bot melvin-bot bot removed the Overdue label Jul 25, 2024
@joekaufmanexpensify
Copy link
Contributor

Sounds good! Will do that.

@joekaufmanexpensify joekaufmanexpensify changed the title [$250] Search - System message thread opens when opening from Search when system message has reply [held #45203] [$250] Search - System message thread opens when opening from Search when system message has reply Jul 25, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

@getusha, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Jul 31, 2024

@getusha, @hayata-suenaga Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot removed the Overdue label Aug 2, 2024
@puneetlath puneetlath added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Aug 2, 2024

This comment was marked as duplicate.

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 2, 2024
Copy link

melvin-bot bot commented Aug 2, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@joekaufmanexpensify
Copy link
Contributor

Still held on this issue

@joekaufmanexpensify joekaufmanexpensify added Monthly KSv2 and removed Daily KSv2 labels Aug 2, 2024
Copy link

melvin-bot bot commented Aug 5, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

1 similar comment
Copy link

melvin-bot bot commented Aug 12, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@joekaufmanexpensify
Copy link
Contributor

@getusha #45203 is closed now. Should we take this off hold now?

Copy link

melvin-bot bot commented Aug 19, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Copy link

melvin-bot bot commented Aug 26, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

1 similar comment
Copy link

melvin-bot bot commented Sep 2, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@joekaufmanexpensify
Copy link
Contributor

Closing this as it's no longer reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants