-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[held #45203] [$250] Search - System message thread opens when opening from Search when system message has reply #44590
Comments
Triggered auto assignment to @hayata-suenaga ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #wave-collect - Release 1 |
This is not a blocker, but it's kind of an expected result of the one-transaction view design. In essence, an IOU action thread is a transaction thread, so replying to the report action in the thread is leaving a comment on the transaction thread. I think this is not a bug @lanitochka17 @NikkiWines @trjExpensify to confirm, I am not sure what else we could do about this, but it's an edge case for Send Payment flow |
Thread for discussion breadcrumbs: https://expensify.slack.com/archives/C01GTK53T8Q/p1719535523859119 |
@hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@hayata-suenaga Eep! 4 days overdue now. Issues have feelings too... |
@hayata-suenaga Still overdue 6 days?! Let's take care of this! |
Job added to Upwork: https://www.upwork.com/jobs/~019c1a520581844a96 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha ( |
forgot to add the external label 😓 |
@getusha, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Got it, sounds good! We will go ahead with re-adding the system message when paying a single action send money transaction in #45203 |
@getusha, @hayata-suenaga 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
Not overdue, i think this should be held for #45203 @joekaufmanexpensify |
Sounds good! Will do that. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@getusha, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@getusha, @hayata-suenaga Huh... This is 4 days overdue. Who can take care of this? |
This comment was marked as duplicate.
This comment was marked as duplicate.
Triggered auto assignment to @joekaufmanexpensify ( |
Still held on this issue |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
1 similar comment
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Issue not reproducible during KI retests. (First week) |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
1 similar comment
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Closing this as it's no longer reproducible. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0-3.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #43742
Action Performed:
Expected Result:
Transaction thread will open
Actual Result:
System message thread opens when opening from Search when there is reply in system message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6526871_1719533132122.20240628_080147.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @The text was updated successfully, but these errors were encountered: