[HOLD for payment 2024-07-17] Track expense - "Hold" option should not appear for tracked expense in combined report

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0-3.2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com/
2. Go to workspace chat that has no unsettled expense
3. Go to + > Track expense
4. Track a manual expense
5. Go to transaction thread (combined report)
6. Click 3-dot menu
7. Note that Hold option is available for tracked expense in the combined report
8. Submit another expense
9. Go to transaction thread of the tracked expense in Step 4
10. Click 3-dot menu
11. Note that Hold option is actually not available for tracked expense (this is the correct behavior)

Expected Result:

In Step 7, in one-report combined view, "Hold" option should not show up for the tracked expense

Actual Result:

In Step 7, in one-report combined view, "Hold" option shows up for the tracked expense in 3-dot menu

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6527316_1719574473097.20240628_192942.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@NikkiWines FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[NikkiWines]

This is almost certainly from #43618. I don't think this should be a blocker even if the behavior isn't what we intend though, it's fairly low impact and doesn't come across as "buggy".

@trjExpensify just to confirm, do you think we should show the HOLD option for Track expenses? If not, let's open a new issue to rectify this rather than reverting the whole PR.

[trjExpensify]

@NikkiWines I don't think you should be able to hold expenses in your selfDM. They should be immediately added to a closed report and there's nothing to do or prevent. 👍

[NikkiWines]

Cool, I can spin up an issue or PR to handle this, but removing the blocker label for now 👍

[JmillsExpensify]

Wait, are we adding track expenses to reports now? They should be unreported by design, right?

[JmillsExpensify]

Or is this referring to the case of tracked expenses on a workspace.

[trjExpensify]

Ah yeah, sorry, this is referring to the admin Track expense option in the workspace chat, not the selfDM. They're added to closed reports, so there's nothing to do, so Hold shouldn't be there:

(Ignore all the archived stuff obviously)

[JmillsExpensify]

Thanks for the clarification! You should not be able to hold a reimbursed or closed report, so this makes sense to me.

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mallenexpensify]

@lschurr , needed a BZ here to pay once PR hits production, it's on staging now (I think)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Disallow holding expenses on closed reports #44656

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

This is due payment tomorrow - https://expensify.slack.com/archives/C01SKUP7QR0/p1721171565737339

[lschurr]

Payment summary:

• Reviewer: @akinwale $250 (To be paid in Upwork)

[akinwale]

@lschurr I am not eligible for NewDot payments until late October, so I still need to be paid through Upwork for this one.

[lschurr]

Ah, ok the automation is incorrect in this case. I'll create an Upwork job.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @akinwale paid $250 via Upwork

BugZero Checklist (@lschurr)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[lschurr]

Offer sent in Upwork @akinwale - https://www.upwork.com/nx/wm/offer/103161072

[lschurr]

All set!