Deploy Checklist: New Expensify 2024-07-03

[github-actions]

Release Version: 9.0.4-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

• perf: Intive to workspace options filtering #40793
• DOCS: Create Enable-Expensify-Card-notifications.md #42270
• Cleanup: Simplify navigateToMostRecentReport function #42365
• Shows a different message when approving/paying all hold expenses #42736
• Fix wrong amount is displayed when updating waypoint in offline #42833
• Add Pay as Business option for invoices sent to an individual who is admin of their primary workspace #43036
• fix Fallback avatar background and selection highlight have the same color #43077
• [ESM] Localize system messages #43079
• fix selected option is not highlighted #43093
• Fix last synced message #43448
• fix RBR transaction thread is disappearing from the LHN when navigating to another chat v2 #43502
• Feature/43097 - "Export onyx state" button in the troubleshoot section #43552
• Image zoom for mobile browser apps #43620
• Connect to sage intacct #43661
• Fix: All categories disappear instead of crossed out when deleted offline #43735
• [NoQA] e2e: support for different units #43890
• Marking GRB on task at highest #43927
• Fix: Hide whisper action when deleting track expense in offline #43977
• Fix RHP slide animation when opening sign in modal #43985
• fix change the status bar color #44048
• [Payment card / Subscription] Integrate failed billing scenarios banner with backend data #44072
• [Travel] Create Trip Receipt for newDot #44086
• Update QBO connection copy  #44124
• [Payment history] add "Request refund" menu item #44138
• [#Wave-Control: Add NetSuite]: Settings Configuration in NewDot: Export #44159
• Remove clearReportNotFoundErrors #44184
• Fix Required Receipt Translations #44220
• feat: integrate retry billing with backend #44268
• Implement the policy report fields creation flow #44275
• fixes scroll issue in composer #44354
• update default card onyx data accessing #44361
• feature: Add deeplinks to workspace editor in the onboarding checklist tasks #44367
• [Free trial] Implement and show Free Trial banner and badges in the App after Free Trial starts #44371
• fix: use goBack when navigating to More Feature page #44374
• Fixes: Able to save empty display first name #44375
• [No QA] Card flow screens #44376
• Fix "To" field displays Hidden instead of invoice receiver #44378
• [Search v1] Add bulk actions #44385
• fix: Android - Downloaded pop-up appears if download Word, missing Attachment successfully download. #44390
• [Free trial] Restrict actions throughout the App of "past due" billing owner #44393
• Update en.ts #44418
• Bump react-native-screens #44427
• fix keyboard overlap composer #44428
• [No QA] [Workspace Feeds] Create new Card List page #44469
• Show optimistic distance receipt for tracked expenses #44489
• Remove old logic as we don't reposition the report preview anymore #44501
• Sort reports by created date #44503
• Fix code step shows briefly when open 2FA page even though it's enabled #44516
• fix: VBA Link does not sign user in when redirected #44517
• LHN item stay as read after mark as unread #44519
• fix: Prevent requesting money from domain emails #44525
• [NoQA] fix: missing profiler binaries in e2e on AWS #44527
• Fix: The entire page blinks when clicking Inbox #44528
• [NO QA] feat: subscription localize currency #44538
• fix: Category - No hover effect when hovering over selected parent category in the list. #44539
• fix: Unable to proceed to the next tab from Invite new members with Enter key. #44542
• fix: extra padding below money report header #44545
• [NO QA]: Workspace Feed - Expensify Card #44549
• [No QA] Fix deploy comments if a deploy is cancelled in progress #44581
• [No QA] Fail patch-package on errors or warnings #44589
• fix: strips the spaces away before sending it to the api call #44592
• Add debug util for UI tests #44593
• fix: workspace chat owner can be removed #44595
• fix: check empty report in getIOUReportActionMessage #44598
• fix: "Scanning" appears in Description field #44605
• Fix navigating back from Settings screens and refreshing SearchPage with policyIDs in the url #44622
• Add optional chaining for shouldShowColumns data #44627
• Fix/44462 show idology questions #44628
• Add files via upload #44629
• [NoQA] chore: remove profiler patches #44630
• [NoQA] Revert "Update en.ts" #44646
• Hide Sage Intacct behind NetSuite beta for now #44648
• Rename Expenses category and redirect #44652
• Fix green dot disappears with a delay in LHN when task is completed #44655
• Disallow holding expenses on closed reports #44656
• [#Wave-Control: Add NetSuite]: Settings Configuration in NewDot: Import List #44663
• [#Wave-Control: Add NetSuite]: Fix Connection name on Workspace pages. #44664
• Fixes: Troubleshoot modal opened from shortcut is missing Testing preferences #44666
• fix: No option to add receipt when submitting to someone #44670
• Fix: The emoji icons on reactions are not vertically centered #44675
• Add prettier-plugin-sort-imports plugin to prettier config #44682
• [NoQA] Change electron build target to default #44687
• [No QA] Fix all report errorFields getting cleared and INTEGRATIONSMESSAGE copy #44690
• Update copy based on accounting integration #44691
• [No QA] Hide Sage Intacct integration behind Sage Intacct Beta #44703
• Revert "[No QA] Fail patch-package on errors or warnings" #44704
• fix: 44506 IOS - Transfer owner - App returns to empty screen when sw… #44712
• Fix blue outline shows in Reply box when context menu is open and pressing arrow up key #44715
• Fix pending join workspace name is not displayed #44716
• Fix missing delete expense in self dm track expense details page #44717
• Don't allow invoice room to be mentionable #44731
• Disable taxes if we need to disconnect a previous integration first #44736
• Disable navigating to profile page if the user is optimistic #44737
• Update Global-Reimbursements.md #44769
• [CP Staging] fix: wrap error screen in the screenwrapper #44809
• [CP Staging] fix: empty list does not turn to empty state screen #44814
• [CP Staging] fix: filter out the receiver policy #44836
• [CP Staging] fix the check for subscription green dot info #44862
• [CP Staging] fix: Categories - The subtitle under 'Members must categorize all expenses' contains 'undefined'. #44866
• [CP Staging] Fix select all checkbox is not checked when all items are checked #44882
• [CP Staging] Revert "Add Pay as Business option for invoices sent to an individual who is admin of their primary workspace" #44891

Deploy Blockers:

• [HOLD for payment 2024-07-17] [$250] Web : Profile section is empty when a workspace is created on the new account #44601
• [HOLD for payment 2024-07-17] Workspace switcher - Report from another workspace persists after switching workspace #44619
• [HOLD for payment 2024-08-29] [$125] Start chat - Add to group button has same color as background #44796
• [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Report fields - "title" report field shows up and app crashes when clicking on checkbox. #44797
• [HOLD for payment 2024-07-17] [$250] Report fields - Row is not grayed out when added/edited offline #44798
• Report fields - Select all checkbox cannot be clicked #44799
• Room - LHN is empty after leaving public room anonymously #44800
• [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Search - The Select all checbox is not checked when all the expenses are checked #44801
• [Search v1] - "Delete" option appears for paid expenses for submitter #44802
• [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Search - Empty list does not turn to empty state screen until page is revisited #44803
• [PAID] [$250] Profile - Account settings icon shows green dot with no other indication #44804
• [HOLD for payment 2024-07-17] Wallet - Error page overlaps with device status bar #44805
• Send invoice - Workspace avatar and name are incorrect after paying invoice as a business #44806
• [HOLD for payment 2024-07-17] [$125] Invoice-User B's workspace appears in User A's workspace list after paying invoice as business #44811
• [AWAITING PAYMENT] [$250] iOS- Public room- RHP not opens smoothly after selecting any option from room details #44812
• Sage Intacct - Back button on workspace editor returns to Accounting page again #44813
• [HOLD 2024-09-25] [$125] Report fields - Not here page appears briefly after deleting the list value #44815
• Task – Green dot disappears when assign task to me and reopen task details. #44816
• [HOLD for payment 2024-07-24] [ESM] Expense - System message for receipt removal is different in expense report and LHN preview #44817
• [HOLD for payment 2024-07-22] [$250] Invoice - App crashes after receiver deletes all workspaces and sender is unable to send invoice #44818
• [HOLD for payment 2024-07-17] Categories - The subtitle under "Members must categorize all expenses" contains "undefined" #44826
• [Hold PR #44907] [$250] Report field - Different system message for report field edit in expense report and LHN #44831
• [Hold on #41619] Onboarding - Onboarding tasks assigned to current user disappears after a few sec #44834
• [HOLD for payment 2024-07-25] Troubleshoot-"Mask fragile user data while exporting Onyx state" toggle is auto-enabled #44841
• [WAITING ON DOMINICTB][HOLD for payment 2024-08-01] [$250] Report field - List field shows "dropdown" as selected when different initial value is default #44843
• [HOLD for payment 2024-07-22] [$250] Android - Report Fields - Cursor position jumps to the beginning of the name field #44868
• [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Category - Disabled parent category is not grayed out in the list #44869
• [HOLD for payment 2024-07-22] Expensify Card - Blue outline does not wrap the user row properly when navigating via Tab #44871
• [HOLD for payment 2024-07-22] [$50] Report fields - Initial value in the system message is defined as "undefined" #44885
• [HOLD for payment 2024-07-24] [$250] [Payment card / Subscription] When clicking "Change payment", past data still shows on new form #44886
• [$250] Android - NetSuite - Option is not being selected without scrolling first on a long list #44927

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.4-0 🚀

[Beamanator]

Checked off #44806 b/c it's "expected" and considered not a blocker

[lakchote]

Checked off #44813 (comment) as it's an edge case and it doesn't affect core functionality.

Plus, it's behind beta.

[grgia]

Demoted #44817

[blimpich]

Demoted #44841

[carlosmiceli]

Couldn't reproduce #44818.

[luacmartins]

I'm unchecking #44818, since QA can still reproduce the issue and it's crashing the App.

[tgolen]

Demoting #44871

[luacmartins]

Checking off #44601. Reproducible in prod.

[luacmartins]

Checking off #44619. Issue was fixed 2 days ago, we reopened it to pay the contributor.

[luacmartins]

Checking off #44798. Report fields in on a beta and it's a small UI issue, no need to block the deploy on this.

[luacmartins]

Checking off #44843. Report fields in on a beta and it's a small UI issue, no need to block the deploy on this.

[kavimuru]

Regression is 3% left.
unchecked PRs:
#42736 - validation pending in Desktop and iOS
#43036 - validation pending in Desktop
#43502 validation pending in Desktop iOS
#43927 - validation pending in Desktop iOS
#44086 validation pending in all platforms
#44138 - validation pending in Desktop
#44184 pending in Desktop
#44220 - validation pending in Desktop iOS
#44268 - validation pending in All
#44354 - Validation pending in Android
#44385 failing with #43415, #44801, #44802,#44803
#44393 - validation pending in All
#44519 - validation pending in Desktop
#44539 - validation pending in Desktop android
#44598 Failing with #43907 in web desktop and iOS #44598 (comment)
#44656 Failing with #44617 in web and iOS #44656 (comment)
#44663 - validation pending in mWeb, Desktop android and iOS
#44736 Failing with #42466 in android and iOS #44736 (comment)

[mountiny]

Demoted #44885

[mountiny]

demoted #44886

[mountiny]

demoted #44869

[mountiny]

demoted #44818 as its very rare flow for current users

[mountiny]

checking #44385 off as the linked issues are being handled

[mountiny]

checked #44598 off as the linked issue is handled as not a blocker
checked #44656 off as the linked issue has been handled internally as not a blocker
checked #44736 off as the author is aware of the issue, its not a blocker

[kavimuru]

Regression is completed in the TR
Unchecked PRs
#42736 - Pending validation in Desktop
#43036 - Failing with #44806
#43502 - Pending validation in Desktop iOS
#43927 - Pending validation in Desktop iOS
#44086 - Blocked with #43081 (comment)
#44138 - Failing with #44899 repro in production and checking it off
#44268 - validation is pending
#44385 - Failing with #43415, #44801, #44802,#44803
#44393 - Need help to validate this PR , commented here #44393 (comment)

[kavimuru]

Regression is completed in the TR
Unchecked PRs
#43036 - Failing with #44806
#43502 - Failing with #44879, repro in production and checking it off
#43927 - Failing with #44834
#44086 - Blocked with #43081 (comment)
#44268 - Failing with #44917
#44385 - Failing with #43415, #44801, #44802
#44393 - Need help to validate this PR , commented here #44393 (comment)

Blockers:
#44801
#44927

[tgolen]

#44927 demoted
#44801 I have verified it's fixed and I am checking it off

[tgolen]

I checked off all the others because they are blocked by backend fixes and it's OK to still let this deploy go out with those issues.

#44393 Is the last remaining issue. It looks like there are more QA instructions in there now and is able to be verified again @kavimuru

[kavimuru]

@tgolen PR was validated internally #44393 (comment) and checked it off.

[mountiny]