-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 44506 IOS - Transfer owner - App returns to empty screen when sw… #44712
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
…iping right on success screen
Reviewer Checklist
Screenshots/VideosAndroid: NativetransferAndroid.mp4Android: mWeb ChrometransferAndroidmWeb.mp4iOS: NativetransferiOS.mp4iOS: mWeb SafaritransferiOSmWeb.mp4MacOS: Chrome / SafaritransferChrome.mp4MacOS: DesktoptransferDesktop.mp4 |
This can be tested with browser back button, History > Back, and device back button on Chrome, Desktop, and Android respectively.
Could you update this step in Tests accordingly. It will be clearer for QA for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Thanks. I updated it |
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.4-0 🚀
|
🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀
|
Details
Fixed Issues
$ #44506
PROPOSAL: #44506 (comment)
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
mWeb.Adroid.mov
iOS: Native
ios.mov
iOS: mWeb Safari
mWeb.Safari.mov
MacOS: Chrome / Safari
MacOS-Chrome.mov
MacOS: Desktop
Desktop.mov