[HOLD for payment 2024-11-18] [$125] Expensify Card - Back button on issue card page returns to Bank account verified page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.56-3
Reproducible in staging?: Y
Reproducible in production?: N/A Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Expensify Card
3. Click Issue new card
4. Add a bank account
5. Dismiss the RHP
6. Click Issue new account
7. Select the added bank account
8. On Bank account verified page, click Got it
9. On Issue card page, click RHP back button

Expected Result:

The RHP will be dismissed

Actual Result:

App returns to Bank account verified page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6652488_1730477794594.bandicam_2024-11-02_00-05-53-300.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @OfstadC

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021853850206557900537
• Upwork Job ID: 1853850206557900537
• Last Price Increase: 2024-11-05
• Automatic offers:
• Nodebrute | Contributor | 104755066
• rayane-djouah | Contributor | 104792968

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Back button on issue card page returns to Bank account verified page

What is the root cause of that problem?

When user press Got it we simply navigate to next page rather then dismissing the current modal

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx

Line 154 in b9ec75a

onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID))}

What changes do you think we should make in order to solve the problem?

We should also dismiss the modal before navigating here. We can do something like this

   onPress={() => {
                                Navigation.dismissModal();
                                Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID)); 
                            }}

It's a similar approach that we also use in other places

What alternative solutions did you explore? (Optional)

We can also use goBack() before navigating to WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW

[thienlnam]

I'm not sure if this is actually a bug or not - adding external so we can get a BZ assigned to determine whether we should fix this or not

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thienlnam]

Possibly no longer an issue https://expensify.slack.com/archives/C01GTK53T8Q/p1730482621189069

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to Bank account verified page

What is the root cause of that problem?

• When users press on "Got it" button, they just navigate to a new screen without removing the current screen from stack:
  

  App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx

  Line 154 in b9ec75a

  onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID))}

  
  so when clicking on back button on issue card page, the bank account verified page appears again.

What changes do you think we should make in order to solve the problem?

• When clicking on "Got it", we should replace the current screen by the issue new card screen. To do it, just need to navigate with type: UP in this:

                                Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID), CONST.NAVIGATION.TYPE.UP); 

What alternative solutions did you explore? (Optional)

[melvin-bot]

@OfstadC, @thienlnam, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[situchan]

@daledah's proposal @Nodebrute's proposal looks good.
There's one more verifying step after #51407 so the repro step should be updated a bit.
🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @thienlnam is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[situchan]

@s77rt please take over as C+

[Nodebrute]

@situchan Thank you, it worked! The PR will be ready in a few hours.

[s77rt]

Will get someone else to review the PR as I cannot reproduce the bug due to bank issues.

[s77rt]

cc @rayane-djouah

[rayane-djouah]

Hi! Commenting for assignment (coming from https://expensify.slack.com/archives/C02NK2DQWUX/p1730910442673039)

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Dismiss RHP on back button click from Issue New Card page #52091

If no regressions arise, payment will be issued on 2024-11-18. 🎊

For reference, here are some details about the assignees on this issue:

• @rayane-djouah requires payment automatic offer (Contributor)
• @Nodebrute requires payment automatic offer (Contributor)

[melvin-bot]

@rayane-djouah @OfstadC The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[OfstadC]

@rayane-djouah Please complete the BZ checklist before the payment date. Thank you! 😃

[rayane-djouah]

BugZero Checklist:

• Classify the bug:

  Bug classification

  Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

  Where bug was reported:

  • 2a. Reported on production
  • 2b. Reported on staging (deploy blocker)
  • 2c. Reported on a PR
  • 2z. Other:

  Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/51407/files#r1844661469

• If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• @OfstadC Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

#### Precondition:

- A workspace has been created.
- The "Expensify Card" feature has been enabled on the "More features" page.

#### Test:

1. Go to workspace settings > Expensify Card
2. Click Issue new card
3. Add a bank account
4. Dismiss the RHP
5. Click Issue new card
6. Select the added bank account
7. On the "Bank account verified" page, click "Got it"
8. On the "Issue card" page, click RHP back button
9. Verify that the RHP is dismissed after clicking the back button.

Do we agree 👍 or 👎

[OfstadC]

Test - https://github.com/Expensify/Expensify/issues/445651

Payment Summary

• @rayane-djouah paid $125 via Upwork
• @Nodebrute paid $125 via Upwork