Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sage Intacct - Back button on workspace editor returns to Accounting page again #44813

Closed
4 of 6 tasks
izarutskaya opened this issue Jul 4, 2024 · 20 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : #43661
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • User has a few workspaces.
  • One of the workspaces is connected to Sage Intacct.
  1. Go to staging.new.expensify.com
  2. Go to another workspace that is not connected to Sage Intacct.
  3. Go to Accounting.
  4. Tap Connect next to Sage Intacct.
  5. Select Reuse existing connection.
  6. Tap on the workspace that is connected to Sage Intacct.
  7. Tap back button on the top left.
  8. Tap back button again.

Expected Result:

App will return to workspace list.

Actual Result:

App returns to Accounting page again (from Step 3).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6532647_1720059749451.RPReplay_Final1720058908.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 4, 2024
Copy link

melvin-bot bot commented Jul 4, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 4, 2024

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@lakchote
Copy link
Contributor

lakchote commented Jul 4, 2024

cc @SzymczakJ since you've worked on #43661

@lakchote
Copy link
Contributor

lakchote commented Jul 4, 2024

I'd say it's not a blocker, as it's an edge case and it doesn't affect core functionality.

Plus, it's behind the intacctOnNewExpensify beta.

@lakchote lakchote added Daily KSv2 Hourly KSv2 and removed Hourly KSv2 Daily KSv2 DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 4, 2024
@twisterdotcom
Copy link
Contributor

@SzymczakJ let us know if you want to take this. Otherwise we can open it up.

@SzymczakJ
Copy link
Contributor

Implementation of this feature is in progress and "Reuse existing connection" screen is still not ready. Right now I'm working on follow-up PR for Sage Intacct and I'll fix this navigation bug in it. Is it okay with you?
Assign me to this one so I can notify you to retest when my fix is merged 😃

@hungvu193
Copy link
Contributor

@lakchote Please assign me as well since I worked with @SzymczakJ in the offending PR

@SzymczakJ
Copy link
Contributor

Follow up PR still under work, waiting for some BE features.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 8, 2024
@hungvu193
Copy link
Contributor

Still working on the PR.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 11, 2024
@lakchote
Copy link
Contributor

lakchote commented Jul 15, 2024

Not overdue, @hungvu193 commented above.

@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2024
@SzymczakJ
Copy link
Contributor

SzymczakJ commented Jul 16, 2024

Follow-up merged, this should be fixed 😄

Copy link

melvin-bot bot commented Jul 18, 2024

@twisterdotcom @hungvu193 @lakchote @SzymczakJ this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jul 18, 2024
@twisterdotcom
Copy link
Contributor

Are we just waiting for a deploy now?

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2024
@hungvu193
Copy link
Contributor

I think the PR that fixed this issue was deployed to staging, we can retest this and close if we can't reproduce

@lakchote
Copy link
Contributor

The PR that fixed it was actually even deployed to production

Asked for a QA retest here

@twisterdotcom
Copy link
Contributor

Okay, do we need to handle any payment here? Or will this be handled in #44669 then?

@hungvu193
Copy link
Contributor

No payment needed here. We can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Status: Done
Development

No branches or pull requests

5 participants