Image zoom for mobile browser apps #43620

ZhenjaHorbach · 2024-06-12T23:04:08Z

Details

Image zoom for mobile browser apps

Fixed Issues

$ #36597
PROPOSAL: #36597 (comment)

Tests

Open reports with attachments on mobile web.
Open image attachment.
Verify image can be dragged and zoomed using pan and pinch gestures.

Verify that no errors appear in the JS console

Offline tests

Open reports with attachments on mobile web.
Open image attachment.
Verify image can be dragged and zoomed using pan and pinch gestures.

QA Steps

Open reports with attachments on mobile web.
Open image attachment.
Verify image can be dragged and zoomed using pan and pinch gestures.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

2024-06-13.12.40.07.mov

Android: mWeb Chrome

2024-06-13.12.43.22.mov

iOS: Native

2024-06-13.12.34.08.mov

iOS: mWeb Safari

2024-06-13.12.33.17.mov

MacOS: Chrome / Safari

2024-06-13.01.17.23.mov

MacOS: Desktop

2024-06-13.01.20.11.mov

melvin-bot · 2024-06-12T23:04:14Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-06-13T03:18:44Z

@ZhenjaHorbach Pls let me know when you finish the checklist and screenshots/videos

ZhenjaHorbach · 2024-06-13T06:12:05Z

@ZhenjaHorbach Pls let me know when you finish the checklist and screenshots/videos

Unfortunately, a contributor implementation is very crude

We don't have double tap for image, swipe left or right for a carousel

Therefore, I need a little more time to add this functionality

So the PR will be ready within a few days

ZhenjaHorbach · 2024-06-13T11:10:26Z

@dukenv0307
Hello
PR is ready !

I decided not to use custom Gesture functions as proposed by the contributor because they closely replicate the existing ones we use for MultiGestureCanvas.

https://github.com/Expensify/App/tree/fb323f66e731cfc402417f41a45bb42d6b887435/src/components/MultiGestureCanvas

So I used Lightbox for the fix which already uses MultiGestureCanvas.
And made small changes so that all the functionality of gestures is available

dukenv0307 · 2024-06-14T16:10:00Z

@ZhenjaHorbach Can you check the previous proposal that decide to use Lightbox but it causes some errors

ZhenjaHorbach · 2024-06-14T20:23:13Z

@ZhenjaHorbach Can you check the previous proposal that decide to use Lightbox but it causes some errors

Yes
I checked
Thanks for mentioning other proposals
And I hope I covered all the cases so that attachment on the mobile web works the same as in native applications

dukenv0307 · 2024-06-17T02:17:31Z

@ZhenjaHorbach Is it ready for review? I see you used LightBox, did you face the problem mentioned in other proposals? Thanks

ZhenjaHorbach · 2024-06-17T07:21:18Z

@ZhenjaHorbach Is it ready for review? I see you used LightBox, did you face the problem mentioned in other proposals? Thanks

Hello
After testing I did not find the mentioned problems
So PR is ready

dukenv0307 · 2024-06-18T03:19:41Z

Thanks @ZhenjaHorbach. Since we're trying to use the different solution, so we need to discuss in the issue here

ZhenjaHorbach · 2024-06-20T09:12:44Z

@dukenv0307
About double tap for IOS chrome

Looks like the problem is related to chrome itself

I found interesting topic
taye/interact.js#828
And here the problem with double tap is indicated

And in this topic we have this link with Touch Event Trigger Test
https://codepen.io/alwaysawake/pen/MWKYPdW

And taps in safari work fine
But in chrome they work once in 2 taps (So to call zoom we need 3 taps)

Therefore, I need more time to come up with a solution to fix this bug.

dukenv0307 · 2024-06-24T02:46:03Z

@ZhenjaHorbach Pls let me know when it's ready for review. Thanks

ZhenjaHorbach · 2024-06-24T07:49:13Z

@ZhenjaHorbach Pls let me know when it's ready for review. Thanks

Yes, sure
Sorry for delay
I'll let you know when everything is ready !

ZhenjaHorbach · 2024-07-01T09:41:22Z

Is it ready for review @ZhenjaHorbach

@dukenv0307
Sorry for not pinging
I think yes

@shawnborton
And can you please create new adhoc builds to make sure that everything works on real devices ?

shawnborton · 2024-07-01T13:42:16Z

Starting the builds now!

github-actions · 2024-07-01T14:16:25Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/43620/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/43620/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/43620/NewExpensify.dmg	https://43620.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2024-07-01T16:51:51Z

Tested and this feels pretty good to me!

ZhenjaHorbach · 2024-07-01T19:08:15Z

@dukenv0307
We have performance tests issue
It's okay

Came from main
https://github.com/Expensify/App/actions/runs/9749008873/job/26905262042

dukenv0307 · 2024-07-02T04:50:23Z

code looks good and tests well

dukenv0307 · 2024-07-02T04:56:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-02.at.10.57.03.mov

Android: mWeb Chrome

Screen.Recording.2024-07-02.at.11.49.03.mov

iOS: Native

Screen.Recording.2024-07-02.at.10.57.33.mov

iOS: mWeb Safari

Screen.Recording.2024-07-02.at.11.44.21.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-02.at.11.47.29.mov

MacOS: Desktop

Screen.Recording.2024-07-02.at.11.52.07.mov

dukenv0307 · 2024-07-02T04:56:52Z

Waiting for perf test is resolved

ZhenjaHorbach · 2024-07-02T06:28:04Z

Waiting for perf test is resolved

@dukenv0307
Updated the branch to the latest version of main and everything is fine now !

dukenv0307 · 2024-07-02T15:49:10Z

TY @ZhenjaHorbach

dukenv0307 · 2024-07-02T15:50:45Z

@flodnv Pls take the final look at this PR. Thanks

flodnv

👍

flodnv · 2024-07-03T12:33:07Z

src/styles/index.ts

@@ -1512,6 +1512,11 @@ const styles = (theme: ThemeColors) =>
            height: '100%',
        },

+        canvasContainer: {
+            borderWidth: 1,


Not A Blocker; but maybe worth adding a comment here in the code summarizing this

flodnv · 2024-07-03T12:33:50Z

src/components/Attachments/AttachmentCarousel/Pager/AttachmentCarouselPagerContext.ts

@@ -17,16 +18,28 @@ type AttachmentCarouselPagerItems = {
 };

 type AttachmentCarouselPagerContextValue = {
-    /** The list of items that are shown in the pager */
+    /** List of items displayed in the attachment */


Suggested change

/** List of items displayed in the attachment */

/** List of attachments displayed in the pager */

Is this more accurate?

I think yes
But the pager sounds a little unclear 😅
But I don't mind
I'll update now

OSBotify · 2024-07-03T17:11:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-03T20:00:30Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.0.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-04T22:12:57Z

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-10T10:56:02Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:18:47Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add Handle image zoom for mobile browser apps

bd8910c

ZhenjaHorbach requested a review from a team as a code owner June 12, 2024 23:04

melvin-bot bot requested review from dukenv0307 and removed request for a team June 12, 2024 23:04

ZhenjaHorbach added 3 commits June 13, 2024 01:11

Make a little refactoring

2bd1a2a

Fix bug with close modal on send attachment screen

ca69b0f

Reset image position when onSwipeDown is undefined

2e34376

ZhenjaHorbach added 3 commits June 13, 2024 12:21

Refactor code

5894906

Make some minnor changes

e30a3bb

Update animation for changing attachment item

2f40b54

Remove unnecessary type

ebb0eb4

ZhenjaHorbach added 2 commits June 14, 2024 21:05

Fix minnor issues related with arrows

fec109e

Fix bug with animation for carousel

6c6390b

Fix bug with animation for carousel x2

4fa559f

ZhenjaHorbach added 3 commits June 20, 2024 11:35

Fix conflicts and update branch

1d5f485

Update maxDelay for doubleTapGesture for mobile browsers

e303843

Merge branch 'main' into handle-image-zoom

0bfd329

Fix bug with double tap for ios chrome

7345cf8

Merge branch 'main' into handle-image-zoom

fb32193

ZhenjaHorbach added 3 commits July 1, 2024 20:50

Refactor the code to make it similar to native

531e975

Refactor the code to make it similar to native x2

14175f9

Merge branch 'main' into handle-image-zoom

7d0bc47

Merge branch 'main' into handle-image-zoom

edd2751

dukenv0307 approved these changes Jul 2, 2024

View reviewed changes

melvin-bot bot requested a review from flodnv July 2, 2024 15:49

flodnv reviewed Jul 3, 2024

View reviewed changes

Fix comments

8511f5f

flodnv approved these changes Jul 3, 2024

View reviewed changes

flodnv merged commit dc2a371 into Expensify:main Jul 3, 2024
14 checks passed

github-actions bot mentioned this pull request Jul 3, 2024

Deploy Checklist: New Expensify 2024-07-03 #44782

Closed

melvin-bot bot mentioned this pull request Jul 10, 2024

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$1000] mWeb - Chat – Unable to zoom the image with pinching #36597

Closed

6 tasks

bernhardoj mentioned this pull request Aug 21, 2024

[HOLD for payment 2024-09-03][$250] iOS - Attachment - I can to switch to another attachment in PDF zoomed state #47805

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Image zoom for mobile browser apps #43620

Image zoom for mobile browser apps #43620

ZhenjaHorbach commented Jun 12, 2024 •

edited

Loading

melvin-bot bot commented Jun 12, 2024

dukenv0307 commented Jun 13, 2024

ZhenjaHorbach commented Jun 13, 2024 •

edited

Loading

ZhenjaHorbach commented Jun 13, 2024 •

edited

Loading

dukenv0307 commented Jun 14, 2024

ZhenjaHorbach commented Jun 14, 2024 •

edited

Loading

dukenv0307 commented Jun 17, 2024

ZhenjaHorbach commented Jun 17, 2024 •

edited

Loading

dukenv0307 commented Jun 18, 2024

ZhenjaHorbach commented Jun 20, 2024 •

edited

Loading

dukenv0307 commented Jun 24, 2024

ZhenjaHorbach commented Jun 24, 2024

ZhenjaHorbach commented Jul 1, 2024

shawnborton commented Jul 1, 2024

github-actions bot commented Jul 1, 2024

shawnborton commented Jul 1, 2024

ZhenjaHorbach commented Jul 1, 2024 •

edited

Loading

dukenv0307 commented Jul 2, 2024

dukenv0307 commented Jul 2, 2024

dukenv0307 commented Jul 2, 2024

ZhenjaHorbach commented Jul 2, 2024 •

edited

Loading

dukenv0307 commented Jul 2, 2024

dukenv0307 commented Jul 2, 2024

flodnv left a comment

flodnv Jul 3, 2024

flodnv Jul 3, 2024

ZhenjaHorbach Jul 3, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

	/** List of items displayed in the attachment */
	/** List of attachments displayed in the pager */

Image zoom for mobile browser apps #43620

Image zoom for mobile browser apps #43620

Conversation

ZhenjaHorbach commented Jun 12, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 12, 2024

dukenv0307 commented Jun 13, 2024

ZhenjaHorbach commented Jun 13, 2024 • edited Loading

ZhenjaHorbach commented Jun 13, 2024 • edited Loading

dukenv0307 commented Jun 14, 2024

ZhenjaHorbach commented Jun 14, 2024 • edited Loading

dukenv0307 commented Jun 17, 2024

ZhenjaHorbach commented Jun 17, 2024 • edited Loading

dukenv0307 commented Jun 18, 2024

ZhenjaHorbach commented Jun 20, 2024 • edited Loading

dukenv0307 commented Jun 24, 2024

ZhenjaHorbach commented Jun 24, 2024

ZhenjaHorbach commented Jul 1, 2024

shawnborton commented Jul 1, 2024

github-actions bot commented Jul 1, 2024

shawnborton commented Jul 1, 2024

ZhenjaHorbach commented Jul 1, 2024 • edited Loading

dukenv0307 commented Jul 2, 2024

dukenv0307 commented Jul 2, 2024

Reviewer Checklist

Screenshots/Videos

dukenv0307 commented Jul 2, 2024

ZhenjaHorbach commented Jul 2, 2024 • edited Loading

dukenv0307 commented Jul 2, 2024

dukenv0307 commented Jul 2, 2024

flodnv left a comment

Choose a reason for hiding this comment

flodnv Jul 3, 2024

Choose a reason for hiding this comment

flodnv Jul 3, 2024

Choose a reason for hiding this comment

ZhenjaHorbach Jul 3, 2024

Choose a reason for hiding this comment

OSBotify commented Jul 3, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

ZhenjaHorbach commented Jun 12, 2024 •

edited

Loading

ZhenjaHorbach commented Jun 13, 2024 •

edited

Loading

ZhenjaHorbach commented Jun 13, 2024 •

edited

Loading

ZhenjaHorbach commented Jun 14, 2024 •

edited

Loading

ZhenjaHorbach commented Jun 17, 2024 •

edited

Loading

ZhenjaHorbach commented Jun 20, 2024 •

edited

Loading

ZhenjaHorbach commented Jul 1, 2024 •

edited

Loading

ZhenjaHorbach commented Jul 2, 2024 •

edited

Loading