[VIP][Travel] View trip details and authenticate to travelDot #43081

rushatgabhane · 2024-06-04T22:50:20Z

Details

Fixed Issues

$ #42814
PROPOSAL:

Verify that no errors appear in the JS console

Tests / QA Steps

Prerequisites: Be on travel beta. On old dot, create a new trip and book a flight (with fake credit card)
Card number: 4242424242424242, CV and expiry: Any

On new dot

Go to a trip room
Open the trip transaction
Click view trip details
Verify that it takes you to travelDot and redirects you to the correct trip

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-10.at.19.26.32.mov

Android: mWeb Chrome

iOS: Native

production - expected to fail because my account is setup for staging only

Screen.Recording.2024-06-10.at.19.15.11.mov

iOS: mWeb Safari

Screen.Recording.2024-06-10.at.19.09.57.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-10.at.20.30.43.mov

MacOS: Desktop

Screen.Recording.2024-06-10.at.19.23.44.mov

melvin-bot · 2024-06-04T22:50:48Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2024-06-04T22:51:16Z

@shubham1206agra PR is ready

rushatgabhane · 2024-06-04T22:56:20Z

Asked a question here

rushatgabhane · 2024-06-04T23:01:40Z

an authenticated call to travelDot isn't possible right now, so it'll show the login page.

grgia · 2024-06-05T13:12:14Z

src/components/ReportActionItem/MoneyRequestView.tsx

@@ -549,6 +562,15 @@ function MoneyRequestView({
                        />
                    </OfflineWithFeedback>
                )}
+                {shouldShowViewTripDetails && tripID && (
+                    <MenuItem
+                        title="View trip details"


Let's add this to translate

grgia · 2024-06-05T13:13:17Z

src/components/ReportActionItem/MoneyRequestView.tsx

@@ -549,6 +562,15 @@ function MoneyRequestView({
                        />
                    </OfflineWithFeedback>
                )}
+                {shouldShowViewTripDetails && tripID && (


if we need tripID to Show the Trip Details, should we include && tripID in shouldShowViewTripDetails declaration

yeah that makes sense

src/CONST.ts

rushatgabhane · 2024-06-14T16:42:31Z

EDIT: fixed on main

we have TS errors on main

OSBotify · 2024-06-17T11:09:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-17T23:47:44Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-06-18T00:05:10Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

kavimuru · 2024-06-18T14:12:45Z

@rushatgabhane @grgia @shubham1206agra Can applause QA validate this PR? applause.expensifail.com domain is on travel beta?

grgia · 2024-06-18T14:16:08Z

@stitesExpensify on the above

OSBotify · 2024-06-18T16:01:55Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

rushatgabhane · 2024-06-19T16:41:48Z

@kavimuru yes you can test using the QA steps given in the PR

kavimuru · 2024-06-19T16:50:00Z

@rushatgabhane This is what I am seeing when booking for a trip in OD

AndrewGable · 2024-06-19T16:54:15Z

@kavimuru - Can you send a gmail account that you will test with? I will add to the beta manually.

kavimuru · 2024-06-19T17:01:19Z

@andrew sure I am asking the QA team and will share shortly.

kavimuru · 2024-06-19T17:08:38Z

@AndrewGable rybkina+061924pr@gmail.com and kavi.utest+190624@gmail.com

AndrewGable · 2024-06-19T17:11:41Z

Added to beta, please try those accounts and let me know 👍

kavimuru · 2024-06-19T17:12:11Z

@AndrewGable could you add this one too andreylazutkinutest+19061@gmail.com?

AndrewGable · 2024-06-19T17:13:12Z

Added 👍

kavimuru · 2024-06-19T17:26:55Z

@AndrewGable @rushatgabhane we are seeing this error message, not sure this is a bug or beta issue

address.mp4

rushatgabhane · 2024-06-19T17:41:04Z

@kavimuru can you try booking again?

kavimuru · 2024-06-19T17:44:43Z

Seeing the same, asked other tester to double check

AndrewGable · 2024-06-19T18:11:05Z

We are looking into this, thank you!

AndrewGable · 2024-06-19T18:31:49Z

It seems like there is a backend bug that we need some more time to look into, so we are going to skip the testing of this for the time being as this feature is still under the beta.

OSBotify · 2024-06-21T16:48:45Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.85-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rushatgabhane added 11 commits June 5, 2024 01:18

add trip data type

03af563

get trip id from transaction

5b0fd92

get trip id and should show trip details view

b2d1aa3

add menu item for trip details

d2f6dad

add luggage icon

2851353

add suitcase icon

c4f4512

fix type tripid

a408b66

fix type tripid

fb7fdec

add trip id url

68ba31d

navigate to trip id url

09af194

handle staging url

69cf344

rushatgabhane requested a review from a team as a code owner June 4, 2024 22:50

rushatgabhane closed this Jun 4, 2024

melvin-bot bot requested review from grgia and removed request for a team June 4, 2024 22:50

rushatgabhane reopened this Jun 4, 2024

grgia reviewed Jun 5, 2024

View reviewed changes

grgia requested a review from shubham1206agra June 5, 2024 13:16

rushatgabhane added 3 commits June 7, 2024 03:19

use translate

d0bc4fe

simplify

8f8029d

simplify travel const

b0bd79d

rushatgabhane requested a review from grgia June 7, 2024 00:27

rushatgabhane added 4 commits June 9, 2024 07:46

Merge branch 'Expensify:main' into view-trip-details

a6bc038

rm import

61e22e0

add generate spotnana command param type

750856b

add tmc id spotnananananananna

8ad2e06

fix typescript errs

e48fc99

Merge branch 'Expensify:main' into view-trip-details

9033b4e

rushatgabhane requested a review from stitesExpensify June 16, 2024 07:35

stitesExpensify approved these changes Jun 17, 2024

View reviewed changes

stitesExpensify merged commit 32e5dd2 into Expensify:main Jun 17, 2024
17 checks passed

github-actions bot mentioned this pull request Jun 17, 2024

Deploy Checklist: New Expensify 2024-06-17 #43871

Closed

44 tasks

kavimuru mentioned this pull request Jun 21, 2024

[VIP-Travel] Create Trip Room Preview #38808

Merged

50 tasks

kavimuru mentioned this pull request Jul 5, 2024

Deploy Checklist: New Expensify 2024-07-03 #44782

Closed

kmbcook mentioned this pull request Jul 13, 2024

[HOLD for payment 2024-08-19] [$250] Expense - Payment options displayed before submitting in thread created inside details page #41519

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[VIP][Travel] View trip details and authenticate to travelDot #43081

[VIP][Travel] View trip details and authenticate to travelDot #43081

rushatgabhane commented Jun 4, 2024 •

edited

Loading

melvin-bot bot commented Jun 4, 2024

rushatgabhane commented Jun 4, 2024

rushatgabhane commented Jun 4, 2024

rushatgabhane commented Jun 4, 2024

grgia Jun 5, 2024

rushatgabhane Jun 7, 2024

grgia Jun 5, 2024

rushatgabhane Jun 7, 2024

rushatgabhane commented Jun 14, 2024 •

edited

Loading

OSBotify commented Jun 17, 2024

OSBotify commented Jun 17, 2024

OSBotify commented Jun 18, 2024

kavimuru commented Jun 18, 2024

grgia commented Jun 18, 2024

OSBotify commented Jun 18, 2024

rushatgabhane commented Jun 19, 2024

kavimuru commented Jun 19, 2024

AndrewGable commented Jun 19, 2024

kavimuru commented Jun 19, 2024

kavimuru commented Jun 19, 2024

AndrewGable commented Jun 19, 2024

kavimuru commented Jun 19, 2024

AndrewGable commented Jun 19, 2024

kavimuru commented Jun 19, 2024 •

edited

Loading

rushatgabhane commented Jun 19, 2024

kavimuru commented Jun 19, 2024

AndrewGable commented Jun 19, 2024

AndrewGable commented Jun 19, 2024

OSBotify commented Jun 21, 2024

[VIP][Travel] View trip details and authenticate to travelDot #43081

[VIP][Travel] View trip details and authenticate to travelDot #43081

Conversation

rushatgabhane commented Jun 4, 2024 • edited Loading

Details

Fixed Issues

Tests / QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 4, 2024

rushatgabhane commented Jun 4, 2024

rushatgabhane commented Jun 4, 2024

rushatgabhane commented Jun 4, 2024

grgia Jun 5, 2024

Choose a reason for hiding this comment

rushatgabhane Jun 7, 2024

Choose a reason for hiding this comment

grgia Jun 5, 2024

Choose a reason for hiding this comment

rushatgabhane Jun 7, 2024

Choose a reason for hiding this comment

rushatgabhane commented Jun 14, 2024 • edited Loading

OSBotify commented Jun 17, 2024

OSBotify commented Jun 17, 2024

OSBotify commented Jun 18, 2024

kavimuru commented Jun 18, 2024

grgia commented Jun 18, 2024

OSBotify commented Jun 18, 2024

rushatgabhane commented Jun 19, 2024

kavimuru commented Jun 19, 2024

AndrewGable commented Jun 19, 2024

kavimuru commented Jun 19, 2024

kavimuru commented Jun 19, 2024

AndrewGable commented Jun 19, 2024

kavimuru commented Jun 19, 2024

AndrewGable commented Jun 19, 2024

kavimuru commented Jun 19, 2024 • edited Loading

rushatgabhane commented Jun 19, 2024

kavimuru commented Jun 19, 2024

AndrewGable commented Jun 19, 2024

AndrewGable commented Jun 19, 2024

OSBotify commented Jun 21, 2024

rushatgabhane commented Jun 4, 2024 •

edited

Loading

rushatgabhane commented Jun 14, 2024 •

edited

Loading

kavimuru commented Jun 19, 2024 •

edited

Loading