[HOLD for Payment 2024-09-6][$250] Android - Chat - Open a new room/WS chat, entering @ does not display user suggestions

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4704455
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Tap on a workspace or room with no activity
3. Enter @ in compose box
4. Note user suggestions are not displayed
5. Tap on header
6. Navigate back to conversation page
7. Keep cursor after @ and note now user suggestions are shown

Expected Result:

Open a new room/WS chat, entering @ must display user suggestions

Actual Result:

Open a new room/WS chat, entering @ does not display user suggestions. It is shown only after tapping header and navigate back to conversation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6536265_1720468622248.screenrecorder-2024-07-08-20-41-55-629_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0180b0b26a5f7f23c0
• Upwork Job ID: 1811721981798318944
• Last Price Increase: 2024-08-09
• Automatic offers:
• ikevin127 | Reviewer | 103480415
• dominictb | Contributor | 103480416

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0180b0b26a5f7f23c0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[ikevin127]

📃 Issue is definitely reproducible, just reproduced on production as well. On local dev the behaviour might be even worse because of the recent introduction of React StrictMode which might interfere with the react-native-live-markdown implementation.

🔍 Looking for proposals!

[melvin-bot]

@sonialiap, @ikevin127 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ikevin127]

Callback to #45008 (comment) -> Looking for proposals 🎲

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[ikevin127]

Callback to #45008 (comment) -> Looking for proposals 🎲

[melvin-bot]

@sonialiap @ikevin127 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@sonialiap, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[ikevin127]

Callback to #45008 (comment) -> Looking for proposals 🎲

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sonialiap]

@kadiealexander I'm OOO Aug 19-30, adding leave buddy.
Satus: waiting on @youssef-lr to assign contributor

[ikevin127]

Status update: PR is open, contributor is re-working solution because performance tests are failing with initial solution.

[ikevin127]

Status update: PR is ready for merge, we're currently awaiting on CME for final 🟢 Approve and merge.

[melvin-bot]

@youssef-lr, @sonialiap, @ikevin127, @kadiealexander, @dominictb Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@youssef-lr, @sonialiap, @ikevin127, @kadiealexander, @dominictb Huh... This is 4 days overdue. Who can take care of this?

[ikevin127]

Status update: PR was merged to staging 🟢, did not get to production yet ⚠️.

@youssef-lr do you happen to have more context on why the PR was not deployed to production yet ? Additionally, I noticed you closed a revert PR recently, what happened - something wrong with the initial PR ?

Nevermind, figured out what happened - see coment below👇

[ikevin127]

⚠️ We just got confirmation on Slack that the Deploy Checklist: New Expensify 2024-08-26 which includes the PR of this issue was only deployed to production today in Deploy Checklist: New Expensify 2024-08-28. More context on why this happened can be found in this Slack thread and this Slack comment.

Given the context above, this issue should be on [HOLD for Payment 2024-09-6] according to today’s production deploy from Deploy Checklist: New Expensify 2024-08-28.

cc @sonialiap @youssef-lr

[sonialiap]

Thanks Kevin, I've updated the title

[ikevin127]

• [@ikevin127] The PR that introduced the bug has been identified. Link to the PR: N/A.
• [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A.
• [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A.
• [@ikevin127] Determine if we should create a regression test for this bug.
• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Launch app.
2. Tap on a workspace or room with no activity.
3. Input @ in the composer box.
4. Verify that user suggestions popup is displayed.

Do we agree 👍 or 👎.

[ikevin127]

cc @sonialiap

[sonialiap]

Payment summary:

• @ikevin127 $250 - paid ✔️
• @dominictb $250 - paid ✔️