[HOLD #44016] [Xero Export] Display Xero auto-sync errors and RBRs in NewDot

[lakchote]

• HELD on [QBO Export] Push QBO auto-sync errors to NewDot #44015

Main issue: https://github.com/Expensify/Expensify/issues/409245

Part of QBO Export and Error Handling in NewDot

Main issue: https://github.com/Expensify/Expensify/issues/350150
Doc section: https://docs.google.com/document/d/1aQl-AK_F6IqszWYG2aEllTsD5x3h4b8Zu0XEG0LuQ08/edit#heading=h.pmmx5zp5s75j
Project: #wave-collect

Feature Description

As described in the doc, we need to display a RBR when there are errors in a policy connection’s last sync.

The RBR will show on the path to the integration connection settings (Avatar > Workspaces > [Workspace name] > Accounting > Connections):

• LHN Avatar: check if policy.connection.lastSync.isSuccessful is false in the Indicator
• InitialSettingsPage: add the same check to hasGlobalWorkspaceSettingsRBR
• WorkspaceInitialPage: add the same check to the connections menu item here
• PolicyAccountingPage: use policy.connection.lastSync.errorMessage to populate the errorText option for the Xero menu item here

When the error is a credentials error (policy.connection.lastSync.isAuthenticationError is true), we’ll replace the ‘Sync now’ option in the connection’s 3-dot menu with a ‘Reconnect’ option here. The option will restart the Xero Auth flow as described in our initial QBO doc.

Manual Test Steps

Prerequisites

• Collect workspace with an admin and member
• Setup Xero integration connection

Steps

1. Log into Xero and disconnect the Expensify app (Menu > Apps > Overview > Expensify 3-dot menu > Disconnect)
2. Log into NewDot as the admin
3. Verify there's a RBR on the path: Avatar > Workspaces > [Workspace name] > Accounting > Xero
4. Verify a red error message appears on the connection explaining the issue
5. Select Xero's 3-dot menu
6. Verify there’s a “Enter credentials” option
7. Select “Enter credentials”
8. Verify a new window opens to log into Xero

[lakchote]

Will be solved by #44016

[lakchote]

Will be solved by #44016

#44016 is still in progress.

[trjExpensify]

Link issue still on-going.

[trjExpensify]

@arosiclair I would be open to just closing this tbh, there's nothing actionable based on this.

[arosiclair]

Yeah I don't think there's anything Xero specific we need to do for displaying auto-sync errors. Closing