[$250] Chat - Onboarding modal opens briefly, Concierge chat is with red dot in LHN if open public room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4706407
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log out
3. Navigate via public room link (my link https://staging.new.expensify.com/r/1353086947735283
   )

Expected Result:

The onboarding modal should not show for anonymous accounts and Concierge chat loads without red dot in LHN

Actual Result:

Onboarding modal opens for a moment and Concierge chat is with red dot in LHN if open public room as anon user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6537870_1720617431686.Public_room.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01da353289531b3f7e
• Upwork Job ID: 1811184307888769870
• Last Price Increase: 2024-07-10

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@arosiclair FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

Production:

Recording.2094.mp4

[mountiny]

cc @filip-solecki @allgandalf @adamgrzybowski I believe this might be related to or change here #44536

[BrtqKr]

Hey, I'm developer from SWM. I'd like to take care of this ticket

[allgandalf]

Please assign me too, I would review the fix

[mountiny]

@BrtqKr Thank you! Do you think you can raise the PR for the fix today?

[BrtqKr]

I'll look into it in a moment, but I haven't researched it yet, so I'm not sure. I'll try to handle it until the end of the day, but I'll give you an update later if that's ok

[mountiny]

Thank you, appreciated

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01da353289531b3f7e

[melvin-bot]

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

[mountiny]

The onboarding modal should not show for anonymous accounts and Concierge chat loads without red dot in LHN

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The onboarding modal opens briefly and the Concierge chats with a red dot in LHN if we open a public room

What is the root cause of that problem?

On Navigation root, we redirect the user to Onboarding when the user has not yet completed

App/src/libs/Navigation/NavigationRoot.tsx

Lines 90 to 93 in a91b7f8

	if (!hasCompletedGuidedSetupFlow) {
	const {adaptedState} = getAdaptedStateFromPath(ROUTES.ONBOARDING_ROOT, linkingConfig.config);
	return adaptedState;
	}

But we didn't check here if the user is anonymous and inside the hasCompletedGuidedSetupFlowSelector function we didn't check if the onboarding value is undefined.

Because when onboarding data has not yet been applied or is still in the process the value is undefined, so if we check if it's an array it will return false and will return the user has not yet completed onboarding

App/src/libs/hasCompletedGuidedSetupFlowSelector.ts

Lines 4 to 10 in a91b7f8

	function hasCompletedGuidedSetupFlowSelector(onboarding: OnyxValue<typeof ONYXKEYS.NVP_ONBOARDING>): boolean {
	// onboarding is an array for old accounts and accounts created from olddot
	if (Array.isArray(onboarding)) {
	return true;
	}
	return onboarding?.hasCompletedGuidedSetupFlow ?? false;
	}

What changes do you think we should make in order to solve the problem?

We can check if the user is not anonymous inside this condition

App/src/libs/Navigation/NavigationRoot.tsx

Lines 90 to 93 in a91b7f8

	if (!hasCompletedGuidedSetupFlow) {
	const {adaptedState} = getAdaptedStateFromPath(ROUTES.ONBOARDING_ROOT, linkingConfig.config);
	return adaptedState;
	}

And we can use this logic for the hasCompletedGuidedSetupFlowSelector function

App/src/libs/actions/Welcome.ts

Lines 50 to 52 in a91b7f8

	if (Array.isArray(onboarding) || onboarding?.hasCompletedGuidedSetupFlow === undefined) {
	return;
	}

And by doing this, it also resolves the Concierge red dot

What alternative solutions did you explore? (Optional)

[NJ-2020]

@allgandalf Please kindly review my proposal

[BrtqKr]

Regarding the onboarding it was enough to apply the condition for authenticated as in this commit from yesterday.

Correction: There was another case for empty onyx state. I've moved to the public user + empty user check.

I wanted to verify the red dot though and I think we shouldn't handle it on the front-end at all, because it's coming from the errorFields on the back-end side

[mountiny]

I believe we have reverted the offending PR and the fix will be handled in the original scope of that change