[HOLD for payment 2024-08-01] [$250] Invoice - Invoice thread opens when starting DM with the user after sending invoice to them #45187

lanitochka17 · 2024-07-10T16:35:48Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to FAB > Send invoice
Enter amount and select any receiver
Go to FAB > Start chat > Chat
Scroll down and click on the same user in Step 3 (invoice receiver)

Expected Result:

DM with the user will open

Actual Result:

Invoice thread with the user opens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6538039_1720625521824.20240710_232325.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0165c9231ff254ae89
Upwork Job ID: 1811427918558506425
Last Price Increase: 2024-07-11
Automatic offers:

rayane-djouah | Reviewer | 103140621

Issue Owner

Current Issue Owner: @trjExpensify

melvin-bot · 2024-07-10T16:35:56Z

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 · 2024-07-10T16:36:16Z

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

bernhardoj · 2024-07-11T06:35:26Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

An invoice thread opens when we select the user from new chat page.

What is the root cause of that problem?

When we select a user, it will try to find the user chat by participants using getChatByParticipants.

App/src/libs/ReportUtils.ts

Lines 5561 to 5584 in a19ef98

    
           function getChatByParticipants(newParticipantList: number[], reports: OnyxCollection<Report> = ReportConnection.getAllReports(), shouldIncludeGroupChats = false): OnyxEntry<Report> { 
        
               const sortedNewParticipantList = newParticipantList.sort(); 
        
               return Object.values(reports ?? {}).find((report) => { 
        
                   const participantAccountIDs = Object.keys(report?.participants ?? {}); 
        
                   // If the report has been deleted, or there are no participants (like an empty #admins room) then skip it 
        
                   if ( 
        
                       participantAccountIDs.length === 0 || 
        
                       isChatThread(report) || 
        
                       isTaskReport(report) || 
        
                       isMoneyRequestReport(report) || 
        
                       isChatRoom(report) || 
        
                       isPolicyExpenseChat(report) || 
        
                       (isGroupChat(report) && !shouldIncludeGroupChats) 
        
                   ) { 
        
                       return false; 
        
                   } 
        
                   const sortedParticipantsAccountIDs = participantAccountIDs.map(Number).sort(); 
        
                   // Only return the chat if it has all the participants 
        
                   return lodashIsEqual(sortedNewParticipantList, sortedParticipantsAccountIDs); 
        
               }); 
        
           }

The participants of the invoice report is the same as the DM participants, that is [currentUser, the other user]. Because they contains the same participant, getChatByParticipants has a chance to wrongly returns the wrong report, that is the invoice report instead of the DM.

What changes do you think we should make in order to solve the problem?

Skip invoice report/room when comparing the participant.

App/src/libs/ReportUtils.ts

Lines 5567 to 5577 in a19ef98

    
           if ( 
        
               participantAccountIDs.length === 0 || 
        
               isChatThread(report) || 
        
               isTaskReport(report) || 
        
               isMoneyRequestReport(report) || 
        
               isChatRoom(report) || 
        
               isPolicyExpenseChat(report) || 
        
               (isGroupChat(report) && !shouldIncludeGroupChats) 
        
           ) { 
        
               return false; 
        
           }

|| isInvoiceReport(report) || isInvoiceRoom(report)

(and any other report type if needed)

What alternative solutions did you explore? (Optional)

I want to propose using !isOneOnOneChat, but getChatByParticipants is also being used to find group chat in split bill.

App/src/libs/actions/IOU.ts

Lines 3806 to 3809 in a19ef98

    
           const allParticipantsAccountIDs = [...participantAccountIDs, currentUserAccountID]; 
        
           if (!existingSplitChatReport) { 
        
               existingSplitChatReport = ReportUtils.getChatByParticipants(allParticipantsAccountIDs, undefined, participantAccountIDs.length > 1); 
        
           }

So, the solution is if we aren't searching for group, then we use !isOneOnOneChat(report) condition.

|| (!shouldIncludeGroupChats && !isOneOnOneChat(report))

Then, we can remove the other checks (thread, group, task, etc.)

trjExpensify · 2024-07-11T15:50:33Z

@cristipaval @davidcardoza for eyes on this.

melvin-bot · 2024-07-11T15:50:47Z

Job added to Upwork: https://www.upwork.com/jobs/~0165c9231ff254ae89

melvin-bot · 2024-07-11T15:50:52Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

nkdengineer · 2024-07-15T05:12:55Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice - Invoice thread opens when starting DM with the user after sending invoice to them

What is the root cause of that problem?

When we start DM with the user, we use getChatByParticipants function to find the report of the DM chat. In this function, we will exclude some types of reports and then compare the participants. But we don't exclude the invoice report and this report has the same participant with the DM chat. So sometimes this function can return wrongly if we find the invoice report first.

App/src/libs/ReportUtils.ts

Lines 5544 to 5549 in 77d95c5

    
           if ( 
        
               participantAccountIDs.length === 0 || 
        
               isChatThread(report) || 
        
               isTaskReport(report) || 
        
               isMoneyRequestReport(report) || 
        
               isChatRoom(report) ||

What changes do you think we should make in order to solve the problem?

To avoid this bug happening in the future, we can prioritize the one one chat and group chat. With this change, we can make sure that this function will always return the DM or group first if the participant is matched.

return lodashOrderBy(Object.values(reports ?? {}), (report) => {
    if (isOneOnOneChat(report) || (isGroupChat(report) && shouldIncludeGroupChats)) {
        return 0;
    }
    return 1;
}).find((report) => {

App/src/libs/ReportUtils.ts

Line 5540 in 77d95c5

return Object.values(reports ?? {}).find((report) => {

What alternative solutions did you explore? (Optional)

rayane-djouah · 2024-07-15T09:12:32Z

Reviewing proposals

rayane-djouah · 2024-07-16T01:06:06Z

@bernhardoj's proposal looks good to me.

🎀👀🎀 C+ reviewed

melvin-bot · 2024-07-16T01:06:17Z

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot · 2024-07-16T14:02:29Z

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

bernhardoj · 2024-07-16T17:07:54Z

PR is ready

cc: @rayane-djouah

trjExpensify · 2024-07-23T13:03:04Z

Deployed to staging 4 hours ago.

melvin-bot · 2024-07-25T03:03:59Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-07-25T03:04:04Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix invoice thread opens when starting DM with the user after sending invoice to them #45500

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

@bernhardoj requires payment through NewDot Manual Requests
@rayane-djouah requires payment automatic offer (Reviewer)

melvin-bot · 2024-07-25T03:04:05Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
[@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rayane-djouah] Determine if we should create a regression test for this bug.
[@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

trjExpensify · 2024-08-02T14:56:57Z

Checklist time!

bernhardoj · 2024-08-02T15:54:59Z

Requested in ND

rayane-djouah · 2024-08-02T16:46:28Z

The PR that introduced the bug has been identified. Link to the PR: Implement Invoice rooms with individual receivers #40303
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Implement Invoice rooms with individual receivers #40303 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. There's no need; we've already included automated tests.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

cc @trjExpensify

trjExpensify · 2024-08-05T12:43:20Z

Determine if we should create a regression test for this bug. There's no need; we've already included automated tests.

Hm, I don't think we forgo manual regression testing of features in lieu of automated tests. @cristipaval @davidcardoza are manual regression tests being handed over and added centrally for this project?

trjExpensify · 2024-08-05T12:43:40Z

Payment summary as follows:

$250 to @bernhardoj for the fix
$250 to @rayane-djouah for the C+ review

trjExpensify · 2024-08-05T12:44:23Z

^^ going to hold on the Upwork payment for C+ until we're aligned on this Q.

rayane-djouah · 2024-08-05T17:17:31Z

@trjExpensify - Below are the manual regression test steps if we decide to include them:

Regression Test Proposal

Send Invoice flow:

Create a New Account
Click on the Floating Action Button (FAB).
Select "Send Invoice".
Choose a recipient with whom you have no prior interactions.
Complete the invoice details and send it.
Click on FAB again.
Choose "Start Chat".
Select the same recipient as in Step 4.
Verify that the chat that opens should be a direct message (DM) chat, not the invoice report chat.

Submit expense flow:

Create a New Account
Click on the Floating Action Button (FAB).
Select "Submit expense".
Choose a recipient with whom you have no prior interactions.
Complete the expense details and send it.
Click on FAB again.
Choose "Start Chat".
Select the same recipient as in Step 4.
Verify that the chat that opens should be a direct message (DM) chat, not the expense report chat.

Do we agree 👍 or 👎

trjExpensify · 2024-08-05T19:40:30Z

Cool, thanks! Settled up. 👍

JmillsExpensify · 2024-08-06T19:47:22Z

$250 approved for @bernhardoj

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 10, 2024

melvin-bot bot assigned trjExpensify Jul 10, 2024

trjExpensify added the External Added to denote the issue can be worked on by a contributor label Jul 11, 2024

melvin-bot bot changed the title ~~Invoice - Invoice thread opens when starting DM with the user after sending invoice to them~~ [$250] Invoice - Invoice thread opens when starting DM with the user after sending invoice to them Jul 11, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 11, 2024

trjExpensify added this to [#whatsnext] #billpay Jul 11, 2024

melvin-bot bot assigned rayane-djouah Jul 11, 2024

melvin-bot bot added the Overdue label Jul 15, 2024

melvin-bot bot removed the Overdue label Jul 15, 2024

melvin-bot bot assigned cristipaval Jul 16, 2024

cristipaval assigned bernhardoj Jul 16, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 16, 2024

bernhardoj mentioned this issue Jul 16, 2024

Fix invoice thread opens when starting DM with the user after sending invoice to them #45500

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 16, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 25, 2024

melvin-bot bot changed the title ~~[$250] Invoice - Invoice thread opens when starting DM with the user after sending invoice to them~~ [HOLD for payment 2024-08-01] [$250] Invoice - Invoice thread opens when starting DM with the user after sending invoice to them Jul 25, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Jul 25, 2024

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 31, 2024

melvin-bot bot removed the Overdue label Aug 2, 2024

rayane-djouah mentioned this issue Aug 2, 2024

Implement Invoice rooms with individual receivers #40303

Merged

50 tasks

melvin-bot bot added the Overdue label Aug 5, 2024

melvin-bot bot removed the Overdue label Aug 5, 2024

trjExpensify closed this as completed Aug 5, 2024

github-project-automation bot moved this to Done in [#whatsnext] #billpay Aug 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-08-01] [$250] Invoice - Invoice thread opens when starting DM with the user after sending invoice to them #45187

[HOLD for payment 2024-08-01] [$250] Invoice - Invoice thread opens when starting DM with the user after sending invoice to them #45187

lanitochka17 commented Jul 10, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 10, 2024

lanitochka17 commented Jul 10, 2024

bernhardoj commented Jul 11, 2024

trjExpensify commented Jul 11, 2024

melvin-bot bot commented Jul 11, 2024

melvin-bot bot commented Jul 11, 2024

nkdengineer commented Jul 15, 2024

rayane-djouah commented Jul 15, 2024

rayane-djouah commented Jul 16, 2024

melvin-bot bot commented Jul 16, 2024

melvin-bot bot commented Jul 16, 2024

bernhardoj commented Jul 16, 2024

trjExpensify commented Jul 23, 2024

melvin-bot bot commented Jul 25, 2024

melvin-bot bot commented Jul 25, 2024

melvin-bot bot commented Jul 25, 2024

trjExpensify commented Aug 2, 2024

bernhardoj commented Aug 2, 2024

rayane-djouah commented Aug 2, 2024 •

edited

Loading

trjExpensify commented Aug 5, 2024

trjExpensify commented Aug 5, 2024

trjExpensify commented Aug 5, 2024

rayane-djouah commented Aug 5, 2024

trjExpensify commented Aug 5, 2024

JmillsExpensify commented Aug 6, 2024

[HOLD for payment 2024-08-01] [$250] Invoice - Invoice thread opens when starting DM with the user after sending invoice to them #45187

[HOLD for payment 2024-08-01] [$250] Invoice - Invoice thread opens when starting DM with the user after sending invoice to them #45187

Comments

lanitochka17 commented Jul 10, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Jul 10, 2024

lanitochka17 commented Jul 10, 2024

bernhardoj commented Jul 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

trjExpensify commented Jul 11, 2024

melvin-bot bot commented Jul 11, 2024

melvin-bot bot commented Jul 11, 2024

nkdengineer commented Jul 15, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

rayane-djouah commented Jul 15, 2024

rayane-djouah commented Jul 16, 2024

melvin-bot bot commented Jul 16, 2024

melvin-bot bot commented Jul 16, 2024

bernhardoj commented Jul 16, 2024

trjExpensify commented Jul 23, 2024

melvin-bot bot commented Jul 25, 2024

melvin-bot bot commented Jul 25, 2024

melvin-bot bot commented Jul 25, 2024

trjExpensify commented Aug 2, 2024

bernhardoj commented Aug 2, 2024

rayane-djouah commented Aug 2, 2024 • edited Loading

trjExpensify commented Aug 5, 2024

trjExpensify commented Aug 5, 2024

trjExpensify commented Aug 5, 2024

rayane-djouah commented Aug 5, 2024

trjExpensify commented Aug 5, 2024

JmillsExpensify commented Aug 6, 2024

lanitochka17 commented Jul 10, 2024 •

edited by melvin-bot bot

Loading

rayane-djouah commented Aug 2, 2024 •

edited

Loading