[HOLD for payment 2024-07-24] Export to Onyx state not working

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1720630744038239

Action Performed:

1. Go to https://staging.new.expensify.com/settings/troubleshoot from daniel@expensify.com
   2.Try to Export Onyx state
2. I never get a file.
3. I reloaded and navigated to other pages to try and get the button to work and show the Console/Network. But it never ended up working.

Expected Result:

Should get a file

Actual Result:

Never got a file, reloaded and navigated to other pages to try and get the button to work and show the Console/Network. But it never ended up working.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

logs-2024-07-10 16_59_10.654.txt

2024-07-10_09-57-16.1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (AutoAssignerNewDotQuality)

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[techievivek]

I am able to reproduce this on staging.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Export to Onyx state doesn't work on staging/prod.

What is the root cause of that problem?

When pressing Export to Onyx state, we try to read the onyx database by passing the name and version (1).

App/src/libs/ExportOnyxState/index.ts

Line 7 in a19ef98

const openRequest = indexedDB.open(CONST.DEFAULT_DB_NAME, 1);

However, the DB version in staging/prod could be higher than 1.

It's because there is an extra object store that is coming from old localForage of Onyx that is now replaced with idb-keyval. The workaround is to delete the database and relogin.

What changes do you think we should make in order to solve the problem?

To fix and prevent the issue in the future, we can open the database without specifying a specific version so it will just open the current database.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[allgandalf]

Proposal from @bernhardoj LGTM .

The link to docs they provided also state that the DB version is a option parameter:

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @techievivek is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix export onyx state not working #45298

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment through NewDot Manual Requests
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allgandalf] Determine if we should create a regression test for this bug.
• [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[allgandalf]

• The PR that introduced the bug has been identified. Link to the PR: Feature/43097 - "Export onyx state" button in the troubleshoot section #43552

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/43552/files#r1682502662

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open App
2. Open Settings > Troubleshoot
3. Press Export Onyx state

Verify a file will be downloaded

Do we agree 👍 or 👎

[techievivek]

@isabelastisser Can we please get the above regression test added to testrail, thanks.

[isabelastisser]

All set!

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[isabelastisser]

I will be OOO tomorrow and next week, so I am reassigning this until I return on July 29. Thanks, @stephanieelliott!

Status: Payment is due on July 24.

[allgandalf]

Chill melvin payment is on 24th

[allgandalf]

Note

This is due for payment today, thanks :)

[bernhardoj]

Requested in ND.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @bernhardoj owed $250 via NewDot
• ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @allgandalf - $250 via Upwork - PAID
• Contributor+: @bernhardoj $250 via ND - please request

Upwork job is here: https://www.upwork.com/jobs/~1737876297360310272

[allgandalf]

Accepted the offer, thanks :)

[stephanieelliott]

All paid! Thanks.

[JmillsExpensify]

$250 approved for @bernhardoj

[isabelastisser]

Thanks for your help, @stephanieelliott !