[HOLD for payment 2024-08-01] [$250] Click back button, the category picker opens again.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721020681660959

Action Performed:

Prerequisite: There is at least one workspace.

1. Go to self dm.
2. Create any track expense if there is no.
3. Choose "Categorize it" in actionable whisper.
4. Select any workspace. Then the category page opens.
5. Select any category option. Then the confirmation page opens.
6. Click "back" button.

Expected Result:

The participant page opens.

Actual Result:

The category page opens.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-07-15.at.12.19.41.mov

Recording.329.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e2d95899400aa8ef
• Upwork Job ID: 1813006970158052404
• Last Price Increase: 2024-07-16
• Automatic offers:
• dukenv0307 | Reviewer | 103143642
• dominictb | Contributor | 103143643

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• When categorizing expense, the selected category is not highlighted

What is the root cause of that problem?

• Assume we are on the participant screen, with the screen stack as ["Money_Request_Step_Participants"]. When a workspace is selected, it navigates the user to the category picker screen, changing the screen stack to ["Money_Request_Step_Participants", "Money_Request_Step_Category"]. After choosing a category option, the user is navigated to the confirmation screen, resulting in a screen stack of ["Money_Request_Step_Participants", "Money_Request_Step_Category", "Money_Request_Step_Confirmation"]. If the user clicks on the back button, the category picker page is displayed again.

What changes do you think we should make in order to solve the problem?

• We should update:
  

  App/src/pages/iou/request/step/IOURequestStepCategory.tsx

  Lines 147 to 150 in 74a6dbb

  	if (action === CONST.IOU.ACTION.CATEGORIZE) {
  	Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(action, iouType, transactionID, report?.reportID ?? '-1'));
  	return;
  	}

  
  to:

        if (action === CONST.IOU.ACTION.CATEGORIZE) {
            Navigation.goBack()
            Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(action, iouType, transactionID, report?.reportID ?? '-1'));
            return;
        }

it will pop the category picker screen from the screen stack once we choose any category.

What alternative solutions did you explore? (Optional)

[dukenv0307]

Hi @sakluger, I report this bug so I would love to work on this issue as C+. Thanks

[Ahmed-Abdella]

@dukenv0307 Could you please explain why we should we back to the participant page.
is that because we have an option to change the category in the submit page so no need to use the back button to return to the category page.
Is there another reason?

[sakluger]

I think the bug report is correct. Clicking the back button should go to the previous step, not necessarily the preview screen.

On the summary screen (the screen before clicking back), you can click into the category and change it, but the "To workspace" selection is not clickable, and I can't change it any other way. Because of that, I'd consider the Workspace selection as the previous step, and clicking back should take me to that page.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e2d95899400aa8ef

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[marcosdly]

MacOS: Chrome / Safari

Does it have to be tested on metal, or is a virtual machine acceptable?

EDIT: Answer is no. Hadn't checked the contributing documentation, sorry.

[melvin-bot]

📣 @marcosdly! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[dukenv0307]

@dominictb Your proposal looks good to me

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rlinoz]

The Please re-state the problem that we are trying to solve in this issue. section is wrong though, right?

Also, quick question, won't the proposed solution cause any weird looking animations?

[dominictb]

@rlinoz I tested the solution and it works properly without causing any weird looking animations

Screen.Recording.2024-07-16.at.23.43.15.mov

[rlinoz]

Looks good, thanks!

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: remove categorize page from navigation stack #45560

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

• @dukenv0307 requires payment automatic offer (Reviewer)
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dukenv0307] Determine if we should create a regression test for this bug.
• [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

Summarizing payment on this issue:

Contributor: @dominictb $250, paid via Upwork
Contributor+: @dukenv0307 $250, paid via Upwork

[sakluger]

Hey @dukenv0307, could you please complete the BZ checklist?

[dukenv0307]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression tests:

1. Go to self dm.
2. Create any track expense if there is no.
3. Choose "Categorize it" in actionable whisper.
4. Select any workspace. Then the category page opens.
5. Select any category option. Then the confirmation page opens.
6. Click "back" button.
7. Verify The participant page opens.

Do we 👍 or 👎

[dukenv0307]

@sakluger I updated the checklists. BTW, I'm the C+ and @dominictb is C here

[sakluger]

@dukenv0307 thanks for catching that! I updated the payment summary and it should be correct now.

Thanks also for posting the checklist and regression steps. We're all done here!