-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task – Deleted task appears on top of assignee LHN if creator delete it in group chat #45826
Comments
Triggered auto assignment to @kevinksullivan ( |
Triggered auto assignment to @dangrous ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
I believe this relates to the same comment from here. Before, closed tasks were being rendered as archived as shown here. This is why they also floated to the bottom. But not, they're no longer being rendered as archived which is why they're higher up in the LHN. I left a fix in the linked comment but I think this behavior might be expected as well? @puneetlath if you could take a look at this one as well that would be great. Basically, deleted tasks are moving up in the LHN (because of recent activity), rather than moving to the bottom. Conversation to follow along |
Coming from that discussion, I do not think this is a blocker and more so an expected behaviour now that we need to align on |
Yeah I agree, I think this is (new) expected behavior. Product-based question though - to me it would be confusing to see that it jumps up when deleted, but you don't actually know what task was deleted (since it only says Sounds like @puneetlath you'll be the best person to confirm that we should close this out. Thanks! |
In general, that makes sense to me. Which sub-header though? |
Ah ok I see. I think that |
Ah okay that makes sense! Adjusting that would be a follow up anyway - I'll put a note to discuss this in Slack at some point to figure out a better solution, since I think it's worth investigating. But to confirm - this current issue as stated is not an issue, correct? We can close? |
Agreed. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.10-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Go to https://staging.new.expensify.com/
Log in as user A
Open group chat with user B
Create a task without assignee in the chat
Log in as user B in Incognito tab and open task detail
Assign task to me
Navigate to another chat
As user A send any comment in task detail
Delete the task
As user B observe LHN
Expected Result:
Deleted task appears not on top of LHN
Actual Result:
Deleted task appears on top of LHN
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6547691_1721435086016.Del_task.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: