Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task – Deleted task appears on top of assignee LHN if creator delete it in group chat #45826

Closed
3 of 6 tasks
m-natarajan opened this issue Jul 20, 2024 · 11 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.10-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/

  2. Log in as user A

  3. Open group chat with user B

  4. Create a task without assignee in the chat

  5. Log in as user B in Incognito tab and open task detail

  6. Assign task to me

  7. Navigate to another chat

  8. As user A send any comment in task detail

  9. Delete the task

  10. As user B observe LHN

Expected Result:

Deleted task appears not on top of LHN

Actual Result:

Deleted task appears on top of LHN

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6547691_1721435086016.Del_task.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 20, 2024
Copy link

melvin-bot bot commented Jul 20, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 20, 2024

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@srikarparsi
Copy link
Contributor

srikarparsi commented Jul 20, 2024

I believe this relates to the same comment from here. Before, closed tasks were being rendered as archived as shown here. This is why they also floated to the bottom. But not, they're no longer being rendered as archived which is why they're higher up in the LHN. I left a fix in the linked comment but I think this behavior might be expected as well? @puneetlath if you could take a look at this one as well that would be great. Basically, deleted tasks are moving up in the LHN (because of recent activity), rather than moving to the bottom. Conversation to follow along

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Jul 22, 2024
@mountiny
Copy link
Contributor

Coming from that discussion, I do not think this is a blocker and more so an expected behaviour now that we need to align on

@dangrous
Copy link
Contributor

Yeah I agree, I think this is (new) expected behavior. Product-based question though - to me it would be confusing to see that it jumps up when deleted, but you don't actually know what task was deleted (since it only says [Deleted task]. Would it be possible / ideal to keep the task name in there, since we now know it's been deleted due to the subhead there?

Sounds like @puneetlath you'll be the best person to confirm that we should close this out. Thanks!

@puneetlath
Copy link
Contributor

In general, that makes sense to me. Which sub-header though?

@melvin-bot melvin-bot bot added the Overdue label Jul 24, 2024
@dangrous
Copy link
Contributor

dangrous commented Jul 24, 2024

sorry not sure what we call it - the preview in the LHN (deleted task)
Screenshot 2024-07-24 at 15 02 42

Seems like it might be more helpful to say:

Go to the store
deleted task

so you know what was deleted, and it's not repetitive

@melvin-bot melvin-bot bot removed the Overdue label Jul 24, 2024
@puneetlath
Copy link
Contributor

Ah ok I see. I think that deleted task in the LHN is just the last message posted though. So it would go away if you posted another message in there. So if we were to do this, I think we should show somewhere within the task itself that it's deleted.

@dangrous
Copy link
Contributor

Ah okay that makes sense! Adjusting that would be a follow up anyway - I'll put a note to discuss this in Slack at some point to figure out a better solution, since I think it's worth investigating.

But to confirm - this current issue as stated is not an issue, correct? We can close?

@puneetlath
Copy link
Contributor

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants