[Awaiting Payment Request] [$125] Dupe detection -Not here page opens after navigating to confirm page by link and confirming it

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit two same expenses (same amount and merchant)
4. Go to transactiont thread of any expense
5. Click Review duplicates
6. Click Keep this one (any)
7. Proceed to confirmation page
8. Copy the link to confirmation page
9. Go to Account settings > Troubleshoot > Clear cache and restart > Reset and refresh
10. Navigate to the confirmation page via link
11. Click Confirm

Expected Result:

After confirming the review, app will open the transaction thread

Actual Result:

After confirming the review, app redirects to not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547830_1721455455619.20240720_135327.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01156fb1121250d6e8
• Upwork Job ID: 1814753798615808236
• Last Price Increase: 2024-07-20
• Automatic offers:
• dominictb | Contributor | 103215058

Issue Owner

Current Issue Owner: @garrettmknight

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[mountiny]

cc @pecanoro @JmillsExpensify @parasharrajat

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01156fb1121250d6e8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[parasharrajat]

This needs to be handled or we have to block confirm page direct link.

[melvin-bot]

Upwork job price has been updated to $215

[melvin-bot]

Upwork job price has been updated to $125

[mountiny]

Made this external for half price as it seems like a quick fix

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• After confirming the review, app redirects to not here page

What is the root cause of that problem?

• When clicking on Confirm button, reviewDuplicates in this line is undefined since we cleared the cache, so it calls Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(-1) in this line.

What changes do you think we should make in order to solve the problem?

• We should add the FullPageNotFoundView to confirmation page, with shouldShow={!reviewDuplicates}

[mountiny]

Dupe detection is behind beta so we can remove the blocker

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: add not found view if reviewDuplicates is empty #45988

If no regressions arise, payment will be issued on 2024-08-02. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[garrettmknight]

Payment Summary:

• Contributor: @dominictb $125 paid via upwork
• Reviewer: @parasharrajat $125

[garrettmknight]

@parasharrajat can you finish the checklist when you get the chance?

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Feat/dupe detection confirmation #42571
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42571/files#r1704984291
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Go to NewDot.
2. Go to workspace chat.
3. Submit two same expenses (same amount and merchant).
4. Go to transaction thread of any expense.
5. Click Review duplicates.
6. Click Keep this one (any).
7. Proceed to confirmation page.
8. Copy the link to confirmation page.
9. Go to Account settings > Troubleshoot > Clear cache and restart > Reset and refresh.
10. Navigate to the confirmation page via link.

Verify that: The RHP will show not found view

Do you agree 👍 or 👎 ?

[garrettmknight]

QA is up - just waiting on payment request for @parasharrajat

[parasharrajat]

@garrettmknight feel free to close it. I will request it later.

[parasharrajat]

Payment requested as per #45832 (comment)

[JmillsExpensify]

$125 approved for @parasharrajat