[Payment Due 09/11] [$250] Expense - Missing green unread line after marking first expense as unread in expense report

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to DM.
3. Submit two expenses to the user.
4. Click on the expense preview to go to expense report.
5. Right click on the first expense preview.
6. Select Mark as unread.

Expected Result:

The line separator below "Total" will change to a green line with "New" label on the right.

Actual Result:

The line separator below "Total" disappears after marking the first expense as unread.
There is no green unread line.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6547954_1721469511095.20240720_175534.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012c73811fb416526a
• Upwork Job ID: 1815405989806434770
• Last Price Increase: 2024-07-29
• Automatic offers:
• dominictb | Contributor | 103407584

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing green unread line after marking first expense as unread in expense report

What is the root cause of that problem?

In this case we don't display the UnreadActionIndicator component because the shouldUseThreadDividerLine and isFirstVisibleReportAction value is both true

App/src/pages/home/report/ReportActionItem.tsx

Line 913 in f3a8f73

{shouldDisplayNewMarker && (!shouldUseThreadDividerLine || !isFirstVisibleReportAction) && <UnreadActionIndicator reportActionID={action.reportActionID} />}

What changes do you think we should make in order to solve the problem?

Change this code to the following to display the UnreadActionIndicator component if only shouldDisplayNewMarker is true, since we already handled to hide the divider if the shouldHideThreadDividerLine is true. And additionally we need to pass shouldHideThreadDividerLine param to keep the space the same

{shouldDisplayNewMarker && <UnreadActionIndicator reportActionID={action.reportActionID} shouldHideThreadDividerLine={shouldHideThreadDividerLine} />}

RESULT

What alternative solutions did you explore? (Optional)

[Beamanator]

@nyomanjyotisa thanks for your proposal! Can you also help us figure out what PR may have caused this bug?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012c73811fb416526a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The line separator below "Total" disappears after marking the first expense as unread.
There is no green unread line.

What is the root cause of that problem?

When evaluating shouldUseThreadDividerLine, we're not taking into account the shouldHideThreadDividerLine condition here. So for the first expense, it has shouldUseThreadDividerLine true and shouldHideThreadDividerLine also true, that doesn't make sense because the divider line cannot be used and hide at the same time.

This problem causes the condition here to evaluate to false, because shouldUseThreadDividerLine is true while it shouldn't be. So the unread marker does not show.

What changes do you think we should make in order to solve the problem?

Check shouldHideThreadDividerLine here too. If the shouldHideThreadDividerLine is true, the shouldHideThreadDividerLine should be false because the divider line will not be used

if (shouldHideThreadDividerLine) {
    return false;
}

Optionally, we can pass shouldHideThreadDividerLine as param to UnreadActionIndicator here, to be consistent in style with the UnreadActionIndicator here

What alternative solutions did you explore? (Optional)

I think it may not be necessary (and is quite confusing) for shouldHideThreadDividerLine and shouldUseThreadDividerLine to exist as 2 different variables, because they are opposite of each other. We can consolidate them into one by combining the checks in both here and here and use them consistently throughout.

[daledah]

I updated the proposal to add an alternative approach to solve the issue.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The line separator below "Total" disappears after marking the first expense as unread.
There is no green unread line.

What is the root cause of that problem?

In MoneyReportView, we only display the divider here so when the first expense is marked as unread, shouldHideThreadDividerLine is true and then nothing displays.

What changes do you think we should make in order to solve the problem?

We should use renderThreadDivider that we used here in MoneyReportView to cover the case the first expense is unread

const renderThreadDivider = useMemo(
    () =>
        shouldHideThreadDividerLine && !isCombinedReport ? (
            <UnreadActionIndicator
                reportActionID={report.reportID}
                shouldHideThreadDividerLine={shouldHideThreadDividerLine}
            />
        ) : (
            <SpacerView
                shouldShow={!shouldHideThreadDividerLine}
                style={[!shouldHideThreadDividerLine ? styles.reportHorizontalRule : {}]}
            />
        ),
    [shouldHideThreadDividerLine, report.reportID, styles.reportHorizontalRule, isCombinedReport],
);
{(shouldShowReportField || shouldShowBreakdown || shouldShowTotal) && renderThreadDivider}

What alternative solutions did you explore? (Optional)

[francoisl]

Thanks for all the proposals so far. Can anyone identify what PR caused the regression though? It seems like all of suggested code changes aren't in code that changed recently.

[mountiny]

Demoting this because:

• its one of last blockers
• its edge case where user needs to mark the first IOU action as unread
• the chat shows as unread in the LHN so the user would not miss the chat as unread

[melvin-bot]

@Beamanator @sakluger @allroundexperts this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[allroundexperts]

Thanks for the proposals everyone!

@dominictb's proposal looks better to me as it utilises an already used piece of code in another component.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @Beamanator is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

This issue has not been updated in over 15 days. @Beamanator, @sakluger, @allroundexperts, @dominictb eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[dominictb]

@Beamanator @sakluger I think this is long ready for payment

[Beamanator]

Oof yep, this probably got merged & deployed when our automation was broken 🙃

[sakluger]

Sorry about that!

Summarizing payment on this issue:

Contributor: @dominictb $250, paid via Upwork
Contributor+: @allroundexperts $250, please request on Newdot

[sakluger]

@allroundexperts do we need any new regression tests?

[sakluger]

Pasting the BZ checklist here for convenience.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[allroundexperts]

Checklist

1. I wasn't able to pinpoint the exact PR that caused this issue. It seems to me that this is something that was like this when it was first implemented.
2. N/A
3. N/A
4. I think a regression test would be helpful.

Regression test

1. Open the app and go to any direct message
2. Submit two expenses to the user
3. Click on the expense preview to go to expense report
4. Right click on the first expense preview
5. Select Mark as unread.

Verify that the line separator below "Total" will change to a green line with "New" label on the right.

Do we 👍 or 👎 ?

[sakluger]

Looks good to me. Thanks!