[HOLD for payment 2024-08-14] [$250] Login - Entered email is cleared on the login page if the window is resized to small size

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.12-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log out
3. Enter any email address
4. Resize the browser windows to small
5. Resize it to the original size

Expected Result:

Entered email should still be in the field

Actual Result:

Entered email is cleared on the login page if the window is resized to small size

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6552628_1721911184187.bandicam_2024-07-25_14-34-08-742.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0124dcdbeaf4f51b56
• Upwork Job ID: 1818028181753125282
• Last Price Increase: 2024-07-29

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The entered email address is cleared when resizing window.

What is the root cause of that problem?

The login form is wrapped with SignInPageLayout and the login state is inside LoginForm.

App/src/pages/signin/SignInPage.tsx

Lines 273 to 288 in 904e950

	<SignInPageLayout
	welcomeHeader={welcomeHeader}
	welcomeText={welcomeText}
	shouldShowWelcomeHeader={shouldShowWelcomeHeader || !shouldUseNarrowLayout}
	shouldShowWelcomeText={shouldShowWelcomeText}
	ref={signInPageLayoutRef}
	navigateFocus={navigateFocus}
	>
	{/* LoginForm must use the isVisible prop. This keeps it mounted, but visually hidden
	so that password managers can access the values. Conditionally rendering this component will break this feature. */}
	<LoginForm
	ref={loginFormRef}
	isVisible={shouldShowLoginForm}
	blurOnSubmit={account?.validated === false}
	scrollPageToTop={signInPageLayoutRef.current?.scrollPageToTop}
	/>

SignInPageLayout conditionally render the layout structure based on the screen size.

App/src/pages/signin/SignInPageLayout/index.tsx

Lines 84 to 179 in 904e950

	return (
	<View style={containerStyles}>
	{!shouldUseNarrowLayout ? (
	<View style={contentContainerStyles}>
	<ScrollView
	keyboardShouldPersistTaps="handled"
	style={[styles.signInPageLeftContainerWide, styles.flex1]}
	contentContainerStyle={[styles.flex1]}
	>
	<SignInPageContent
	welcomeHeader={welcomeHeader}
	welcomeText={welcomeText}
	shouldShowWelcomeText={shouldShowWelcomeText}
	shouldShowWelcomeHeader={shouldShowWelcomeHeader}
	>
	{children}
	</SignInPageContent>
	</ScrollView>
	<ScrollView
	style={[styles.flex1, StyleUtils.getBackgroundColorStyle(theme.signInPage)]}
	contentContainerStyle={[styles.flex1]}
	ref={scrollViewRef}
	>
	<View style={[styles.flex1]}>
	<View style={styles.signInPageHeroCenter}>
	<BackgroundImage
	isSmallScreen={false}
	pointerEvents="none"
	width={variables.signInHeroBackgroundWidth}
	transitionDuration={CONST.BACKGROUND_IMAGE_TRANSITION_DURATION}
	/>
	</View>
	<View>
	<View style={[styles.t0, styles.l0, styles.h100, styles.pAbsolute, styles.signInPageGradient]}>
	<ImageSVG
	src={SignInGradient}
	height="100%"
	preserveAspectRatio="none"
	/>
	</View>
	<View
	style={[
	styles.alignSelfCenter,
	StyleUtils.getMaximumWidth(variables.signInContentMaxWidth),
	isMediumScreenWidth ? styles.ph10 : {},
	isLargeScreenWidth ? styles.ph25 : {},
	]}
	>
	<SignInPageHero
	customHeadline={customHeadline}
	customHeroBody={customHeroBody}
	/>
	<Footer navigateFocus={navigateFocus} />
	</View>
	</View>
	</View>
	</ScrollView>
	</View>
	) : (
	<ScrollView
	contentContainerStyle={scrollViewStyles}
	keyboardShouldPersistTaps="handled"
	ref={scrollViewRef}
	>
	<View
	style={[
	styles.flex1,
	styles.flexColumn,
	Browser.isMobileSafari() ? styles.overflowHidden : {},
	StyleUtils.getMinimumHeight(backgroundImageHeight),
	StyleUtils.getSignInBgStyles(theme),
	]}
	>
	<View style={[styles.pAbsolute, styles.w100, StyleUtils.getHeight(backgroundImageHeight), StyleUtils.getBackgroundColorStyle(theme.highlightBG)]}>
	<BackgroundImage
	isSmallScreen
	pointerEvents="none"
	width={variables.signInHeroBackgroundWidthMobile}
	transitionDuration={CONST.BACKGROUND_IMAGE_TRANSITION_DURATION}
	/>
	</View>
	<SignInPageContent
	welcomeHeader={welcomeHeader}
	welcomeText={welcomeText}
	shouldShowWelcomeText={shouldShowWelcomeText}
	shouldShowWelcomeHeader={shouldShowWelcomeHeader}
	>
	{children}
	</SignInPageContent>
	</View>
	<View style={[styles.flex0]}>
	<Footer navigateFocus={navigateFocus} />
	</View>
	</ScrollView>
	)}
	</View>

So, when the structure is different, the LoginForm is remounted, losing all of its state.

What changes do you think we should make in order to solve the problem?

Move up the login state from BaseLoginForm to SignInPage, then pass the state down to BaseLoginForm.

const [login, setLogin] = useState(() => Str.removeSMSDomain(credentials?.login ?? ''));

<LoginForm login={login} updateLogin={setLogin} ... />

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login - Entered email is cleared on the login page if the window is resized to small size

What is the root cause of that problem?

The login is saved in login state of BaseLoginForm but the login form is children of SignInPageLayout which displays it's children withdifferent layout according to the window size and doing so it conditionally returns two instances of the login form and when the window size changes it unmounts the prev login form and the login data disappears along with it.
But the same happens for ValidateCodeForm too.

What changes do you think we should make in order to solve the problem?

We should to take all the states of both BaseLoginForm

App/src/pages/signin/LoginForm/BaseLoginForm.tsx

Lines 61 to 62 in b0f810d

	const [login, setLogin] = useState(() => Str.removeSMSDomain(credentials?.login ?? ''));
	const [formError, setFormError] = useState<string | undefined>();

and BaseValidateCodeForm

App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.tsx

Lines 64 to 69 in b0f810d

	const [formError, setFormError] = useState<FormError>({});
	const [validateCode, setValidateCode] = useState(credentials?.validateCode ?? '');
	const [twoFactorAuthCode, setTwoFactorAuthCode] = useState('');
	const [timeRemaining, setTimeRemaining] = useState(30);
	const [recoveryCode, setRecoveryCode] = useState('');
	const [needToClearError, setNeedToClearError] = useState<boolean>(!!account?.errors);

up into SigninPage and pass the states and setters of the states down to the two login and validate code form components
Of course we can also use Context instead of state if needed.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0124dcdbeaf4f51b56

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[mananjadhav]

Both the proposals identify the root cause correctly, and I think we should use the state instead of Context.

Considering the proposals are on similar lines, @bernhardoj's proposal looks good to me.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[bernhardoj]

PR is ready

cc: @mananjadhav

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix login is cleared when resizing window #46696

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

@sakluger This one's also ready for payout. I know we've had this state setup since a very long time. We had also closed this issue once. I don't think we have an offending PR here as this only occurs when one resizes the window. Considering this I also don't think we need a regression test for this one.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mananjadhav owed $250 via NewDot
• Reviewer: @bernhardoj owed $250 via NewDot

BugZero Checklist (@sakluger)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1818028181753125282/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[sakluger]

Thanks @mananjadhav!

@JmillsExpensify we can use the payment summary in the comment above.

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @mananjadhav

[JmillsExpensify]

$250 approved for @bernhardoj